AutoMigration fails on foreign key change [352085724]

Fixed

Bug

Status Update

No update yet.

Description

xz...@gmail.com

created issue #1

Jul 10, 2024 09:20AM

Component used: KAPT
Version used: 2.6.1
Devices/Android versions reproduced on: All

I have multiple tables where I must add a new `appId` column.
This new `appId` is part of my foreign key constraints.

The problem is that Room applies the table migration alphabetically but then checks for the foreign key constraints after each table migration.
Therefore, my foreign key is not OK since the old table doesn't have the new column yet.

Example:
Table_A: id, name, tableB_id
Table_B: id, name
Room will add the "appId" to Table_A and set the foreign key constraint to be on the columns `tableB_id` and `appId`, then execute:
DBUtil.foreignKeyCheck(db, "Table_A");

Yet, at that point, Table_B is still: id, name — and not: id, name, appId.

Comments

el...@google.com <el...@google.com> #2Jul 10, 2024 10:02AM

Another instance:

https://android-build.googleplex.com/builds/pending/P10986006/androidx_host_tests_max_dep_versions/latest/view/logs/build_error.log

which says:

The message received from the daemon indicates that the daemon has disappeared.
Build request sent: Build{id=0aba0dd6-d140-4723-8ae6-1c8cecbfba77, currentDir=/buildbot/src/android/androidx-master-dev}
Attempting to read last messages from the daemon log...
Daemon pid: 15649
log file: /buildbot/src/android/androidx-master-dev/out/.gradle/daemon/6.0/daemon-15649.out.log
----- Last 20 lines from daemon log file - daemon-15649.out.log -----
I/MonitoringInstr: Setting context classloader to 'org.robolectric.internal.AndroidSandbox$SdkSandboxClassLoader@18f946ad', Original: 'org.robolectric.internal.AndroidSandbox$SdkSandboxClassLoader@18f946ad'

androidx.camera.camera2.impl.Camera2CameraInfoImplTest > cameraInfo_canCalculateCorrectRelativeRotation_forBackCamera[22] STANDARD_OUT
[Robolectric] androidx.camera.camera2.impl.Camera2CameraInfoImplTest.cameraInfo_canCalculateCorrectRelativeRotation_forBackCamera: sdk=22; resources=BINARY
Gradle Test Executor 109 started executing tests.
Note: /buildbot/src/android/androidx-master-dev/frameworks/support/work/integration-tests/testapp/src/main/java/androidx/work/integration/testapp/sherlockholmes/TextReducingWorker.java uses or overrides a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
Stream closed

androidx.camera.camera2.impl.Camera2CameraInfoImplTest > cameraInfo_canCalculateCorrectRelativeRotation_forBackCamera[23] STANDARD_OUT
[Robolectric] androidx.camera.camera2.impl.Camera2CameraInfoImplTest.cameraInfo_canCalculateCorrectRelativeRotation_forBackCamera: sdk=23; resources=BINARY

androidx.camera.core.CameraCaptureResultsTest > canRetrieveCameraCaptureResult[27] STANDARD_OUT
androidx.enterprise.feedback.KeyedAppStatesServiceTest STANDARD_ERROR
[Robolectric] androidx.camera.core.CameraCaptureResultsTest.canRetrieveCameraCaptureResult: sdk=27; resources=BINARY
[Robolectric] WARN: Android SDK 10000 requires Java 9 (have Java 8). Tests won't be run on SDK 10000 unless explicitly requested.
I/MonitoringInstr: Instrumentation started!
I/MonitoringInstr: Setting context classloader to 'org.robolectric.internal.AndroidSandbox$SdkSandboxClassLoader@215389e1', Original: 'org.robolectric.internal.AndroidSandbox$SdkSandboxClassLoader@215389e1'
Created classpath snapshot for incremental compilation in 0.439 secs. 253 duplicate classes found in classpath (see all with --debug).
----- End of the daemon log -----

ap...@google.com <ap...@google.com> #3Jul 18, 2024 03:15PM

Hmm, it doesn't seem to be specific to the androidx_host_tests_max_dep_versions target though because these failed (in postsubmit) too:

https://android-build.googleplex.com/builds/submitted/6068752/androidx_max_dep_versions/latest/view/logs/build_error.log

https://android-build.googleplex.com/builds/submitted/6068534/androidx_test_dependent_apks/latest/view/logs/build_error.log

https://android-build.googleplex.com/builds/submitted/6068188/androidx_test_changed_apks/latest/view/logs/build_error.log

Each of these three seems to say the same thing, but it's different from the two above:

The message received from the daemon indicates that the daemon has disappeared.
Build request sent: Build{id=52088053-6fbd-4436-8aab-5e305f8428aa, currentDir=/usr/local/google/buildbot/src/android/androidx-master-dev}
Attempting to read last messages from the daemon log...
Daemon pid: 28679
log file: /usr/local/google/buildbot/src/android/androidx-master-dev/out/.gradle/daemon/6.0/daemon-28679.out.log
----- Last 20 lines from daemon log file - daemon-28679.out.log -----
Note: Some input files use or override a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
Note: Some input files use or override a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
Note: /usr/local/google/buildbot/src/android/androidx-master-dev/frameworks/support/lifecycle/integration-tests/testapp/src/main/java/androidx/lifecycle/testapp/FrameworkLifecycleRegistryActivity.java uses or overrides a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
Note: Some input files use or override a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
Note: Some input files use unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.
Note: /usr/local/google/buildbot/src/android/androidx-master-dev/frameworks/support/lifecycle/integration-tests/testapp/src/androidTest/java/androidx/lifecycle/SynchronousActivityLifecycleTest.java uses or overrides a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
/usr/local/google/buildbot/src/android/androidx-master-dev/frameworks/support/room/integration-tests/noappcompattestapp/src/androidTest/java/androidx/room/integration/noappcompat/BareRelationDatabaseTest.java:95: warning: The return value includes a POJO with a @Relation. It is usually desired to annotate this method with @Transaction to avoid possibility of inconsistent results between the POJO and its relations. See

https://developer.android.com/reference/android/arch/persistence/room/Transaction.html for details.
UserAndPets getUserWithPets(long id);
^
/usr/local/google/buildbot/src/android/androidx-master-dev/frameworks/support/room/integration-tests/noappcompattestapp/src/androidTest/java/androidx/room/integration/noappcompat/BareRelationDatabaseTest.java:98: warning: The return value includes a POJO with a @Relation. It is usually desired to annotate this method with @Transaction to avoid possibility of inconsistent results between the POJO and its relations. See

https://developer.android.com/reference/android/arch/persistence/room/Transaction.html for details.
List<UserAndPet> getUsersWithPet();
^
2 warnings
Stream closed
----- End of the daemon log -----

el...@google.com <el...@google.com> #4Aug 5, 2024 02:08PM

Marked as fixed.

Hmm it looks like we only have a couple of types of messages that appear in the daemon log before the daemon dies

I wonder if we should disable a couple of these things (maybe BareRelationDatabaseTest?) until we can figure out the root cause?

xz...@gmail.com <xz...@gmail.com> #5Aug 5, 2024 02:10PM

More examples:

https://android-build.googleplex.com/builds/submitted/6084172/androidx_max_dep_versions/latest/view/logs/build_error.log

https://android-build.googleplex.com/builds/submitted/6083813/androidx_host_tests_max_dep_versions/latest/view/logs/build_error.log

pr...@google.com <pr...@google.com> #6Aug 13, 2024 06:58PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit e72d230e942687e5d09637c24005a0b2916cdc7c
Author: Jeff Gaston <jeffrygaston@google.com>
Date: Thu Dec 19 18:32:31 2019

Telling Gradle to initially request all of the memory that it will ever request

(only when DIST_DIR is set)

to rule out the possibility that the Gradle daemon might be unable to acquire more memory from the host system in the middle of the build and then crashing with an out-of-memory error.

Also, in cases where Gradle does eventually use as much memory as allowed, this should slightly improve performance.

Bug: 146217083
Test: DIST_DIR=../../out/dist ./gradlew --no-daemon projects # and see that it doesn't take any more time to run with this change vs without
Test: ./gradlew --no-daemon projects
Test: DIST_DIR=../../out/dist ./gradlew --no-daemon --info 2>&1 | grep -i Xmx | head -n 1 | grep Xms
Test: ./gradlew --no-daemon --info 2>&1 | grep -i Xmx | head -n 1 | grep Xms # and see there are no matches

Change-Id: Id6c0c45c375a3f1a836af0d473f9146f3f99d103

M gradle.properties
M gradlew
M ui/gradle.properties

https://android-review.googlesource.com/1196714

xz...@gmail.com <xz...@gmail.com> #7Feb 5, 2025 03:19PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit 142922509089a6c77a00c98d8d05cedd9ea4a603
Author: Jeff Gaston <jeffrygaston@google.com>
Date: Tue Jan 07 11:54:44 2020

Moving org.gradle.jvmargs back into gradle.properties where Studio can find them

Bug: 146217083
Test: DIST_DIR=../../out/dist ./gradlew --no-daemon projects # and see that it doesn't take any more time to run with this change vs without
Test: ./gradlew --no-daemon projects
Test: ./gradlew studio
Change-Id: I451b93441bf89d6e4d0dcf6a2398669d0a640494

M gradle.properties
M gradlew
M ui/gradle.properties

https://android-review.googlesource.com/1202263

el...@google.com <el...@google.com> #8Feb 5, 2025 05:16PM

Aurimas encountered another one:

https://android-build.googleplex.com/builds/pending/P11308389/androidx_test_dependent_apks/latest/view/logs/build_error.log

which says this:

----- Last 20 lines from daemon log file - daemon-3895.out.log -----
Note: Recompile with -Xlint:deprecation for details.
Note: Some input files use unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.
/usr/local/google/buildbot/src/android/androidx-master-dev/out/androidx/benchmark/integration-tests/startup-benchmark/build/intermediates/tmp/manifest/androidTest/release/manifestMerger888282319339507581.xml:32:5-38:19 Warning:
application@android:debuggable was tagged at manifestMerger888282319339507581.xml:32 to replace other declarations but no other declaration present
/usr/local/google/buildbot/src/android/androidx-master-dev/out/androidx/benchmark/integration-tests/dry-run-benchmark/build/intermediates/tmp/manifest/androidTest/release/manifestMerger4233420038045179579.xml:32:5-38:19 Warning:
application@android:debuggable was tagged at manifestMerger4233420038045179579.xml:32 to replace other declarations but no other declaration present
Note: Some input files use or override a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
Note: Some input files use or override a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
Note: /usr/local/google/buildbot/src/android/androidx-master-dev/frameworks/support/lifecycle/integration-tests/testapp/src/main/java/androidx/lifecycle/testapp/FrameworkLifecycleRegistryActivity.java uses or overrides a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
Note: /usr/local/google/buildbot/src/android/androidx-master-dev/frameworks/support/lifecycle/integration-tests/testapp/src/androidTest/java/androidx/lifecycle/SynchronousActivityLifecycleTest.java uses or overrides a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
Note: Some input files use or override a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
Note: Some input files use unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.
Stream closed
----- End of the daemon log -----