Fixed
Status Update
Comments
el...@google.com <el...@google.com> #2
Hi. Thanks for reporting this. Fixed in alpha-04
ap...@google.com <ap...@google.com> #3
Project: platform/frameworks/support
Branch: androidx-main
commit e782987543a9f8ccd485e970ddc74564b24378db
Author: Vighnesh Raut <vighnesh.raut13@gmail.com>
Date: Mon Jan 02 15:27:40 2023
fix: tab row crashes when only 1 tab is added
Bug: b/264018028
Test: Added unit test
Change-Id: I6381dbac304fc1d69d3708c6655f8b595668e93f
M tv/tv-material/src/androidTest/java/androidx/tv/material/TabRowTest.kt
M tv/tv-material/src/main/java/androidx/tv/material/TabRow.kt
https://android-review.googlesource.com/2373449
Branch: androidx-main
commit e782987543a9f8ccd485e970ddc74564b24378db
Author: Vighnesh Raut <vighnesh.raut13@gmail.com>
Date: Mon Jan 02 15:27:40 2023
fix: tab row crashes when only 1 tab is added
Bug:
Test: Added unit test
Change-Id: I6381dbac304fc1d69d3708c6655f8b595668e93f
M tv/tv-material/src/androidTest/java/androidx/tv/material/TabRowTest.kt
M tv/tv-material/src/main/java/androidx/tv/material/TabRow.kt
xz...@gmail.com <xz...@gmail.com> #5
The following release(s) address this bug.It is possible this bug has only been partially addressed:
androidx.tv:tv-material:1.0.0-alpha04
pr...@google.com <pr...@google.com> #6
The following release(s) address this bug.It is possible this bug has only been partially addressed:
androidx.room:room-compiler:2.7.0-alpha06
xz...@gmail.com <xz...@gmail.com> #7
Better late than never, I could test this in 2.7.0-alpha11, which works as expected. The foreign key checks are all grouped at the end of the migrations
el...@google.com <el...@google.com> #8
Thanks for the update!
Description
Version used: 2.6.1
Devices/Android versions reproduced on: All
I have multiple tables where I must add a new `appId` column.
This new `appId` is part of my foreign key constraints.
The problem is that Room applies the table migration alphabetically but then checks for the foreign key constraints after each table migration.
Therefore, my foreign key is not OK since the old table doesn't have the new column yet.
Example:
Table_A: id, name, tableB_id
Table_B: id, name
Room will add the "appId" to Table_A and set the foreign key constraint to be on the columns `tableB_id` and `appId`, then execute:
DBUtil.foreignKeyCheck(db, "Table_A");
Yet, at that point, Table_B is still: id, name — and not: id, name, appId.