Make Shared Element Transition Library work with ListDetailPaneScaffold [352297792]

Assigned

Bug

Status Update

No update yet.

Description

ro...@google.com

created issue #1

Jul 10, 2024 02:04PM

I tried to implement Shared Element Transition with ListDetailPaneScaffold, but for some reasons, it doesn't play the animation (the Shared Content State cannot find a match).

Could you look into it?

list-detail-compose.zip

513 KB

Download

Comments

ro...@google.com <ro...@google.com> #2Jul 10, 2024 02:22PM

Tram, can you confirm that the behavior is correct if the modifier is moved to the composable inside the AnimatedPane?

ia...@google.com <ia...@google.com> Jul 11, 2024 05:17PM

Assigned to co...@google.com.

co...@google.com <co...@google.com> #3Jul 17, 2024 05:03PM

Hi Max, yes when the modifiers are moved to the composable inside the AnimatedPane, the PB animations are better than when the modifiers are in the AnimatedPane itself

ia...@google.com <ia...@google.com> #4Jul 18, 2024 10:18PM

Reassigned to ro...@google.com.

Given the straightforward workaround in comment#3, I'm going to downgrade the priority of this bug for now

dm...@8x8.com <dm...@8x8.com> #5Sep 14, 2024 04:59PM

After some investigation, I can conclude this behavior is consistent with other animation "wrapper" composables, e.g. AnimatedVisibility. Modifiers should indeed be applied to the children in order to properly participate in the animation.

dm...@8x8.com <dm...@8x8.com> #6Jan 13, 2025 03:50PM

At the very least, adding an enabled parameter to the sharedElement modifier would be helpful so that we can disable the shared element transition in the case of both source and target panes being shown.

Issue 352297792