Fixed
Status Update
No update yet.
Comments
ch...@google.com
mt...@gmail.com
Project: platform/frameworks/support
Branch: androidx-master-dev
commit 5e3ad2f16b7d4814f413d8ae71de20bf63239477
Author: Ian Lake <ilake@google.com>
Date: Wed Mar 04 14:30:58 2020
Add a @LayoutId constructor to DialogFragment
Allow developers to provide a @LayoutId to
DialogFragment to provide parity with Fragment.
Test: Updated fragment-testing tests still pass
BUG: 150327080
Change-Id: I9b480a29921cb9a354ef9e0d209a4b7be1f91bf7
M fragment/fragment-testing/src/androidTest/java/androidx/fragment/app/testing/SimpleDialogFragment.kt
M fragment/fragment/api/1.3.0-alpha02.txt
M fragment/fragment/api/current.txt
M fragment/fragment/api/public_plus_experimental_1.3.0-alpha02.txt
M fragment/fragment/api/public_plus_experimental_current.txt
M fragment/fragment/api/restricted_1.3.0-alpha02.txt
M fragment/fragment/api/restricted_current.txt
M fragment/fragment/src/main/java/androidx/fragment/app/DialogFragment.java
https://android-review.googlesource.com/1250165
Branch: androidx-master-dev
commit 5e3ad2f16b7d4814f413d8ae71de20bf63239477
Author: Ian Lake <ilake@google.com>
Date: Wed Mar 04 14:30:58 2020
Add a @LayoutId constructor to DialogFragment
Allow developers to provide a @LayoutId to
DialogFragment to provide parity with Fragment.
Test: Updated fragment-testing tests still pass
BUG: 150327080
Change-Id: I9b480a29921cb9a354ef9e0d209a4b7be1f91bf7
M fragment/fragment-testing/src/androidTest/java/androidx/fragment/app/testing/SimpleDialogFragment.kt
M fragment/fragment/api/1.3.0-alpha02.txt
M fragment/fragment/api/current.txt
M fragment/fragment/api/public_plus_experimental_1.3.0-alpha02.txt
M fragment/fragment/api/public_plus_experimental_current.txt
M fragment/fragment/api/restricted_1.3.0-alpha02.txt
M fragment/fragment/api/restricted_current.txt
M fragment/fragment/src/main/java/androidx/fragment/app/DialogFragment.java
ap...@google.com
We've added a DialogFragment(@LayoutRes) constructor and it'll be available in Fragment 1.3.0-alpha02.
Note that subclasses of DialogFragment (such as BottomSheetDialogFragment) will need to be updated to depend on Fragment 1.3.0-alpha02 and add a constructor themselves before you'll be able to use it in those cases. You'd want to file a feature request against them.
Description
Some of the
***Resourcehelpers are not configuration-changing aware.Specifically,
integerResourceintegerArrayResourcedimensionResourcebooleanResourcecolorResourcefontResourceall do not have a key on
Configuration, unlikestringResource,painterResourceand others.This means that this resources will not correctly update if the configuration changes (changing the resource value) and the
Activityis not recreated (due to opting out of recreation).