Add configuration change support to all resource types [352336694]

Fixed

Bug

Status Update

No update yet.

Description

va...@google.com

created issue #1

Jul 10, 2024 05:10PM

Some of the ***Resource helpers are not configuration-changing aware.

Specifically,

integerResource
integerArrayResource
dimensionResource
booleanResource
colorResource
fontResource

all do not have a key on Configuration, unlike stringResource, painterResource and others.

This means that this resources will not correctly update if the configuration changes (changing the resource value) and the Activity is not recreated (due to opting out of recreation).

Comments

ch...@google.com <ch...@google.com> Jul 11, 2024 06:17PM

Assigned to je...@google.com.

mt...@gmail.com <mt...@gmail.com> #2Aug 7, 2024 09:29AM

selection by word / line with shift + mouse after a double- and triple-click

ap...@google.com <ap...@google.com> #3Oct 14, 2024 10:17PM

Project: platform/frameworks/support
Branch: androidx-main

commit 6a8b2538d1eb61c8feeddcfe2a108e377e91671a
Author: Andrey Rudenko <andrei.rudenko@jetbrains.com>
Date: Fri Feb 19 10:37:26 2021

Better mouse support in TextField

- migrates to a new gestures API
- adds support for selection-with-shift

Bug: 180639271
Test: ./gradlew :compose:foundation:foundation:connectedAndroidTest
Relnote: N/A
Change-Id: Iaefd4213af6583df02a0b85907d0294cdc1be01f

M compose/foundation/foundation/api/1.0.0-beta02.txt
M compose/foundation/foundation/api/current.txt
M compose/foundation/foundation/api/public_plus_experimental_1.0.0-beta02.txt
M compose/foundation/foundation/api/public_plus_experimental_current.txt
M compose/foundation/foundation/api/restricted_1.0.0-beta02.txt
M compose/foundation/foundation/api/restricted_current.txt
A compose/foundation/foundation/src/androidMain/kotlin/androidx/compose/foundation/text/selection/TextFieldSelectionManager.android.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/text/CoreTextField.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/text/TextFieldGestureModifiers.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/text/selection/TextFieldSelectionManager.kt
A compose/foundation/foundation/src/desktopMain/kotlin/androidx/compose/foundation/text/selection/TextFieldSelectionManager.desktop.kt
M compose/foundation/foundation/src/desktopTest/kotlin/androidx/compose/foundation/text/selection/DesktopTextFieldSelectionManagerTest.kt

https://android-review.googlesource.com/1596032

va...@google.com <va...@google.com> Oct 14, 2024 10:34PM

Marked as fixed, reassigned to jd...@google.com.

pr...@google.com <pr...@google.com> #4Oct 30, 2024 05:38PM

Project: platform/frameworks/support
Branch: androidx-main

commit d6c91be0eb229033bd6bab039e770275f358bb1d
Author: Andrey Rudenko <andrei.rudenko@jetbrains.com>
Date: Thu Mar 18 15:45:20 2021

Mouse Selection improvements

- uniform support of mouse selection in CoreText and CoreTextField
- support of selection expansion/shrinking with shift pressed clicks
- double- (select by word) and triple- (select by paragraph) support

Change-Id: I031fcd716c8e795efb5c7e355b123d2d92458f0e
Test: ./gradlew :compose:foundation:foundation:connectedAndroidTest
Bug: 180639271
Bug: 139322105
Relnote: N/A

M compose/foundation/foundation/api/1.0.0-beta05.txt
M compose/foundation/foundation/api/current.txt
M compose/foundation/foundation/api/public_plus_experimental_1.0.0-beta05.txt
M compose/foundation/foundation/api/public_plus_experimental_current.txt
M compose/foundation/foundation/api/restricted_1.0.0-beta05.txt
M compose/foundation/foundation/api/restricted_current.txt
M compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/text/selection/MultiWidgetSelectionDelegateTest.kt
M compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/text/selection/TextFieldSelectionDelegateTest.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/text/CoreText.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/text/CoreTextField.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/text/StringHelpers.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/text/TextFieldGestureModifiers.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/text/selection/MultiWidgetSelectionDelegate.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/text/selection/Selectable.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/text/selection/SelectionManager.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/text/selection/SelectionRegistrar.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/text/selection/SelectionRegistrarImpl.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/text/selection/TextFieldSelectionDelegate.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/text/selection/TextFieldSelectionManager.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/text/selection/TextPreparedSelection.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/text/selection/TextSelectionDelegate.kt
A compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/text/selection/TextSelectionMouseDetector.kt
M compose/foundation/foundation/src/desktopTest/kotlin/androidx/compose/foundation/text/selection/DesktopTextFieldSelectionManagerTest.kt
M compose/foundation/foundation/src/test/kotlin/androidx/compose/foundation/text/TextSelectionLongPressDragTest.kt
M compose/foundation/foundation/src/test/kotlin/androidx/compose/foundation/text/selection/MockSelectable.kt
M compose/foundation/foundation/src/test/kotlin/androidx/compose/foundation/text/selection/SelectionManagerDragTest.kt
M compose/foundation/foundation/src/test/kotlin/androidx/compose/foundation/text/selection/SelectionManagerTest.kt
A compose/foundation/foundation/src/test/kotlin/androidx/compose/foundation/text/selection/StringHelpersTest.kt

https://android-review.googlesource.com/1645491

Issue 352336694