Adding srcs dir via Variant API not working as expected [352352252]

Fixed

Bug

Status Update

No update yet.

Description

da...@google.com

created issue #1

Jul 10, 2024 06:29PM

I want to add a new asset directory to the Android instrumentation tests via the Variant API, but it is not working as the DSL API. I have attached a sample project that reproduces the issue.

In the build.gradle.kts I have:

val androidComponents = extensions.findByType(AndroidComponentsExtension::class.java)
androidComponents!!.onVariants { variant ->
  if (variant is HasAndroidTest) {
    variant.androidTest?.sources?.assets?.addStaticSourceDirectory("$projectDir/schemas")
  }
}

but when I run my test that validates that the asset file is present, it fails:

❯ ./gradlew app:cAT --rerun-tasks

> Task :app:connectedDebugAndroidTest
Starting 1 tests on Pixel_8_API_33(AVD) - 13

dany.agp.bug.ExampleInstrumentedTest > checkAssetFile[Pixel_8_API_33(AVD) - 13] FAILED 
        java.io.FileNotFoundException: HelloWorld.txt
        at android.content.res.AssetManager.nativeOpenAsset(Native Method)
Tests on Pixel_8_API_33(AVD) - 13 failed: There was 1 failure(s).

Finished 1 tests on Pixel_8_API_33(AVD) - 13

> Task :app:connectedDebugAndroidTest FAILED

I can also see the APK is missing the files:

❯ unzip -l ./app/build/outputs/apk/androidTest/debug/app-debug-androidTest.apk | grep assets

if I comment out the Variant APIs lines above and instead use the 'older' DSL:

android {
  sourceSets {
    getByName("androidTest").assets.srcDir("$projectDir/schemas")
  }
}

then things work as expected:

❯ ./gradlew app:cAT --rerun-tasks                                                           

> Task :app:connectedDebugAndroidTest
Starting 1 tests on Pixel_8_API_33(AVD) - 13

Finished 1 tests on Pixel_8_API_33(AVD) - 13

BUILD SUCCESSFUL in 17s

and the APK also contains the expected asset files:

❯ unzip -l ./app/build/outputs/apk/androidTest/debug/app-debug-androidTest.apk | grep assets
        5  01-01-1981 01:01   assets/HelloWorld.txt

Let me know if you need any more information.

AGPAssetsDirBug.zip

106 KB

Download

Comments

sp...@google.com <sp...@google.com> #2Jul 10, 2024 06:49PM

Assigned to sp...@google.com.

Matthew, any thoughts on how best to do this? I know that we have the LanguageFeatureProvider abstraction in the Java plugin (and our own AndroidLanguageFeatureProvider which does API level checks) in order to silence a number of inspections. But this particular inspection (JavaApiUsageInspection) does not seem to reference any JavaFeatures, it unconditionally reports them.

da...@google.com <da...@google.com> #3Jul 10, 2024 06:55PM

Fixed by Change I7a57ba085bfd8c64679cf4bf3c05ce70da8cb5b8 using the InspectionSuppressor EP.

sp...@google.com <sp...@google.com> #4Jul 10, 2024 07:01PM

Thank you for your patience while our engineering team worked to resolve this issue. A fix for this issue is now available in:

Android Studio Koala | 2024.1.1 Canary 4
Android Gradle Plugin 8.5.0-alpha04

We encourage you to try the latest update.

If you notice further issues or have questions, please file a new bug report.

Thank you for taking the time to submit feedback — we really appreciate it!

da...@google.com <da...@google.com> #5Jul 10, 2024 07:20PM

Android Studio Koala | 2024.1.1 Canary 4
Android Gradle Plugin 8.5.0-alpha04

does not work...

Objects.requireNonNullElse(

is still flagged as error

sp...@google.com <sp...@google.com> #6Jul 10, 2024 07:23PM

Gradle Plugin 8.5.0-alpha04 seems be very broken in fact. My project does not even deploy now due to missing classes in the dex. I tried invalidating caches, full rebuild, a fresh emulator install....

Reverting to 8.3.2 and all is well again.

sp...@google.com <sp...@google.com> #7Jul 11, 2024 05:32PM

Android Studio Koala | 2024.1.1 Canary 7
Android Gradle Plugin 8.4
Gradle 8.7

Still an issue

sp...@google.com <sp...@google.com> #8Jul 12, 2024 02:42PM

I'm not seeing this using the latest Koala canary and the above test case. Can you provide more instructions for how to reproduce what you're seeing?

sp...@google.com <sp...@google.com> #9Jul 22, 2024 07:39PM

Marked as fixed.

No idea what is going on to be fair....

a brand new project, and requireNonNullElse shows no problem.
any existing project of mine (checked 4) show the problem.

However, it seems Gradle Plugin 8.4 is having the same problems as I saw with 8.5.0-alpha04. Missing classes in the dex / failures to build. The identical setup with Plugin 8.3.2 and all builds/deploys fine (except the RNNE warning obviously)

rant... each "upgrade" brings new problems.... I'll need to drop back to 8.3.2 AGAIN for now.

If/when eventually the gradle plugin decides to play nice again, I'll check the RNNE again.

an...@google.com <an...@google.com> #10Aug 6, 2024 10:15PM

ok - I managed to fix the AGP 8.4 upgrade issue.

Current setup: Koala canary 8 + AGP 8.4 + Gradle 8.7

Android Studio Koala | 2024.1.1 Canary 8 Build #AI-241.15989.150.2411.11792637, built on May 2, 2024 Runtime version: 17.0.10+8-b1207.12 amd64 VM: OpenJDK 64-Bit Server VM by JetBrains s.r.o. Windows 11.0 GC: G1 Young Generation, G1 Old Generation Memory: 12288M Cores: 20 Registry: ide.browser.jcef.testMode.enabled=true ide.browser.jcef.sandbox.enable=false ide.images.show.chessboard=true Non-Bundled Plugins: name.kropp.intellij.makefile (241.14494.150) artsiomch.cmake (241.1.1)

a brand new project, and requireNonNullElse shows no problem.
requireNonNullElse is still showing up as error in existing projects

an...@google.com <an...@google.com> #11Aug 9, 2024 12:55AM

Hm. Any other clues for how the two scenarios might be different? Do they have the same minSdkVersion? Is the usage in a library or in an app module? Is one of the projects using core library desugaring?