Progress indicator does not guard against NaN [352364576]

Fixed

Bug

Status Update

No update yet.

Description

di...@gmail.com

created issue #1

Jul 10, 2024 07:19PM

Jetpack Compose version: androidx.compose:compose-bom:2024.06.00

Material Library Version (M2, M3 or Both?): M3

Material Compose component used: androidx.compose.material3:material3

Android Studio Build: 2024.1.1

Kotlin version: 1.9.24

Passing NaN to LinearProgressIndicator will cause the following crash; seems that coercedProgress() does not handle NaNs.

    at androidx.compose.ui.semantics.ProgressBarRangeInfo.<init>(SemanticsProperties.kt:608)
    at androidx.compose.ui.semantics.ProgressBarRangeInfo.<init>(SemanticsProperties.kt:601)
    at androidx.compose.material3.ProgressIndicatorKt$LinearProgressIndicator$1$1.invoke(ProgressIndicator.kt:91)
    at androidx.compose.material3.ProgressIndicatorKt$LinearProgressIndicator$1$1.invoke(ProgressIndicator.kt:90)
    at androidx.compose.ui.semantics.CoreSemanticsModifierNode.applySemantics(SemanticsModifier.kt:73)
    at androidx.compose.ui.node.LayoutNode$collapsedSemantics$1.invoke(LayoutNode.kt:430)
    at androidx.compose.ui.node.LayoutNode$collapsedSemantics$1.invoke(LayoutNode.kt:421)
    at androidx.compose.runtime.snapshots.Snapshot$Companion.observe(Snapshot.kt:2303)
    at androidx.compose.runtime.snapshots.SnapshotStateObserver$ObservedScopeMap.observe(SnapshotStateObserver.kt:500)
    at androidx.compose.runtime.snapshots.SnapshotStateObserver.observeReads(SnapshotStateObserver.kt:256)
    at androidx.compose.ui.node.OwnerSnapshotObserver.observeReads$ui_release(OwnerSnapshotObserver.kt:133)
    at androidx.compose.ui.node.OwnerSnapshotObserver.observeSemanticsReads$ui_release(OwnerSnapshotObserver.kt:121)
    at androidx.compose.ui.node.LayoutNode.getCollapsedSemantics$ui_release(LayoutNode.kt:421)
    at androidx.compose.ui.semantics.SemanticsNodeKt.SemanticsNode(SemanticsNode.kt:48)
    at androidx.compose.ui.semantics.SemanticsNode.fillOneLayerOfSemanticsWrappers(SemanticsNode.kt:268)
    at androidx.compose.ui.semantics.SemanticsNode.fillOneLayerOfSemanticsWrappers(SemanticsNode.kt:270)
    at androidx.compose.ui.semantics.SemanticsNode.unmergedChildren$ui_release(SemanticsNode.kt:248)
    at androidx.compose.ui.semantics.SemanticsNode.getChildren(SemanticsNode.kt:327)
    at androidx.compose.ui.semantics.SemanticsNode.getReplacedChildren$ui_release(SemanticsNode.kt:298)
    at androidx.compose.ui.platform.AndroidComposeViewAccessibilityDelegateCompat_androidKt.getAllUncoveredSemanticsNodesToMap$findAllSemanticNodesRecursive(AndroidComposeViewAccessibilityDelegateCompat.android.kt:3679)
    at androidx.compose.ui.platform.AndroidComposeViewAccessibilityDelegateCompat_androidKt.getAllUncoveredSemanticsNodesToMap$findAllSemanticNodesRecursive(AndroidComposeViewAccessibilityDelegateCompat.android.kt:3681)
    at androidx.compose.ui.platform.AndroidComposeViewAccessibilityDelegateCompat_androidKt.getAllUncoveredSemanticsNodesToMap$findAllSemanticNodesRecursive(AndroidComposeViewAccessibilityDelegateCompat.android.kt:3681)
    at androidx.compose.ui.platform.AndroidComposeViewAccessibilityDelegateCompat_androidKt.getAllUncoveredSemanticsNodesToMap$findAllSemanticNodesRecursive(AndroidComposeViewAccessibilityDelegateCompat.android.kt:3681)
    at androidx.compose.ui.platform.AndroidComposeViewAccessibilityDelegateCompat_androidKt.getAllUncoveredSemanticsNodesToMap$findAllSemanticNodesRecursive(AndroidComposeViewAccessibilityDelegateCompat.android.kt:3681)
    at androidx.compose.ui.platform.AndroidComposeViewAccessibilityDelegateCompat_androidKt.getAllUncoveredSemanticsNodesToMap(AndroidComposeViewAccessibilityDelegateCompat.android.kt:3714)
    at androidx.compose.ui.platform.AndroidComposeViewAccessibilityDelegateCompat_androidKt.access$getAllUncoveredSemanticsNodesToMap(AndroidComposeViewAccessibilityDelegateCompat.android.kt:1)
    at androidx.compose.ui.platform.AndroidComposeViewAccessibilityDelegateCompat.getCurrentSemanticsNodes(AndroidComposeViewAccessibilityDelegateCompat.android.kt:342)
    at androidx.compose.ui.platform.AndroidComposeViewAccessibilityDelegateCompat.sendContentCaptureSemanticsStructureChangeEvents(AndroidComposeViewAccessibilityDelegateCompat.android.kt:3125)
    at androidx.compose.ui.platform.AndroidComposeViewAccessibilityDelegateCompat.checkForSemanticsChanges(AndroidComposeViewAccessibilityDelegateCompat.android.kt:2364)
    at androidx.compose.ui.platform.AndroidComposeViewAccessibilityDelegateCompat.semanticsChangeChecker$lambda$46(AndroidComposeViewAccessibilityDelegateCompat.android.kt:2189)
    at androidx.compose.ui.platform.AndroidComposeViewAccessibilityDelegateCompat.$r8$lambda$CZAjA4a8ePLF9FU4Ia6Vf_-igrw(Unknown Source:0)
    at androidx.compose.ui.platform.AndroidComposeViewAccessibilityDelegateCompat$$ExternalSyntheticLambda2.run(D8$$SyntheticClass:0)
    at android.os.Handler.handleCallback(Handler.java:959)
    at android.os.Handler.dispatchMessage(Handler.java:100)
    at android.os.Looper.loopOnce(Looper.java:232)
    at android.os.Looper.loop(Looper.java:317)
    at android.app.ActivityThread.main(ActivityThread.java:8592)
    at java.lang.reflect.Method.invoke(Native Method)
    at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:580)
    at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:878)```

Comments

di...@gmail.com <di...@gmail.com> #2Jul 10, 2024 07:21PM

There is a report about it in kotlinlang Slack: https://kotlinlang.slack.com/archives/C01D6HTPATV/p1706005056105739

Message last modified on Jul 10, 2024 07:21PM

ma...@google.com <ma...@google.com> #3Jul 10, 2024 07:22PM

Reassigned to sg...@google.com.

Thanks for the report!

sg...@google.com <sg...@google.com> #4Jul 10, 2024 07:40PM

The release notes documentation has been edited to clarify this change in behavior for line height.

To support non-standard text sizes, we encourage users to follow the Material design system and use a different type scale rather than changing the font size directly. Alternatively, users can overwrite the line height like so: style = LocalTextStyle.current.copy(lineHeight = TextUnit.Unspecified), or create a custom Typography entirely.

di...@gmail.com <di...@gmail.com> #5Jul 10, 2024 10:04PM

deleted

mo...@gmail.com <mo...@gmail.com> #6Jan 20, 2025 03:48PM

In my case, I have multiple font sizes in the same Text (using SpanStyle in AnnotatedString). There are legitimate reasons for this. For example, when combining Chinese and English (phonetic) together (for language-learning purposes).

sg...@google.com <sg...@google.com> Jan 23, 2025 12:37AM

Accepted by sg...@google.com.

ap...@google.com <ap...@google.com> #7Jan 23, 2025 11:11PM

Marked as fixed.

Project: platform/frameworks/support
Branch: androidx-main
Author: Shalom Gibly <sgibly@google.com>
Link: https://android-review.googlesource.com/3461097

Prevent a crash when Float.NaN is a progress value

Expand for full commit details

Prevent a crash when Float.NaN is a progress value 
 
- Check for a NaN value and return zero if a progress lambda is 
  producing it and passing it into a `ProgressBarRangeInfo`. The range 
  info will throw an exception if a NaN is passed in. 
- Applied the check at the progress indicators (M3 & M2), and at the 
  loading indicator. 
- The remaining implementation does not cras on NaN, but the UI usually 
  does not render anything. 
- Also, switched to use `fastCoerceIn` instead of `coerceIn`. 
 
Test: Added 
Fixes: 352364576 
Relnote: "Fixed a crash at the progress and loading indicators in case a 
Float.NaN is passed in as a progress." 
 
Change-Id: I4fa969a1d46358a6f1db8b28cb0a375a809102c2

Files:

M compose/material/material/src/commonMain/kotlin/androidx/compose/material/ProgressIndicator.kt
M compose/material3/material3/src/androidInstrumentedTest/kotlin/androidx/compose/material3/LoadingIndicatorTest.kt
M compose/material3/material3/src/androidInstrumentedTest/kotlin/androidx/compose/material3/ProgressIndicatorTest.kt
M compose/material3/material3/src/androidInstrumentedTest/kotlin/androidx/compose/material3/WavyProgressIndicatorTest.kt
M compose/material3/material3/src/commonMain/kotlin/androidx/compose/material3/LoadingIndicator.kt
M compose/material3/material3/src/commonMain/kotlin/androidx/compose/material3/ProgressIndicator.kt
M compose/material3/material3/src/commonMain/kotlin/androidx/compose/material3/WavyProgressIndicator.kt

Hash: bf90726d0c7fadd916c5c8bf38b18f6a9a5d7a6b
Date: Wed Jan 22 16:28:41 2025

ar...@gmail.com <ar...@gmail.com> #8Feb 7, 2025 03:24PM

Thank you!

pr...@google.com <pr...@google.com> #9Feb 12, 2025 06:40PM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.compose.material3:material3:1.4.0-alpha08
androidx.compose.material3:material3-android:1.4.0-alpha08
androidx.compose.material3:material3-jvmstubs:1.4.0-alpha08
androidx.compose.material3:material3-linuxx64stubs:1.4.0-alpha08