In LifecycleStartEffect, onStopOrDispose gets called twice [352364595]

Fixed

Bug

Status Update

No update yet.

Description

no...@gmail.com

created issue #1

Jul 11, 2024 04:25PM

Component used: androidx.lifecycle:lifecycle-runtime-compose

Version used: 2.7.0

Devices/Android versions reproduced on: API 34 emulator

To reproduce:

Navigate to an Android Fragment with the following:

LifecycleStartEffect {
    println("Setup")
    onStopOrDispose {
        println("Cleanup")
    }
}

Observe "Setup" is printed once.
Hit back to close the Fragment.
Observe "Cleanup" is printed twice.

Comments

il...@google.com <il...@google.com> Jul 11, 2024 11:06PM

Assigned to mg...@google.com.

mg...@google.com <mg...@google.com> Jul 12, 2024 01:57PM

Accepted by mg...@google.com.

ap...@google.com <ap...@google.com> #2Jul 15, 2024 08:41PM

Marked as fixed.

Project: platform/frameworks/support
Branch: androidx-main

commit 6dd3b3945d0c94058a1ae2deb510995296fcaaca
Author: Marcello Galhardo <mgalhardo@google.com>
Date: Mon Jul 15 16:26:08 2024

Make LifecycleEffects completion idempotent

RelNote: "`Lifecycle*Effect` completion is now idempotent."

Fixes: 352364595
Test: LifecycleEffectTest
Change-Id: I5f607934fb725f98c018b567e6e2f0052c7e8a69

M lifecycle/lifecycle-runtime-compose/src/androidInstrumentedTest/kotlin/androidx/lifecycle/compose/LifecycleEffectTest.kt
M lifecycle/lifecycle-runtime-compose/src/commonMain/kotlin/androidx/lifecycle/compose/LifecycleEffect.kt

https://android-review.googlesource.com/3173939

pr...@google.com <pr...@google.com> #3Aug 13, 2024 06:58PM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.lifecycle:lifecycle-runtime-compose:2.9.0-alpha01
androidx.lifecycle:lifecycle-runtime-compose-android:2.9.0-alpha01
androidx.lifecycle:lifecycle-runtime-compose-desktop:2.9.0-alpha01

Issue 352364595

Description

Issue summary

Comments

il...@google.com <il...@google.com> Jul 11, 2024 11:06PM

mg...@google.com <mg...@google.com> Jul 12, 2024 01:57PM

ap...@google.com <ap...@google.com> #2Jul 15, 2024 08:41PM

pr...@google.com <pr...@google.com> #3Aug 13, 2024 06:58PM

Add comment

Issue metadata