Status Update
No update yet.
Comments
ro...@google.com
Thanks for your detailed post.
However, benchmark build type is under configured: at least isProfileable is not set to true for existing build type, probably there's more.
We should set isProfileable = true by default when overriding an existing benchmark build type.
This issue is not about some specific configuration flag, but the general approach of dealing with external configuration. As a developer adopting baseline profiles, it seems extremely risky to me using a custom configuration due to how it's applied under the hood and the fact it may break default configuration.
I agree that is not great but this is a little tricky to do. For custom baseline profile build types we override all the properties. For benchmark I left it open to configure but it's mostly about these 2 properties:
isMinifyEnabled
isShrinkResources
I don't have a way to see if the user is setting them before overriding, so for this reason, I'd prefer not to. I agree with you that some other properties could be set by default to make this easier, i.e.:
isJniDebuggable = false
isDebuggable = false
isProfileable = true
The reason why I mentioned the release signing config in the beginning is because I want to use debug signing config.
In the specific of your issue, i.e. using a debug certificate can you override the benchmark and baseline profile setting? You should be able to do something like:
android {
buildTypes {
release { ... }
debug { ... }
benchmarkRelease {
...
signingConfig signingConfigs.debug
}
nonMinifiedRelease {
...
signingConfig signingConfigs.debug
}
}
}
ro...@google.com
Project: platform/frameworks/support
Branch: androidx-main
Author: Marcello Albano <
Link:
Added override for debuggable and profileable for benchmark builds in bpgp
Expand for full commit details
Added override for debuggable and profileable for benchmark builds in bpgp
Test: ./gradlew :benchmark:benchmark-baseline-profile-gradle-plugin:test
Bug: 369213505
Relnote: "isProfileable is always overridden in benchmark builds,
and isDebuggable is also now always overridden in both benchmark and
nonMinified (baseline profile capture) builds."
Change-Id: I487fa71083921682173f04fcbb477be5baf165f8
Files:
- M
benchmark/baseline-profile-gradle-plugin/src/main/kotlin/androidx/baselineprofile/gradle/apptarget/BaselineProfileAppTargetPlugin.kt - M
benchmark/baseline-profile-gradle-plugin/src/test/kotlin/androidx/baselineprofile/gradle/apptarget/BaselineProfileAppTargetPluginTest.kt
Hash: 1906bbe52ba7ccb9ca0e1c1d6de33e7c91b5c6f0
Date: Fri Oct 11 10:07:06 2024
an...@google.com
I've landed a change that will set the following properties also when the benchmark build type already exists:
isJniDebuggable = false
isDebuggable = false
isProfileable = true
As well as the following for agp 8.0:
isDebuggable = false
I'm going ahead and closing this - if you've further questions please answer here and will reopen. Thanks.
ro...@google.com
The following release(s) address this bug.It is possible this bug has only been partially addressed:
androidx.benchmark:benchmark-baseline-profile-gradle-plugin:1.4.0-alpha04
ap...@google.com
Since release signing config is used by default instead of debug is not mentioned in release notes - maybe this is a bug?
Cause the last time I found it mentioned in the release notes was in version 1.1
signingConfig.debug is used as the default signing config (
) b/153583269
So, if the switch to the release one indeed happened - maybe it's an issue?
pr...@google.com
The following release(s) address this bug.It is possible this bug has only been partially addressed:
androidx.collection:collection:1.4.3androidx.collection:collection-iosarm64:1.4.3androidx.collection:collection-iossimulatorarm64:1.4.3androidx.collection:collection-iosx64:1.4.3androidx.collection:collection-jvm:1.4.3androidx.collection:collection-linuxarm64:1.4.3androidx.collection:collection-linuxx64:1.4.3androidx.collection:collection-macosarm64:1.4.3androidx.collection:collection-macosx64:1.4.3androidx.collection:collection-tvosarm64:1.4.3androidx.collection:collection-tvossimulatorarm64:1.4.3androidx.collection:collection-tvosx64:1.4.3androidx.collection:collection-watchosarm32:1.4.3androidx.collection:collection-watchosarm64:1.4.3androidx.collection:collection-watchossimulatorarm64:1.4.3androidx.collection:collection-watchosx64:1.4.3
pr...@google.com
The following release(s) address this bug.It is possible this bug has only been partially addressed:
androidx.collection:collection:1.5.0-alpha01androidx.collection:collection-iosarm64:1.5.0-alpha01androidx.collection:collection-iossimulatorarm64:1.5.0-alpha01androidx.collection:collection-iosx64:1.5.0-alpha01androidx.collection:collection-jvm:1.5.0-alpha01androidx.collection:collection-linuxarm64:1.5.0-alpha01androidx.collection:collection-linuxx64:1.5.0-alpha01androidx.collection:collection-macosarm64:1.5.0-alpha01androidx.collection:collection-macosx64:1.5.0-alpha01androidx.collection:collection-tvosarm64:1.5.0-alpha01androidx.collection:collection-tvossimulatorarm64:1.5.0-alpha01androidx.collection:collection-tvosx64:1.5.0-alpha01androidx.collection:collection-watchosarm32:1.5.0-alpha01androidx.collection:collection-watchosarm64:1.5.0-alpha01androidx.collection:collection-watchossimulatorarm64:1.5.0-alpha01androidx.collection:collection-watchosx64:1.5.0-alpha01
Description
I'm seeing unexpected behavior after adding an item to a heavily used
MutableIntSet. In the following code snippet,24is previously added to a MutableSet. After adding another value,24 in setthen returns false.I've attached a deterministic (but not at all concise) repro case to this issue. The
...in the above snippet is actually a sequence of 2,442 specific additions and removals that cause this behavior. I'm sure there's a more concise repro case, this is just one that I immediately have at hand.This is starting in my local copy of a CL after a recent rebase onto androidx-main, so I'm guessing