Fixed
Status Update
Comments
cl...@google.com <cl...@google.com> #2
Project: platform/frameworks/support
Branch: androidx-master-dev
commit ece1e0ac47be4572d97afef494a24827c014af57
Author: Nader Jawad <njawad@google.com>
Date: Mon Aug 24 20:47:20 2020
Fixed wrong constructor parameter order for Rect
Relnote: "Fixed issue where Rect function constructor
with Offset and radius would create the Rect in the
order of left, right, top, bottom instead of
left, top, right, bottom.
Removed deprecated companion methods on Rect in
favor of function constructors.
Added tests to verify methods in Rect.kt"
Change-Id: I0846006bd0ec7f1a0effd90490c93002b42e132b
Fixes: 165822356
Test: Added tests to RectTest
M compose/ui/ui-geometry/api/current.txt
M compose/ui/ui-geometry/api/public_plus_experimental_current.txt
M compose/ui/ui-geometry/api/restricted_current.txt
M compose/ui/ui-geometry/src/commonMain/kotlin/androidx/compose/ui/geometry/Rect.kt
M compose/ui/ui-geometry/src/test/kotlin/androidx/compose/ui/geometry/RectTest.kt
https://android-review.googlesource.com/1409488
Branch: androidx-master-dev
commit ece1e0ac47be4572d97afef494a24827c014af57
Author: Nader Jawad <njawad@google.com>
Date: Mon Aug 24 20:47:20 2020
Fixed wrong constructor parameter order for Rect
Relnote: "Fixed issue where Rect function constructor
with Offset and radius would create the Rect in the
order of left, right, top, bottom instead of
left, top, right, bottom.
Removed deprecated companion methods on Rect in
favor of function constructors.
Added tests to verify methods in Rect.kt"
Change-Id: I0846006bd0ec7f1a0effd90490c93002b42e132b
Fixes: 165822356
Test: Added tests to RectTest
M compose/ui/ui-geometry/api/current.txt
M compose/ui/ui-geometry/api/public_plus_experimental_current.txt
M compose/ui/ui-geometry/api/restricted_current.txt
M compose/ui/ui-geometry/src/commonMain/kotlin/androidx/compose/ui/geometry/Rect.kt
M compose/ui/ui-geometry/src/test/kotlin/androidx/compose/ui/geometry/RectTest.kt
ap...@google.com <ap...@google.com> #3
Project: platform/frameworks/support
Branch: androidx-main
commit b02d860f9f85b59aa3d37964dde09b4f460658be
Author: Clara Fok <clarafok@google.com>
Date: Thu Jul 18 15:44:45 2024
StartDestination route to use default arg values
In aosp/2978197, we added a fix so navigation would parse and store arg values passed through the startDestination route. However, this behavior change is not ideal for existing implementations that rely on the ignored args to fallback to default values.
This CL aims to adjust the behavior so that we support both default arg and passed in arg for startDestination.
If the startDestination route is identical to the startDestination.route (all args are placeholders), we will fallback to default value for all the args. If at least one arg placeholder has been replaced with an actual value, then the arg and placeholders will be parse and handled as actual arg values.
As an example:
Given this startDestination route "example.com/{firstName}/{lastName} "
1. if startDest = "example.com/Tom/{lastName} ", bundle would contain [Tom, {lastName}]
2. if startDest = "example.com/{firstName}/{lastName} ", bundle would contain the default values
Note that in case.1, placeholder values i.e. {lastName} may not be parsed successfully. If {lastName} were of NavType.IntType, the parse would fail and this value would not be added to the bundle.
Test: ./gradlew navigation:navigation-runtime:cC
Bug: 354046047
Bug: 342016424
Relnote: "StartDestination will use default arg values if the startDestination route passed to the NavGraph is exactly equal to the startDestination.route"
Change-Id: I137626c99c62ec57db4a44448dd7cdf61209f264
M navigation/navigation-common/src/main/java/androidx/navigation/NavGraphNavigator.kt
M navigation/navigation-runtime/src/androidTest/java/androidx/navigation/NavControllerRouteTest.kt
https://android-review.googlesource.com/3183231
Branch: androidx-main
commit b02d860f9f85b59aa3d37964dde09b4f460658be
Author: Clara Fok <clarafok@google.com>
Date: Thu Jul 18 15:44:45 2024
StartDestination route to use default arg values
In aosp/2978197, we added a fix so navigation would parse and store arg values passed through the startDestination route. However, this behavior change is not ideal for existing implementations that rely on the ignored args to fallback to default values.
This CL aims to adjust the behavior so that we support both default arg and passed in arg for startDestination.
If the startDestination route is identical to the startDestination.route (all args are placeholders), we will fallback to default value for all the args. If at least one arg placeholder has been replaced with an actual value, then the arg and placeholders will be parse and handled as actual arg values.
As an example:
Given this startDestination route "
1. if startDest = "
2. if startDest = "
Note that in case.1, placeholder values i.e. {lastName} may not be parsed successfully. If {lastName} were of NavType.IntType, the parse would fail and this value would not be added to the bundle.
Test: ./gradlew navigation:navigation-runtime:cC
Bug: 354046047
Bug: 342016424
Relnote: "StartDestination will use default arg values if the startDestination route passed to the NavGraph is exactly equal to the startDestination.route"
Change-Id: I137626c99c62ec57db4a44448dd7cdf61209f264
M navigation/navigation-common/src/main/java/androidx/navigation/NavGraphNavigator.kt
M navigation/navigation-runtime/src/androidTest/java/androidx/navigation/NavControllerRouteTest.kt
pr...@google.com <pr...@google.com> #4
The following release(s) address this bug.It is possible this bug has only been partially addressed:
androidx.navigation:navigation-common:2.8.0-beta07
androidx.navigation:navigation-runtime:2.8.0-beta07
Description
We should add a user path that will allow them to use default values.