HorizontalPager accessibility focus issues [354109776]

Fixed

Bug

Status Update

No update yet.

Description

np...@mirego.com

created issue #1

Jul 19, 2024 02:11PM

Versioning and Device Details

Jetpack Compose version: 1.7.0-beta05
Android Studio Build: Android Studio Koala | 2024.1.1 RC 2
Kotlin version: 1.9.0

Device Model: Pixel 8
Android Version: 14
TalkBack Version: 14.2

Issue Description

The accessibility focus does not navigate between pages, in our case the pager is nested in a scrollable column but I could reproduce it with this minimal reproduction case:

Scaffold(modifier = Modifier.fillMaxSize()) { innerPadding ->
	HorizontalPager(
		modifier = Modifier
			.padding(innerPadding)
			.fillMaxWidth(),
		state = rememberPagerState {
			10
		}) {
		Text(
			text = "Page $it",
			modifier = Modifier
				.fillMaxWidth()
				.background(Color.Gray)
				.padding(16.dp)
		)
	}
}

Expected behavior:

The accessibility focus should focus on the next / previous page when swiping left and right with accessibility gestures. Additionally it should say the number of items.

Actual behavior:

The accessibility focus does not focus on next our previous page, it also does not return the number of items.

Steps to Reproduce or Code Sample to Reproduce:

Run PagerAccessibility-focus project attached to bug report.
Run sample with talkback and try to focus to next page.
Notice it won't work with 1.7.0-beta05 but it does with 1.6.8

You can swap out these lines in the libs.version.toml to notice the changed behavior from the previous compose stable release.

#androidx-compose-bom = { group = "dev.chrisbanes.compose", name = "compose-bom", version = "2024.07.00-alpha01" }
androidx-compose-bom = { group = "androidx.compose", name = "compose-bom", version = "2024.06.00" }

PagerAccessibility-focus.zip

395 KB

Download

Comments

mo...@google.com <mo...@google.com> #2Jul 19, 2024 05:20PM

Reassigned to le...@google.com.

Project: platform/frameworks/support
Branch: androidx-master-dev

commit c60f33e229e31ab328ef6b59dab63b264954831c
Author: Alexandre Elias <aelias@google.com>
Date: Fri Jul 10 16:23:09 2020

Semantics no-op cleanups

Partly in response to lmr's broad code review, I did a pass of
superficial API/implementation cleanup. The main changes are:

- I changed each Boolean SemanticsProperty where false is equivalent to
not being present to take "Unit" instead. This is conceptually
clearer: it avoids questions like "can I cancel out a semantics from a
merged child by setting it to false?" Because "property = Unit" looks
weird, I also changed the style of these to "property()".

- I moved the Semantics id generator closer to where it's used, in
SemanticsModifierCore. I made it internal and an AtomicInt.
(Note that integer ids are heavily used in the Android
AccessibilityNodeInfo APIs so I can't simply remove them entirely.)

- I deleted dead code. Some examples include SemanticsHintOverrides,
a public API not connected to anything, and SemanticsPropertyKey
merge() open method which is never called. (In both cases I have
a different plan in mind for accessibility.)

Fixes: 145951226
Fixes: 145955412
Test: existing tests
Relnote: "Single-value semantics properties now use a calling style.
For example, 'semantics { hidden = true }' is now written as:
'semantics { hidden() }'."

Change-Id: Ic1afd12ea22c926babc9662f1804d80b33aa0cfc

M ui/integration-tests/benchmark/src/androidTest/java/androidx/ui/benchmark/test/LayoutNodeModifierBenchmark.kt
M ui/ui-core/api/0.1.0-dev15.txt
M ui/ui-core/api/current.txt
M ui/ui-core/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-core/api/public_plus_experimental_current.txt
M ui/ui-core/api/restricted_0.1.0-dev15.txt
M ui/ui-core/api/restricted_current.txt
M ui/ui-core/src/androidAndroidTest/kotlin/androidx/ui/graphics/vector/VectorTest.kt
M ui/ui-core/src/androidAndroidTest/kotlin/androidx/ui/semantics/SemanticsTests.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidActuals.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidComposeView.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidComposeViewAccessibilityDelegateCompat.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidPopup.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/Expect.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsConfiguration.kt
D ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsHintOverrides.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsModifier.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsNode.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsOwner.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsWrapper.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/semantics/SemanticsProperties.kt
M ui/ui-foundation/api/0.1.0-dev15.txt
M ui/ui-foundation/api/current.txt
M ui/ui-foundation/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-foundation/api/public_plus_experimental_current.txt
M ui/ui-foundation/api/restricted_0.1.0-dev15.txt
M ui/ui-foundation/api/restricted_current.txt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Clickable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Dialog.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Scroller.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/selection/Selectable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/selection/Toggleable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/semantics/FoundationSemanticsProperties.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ButtonTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/CardTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/CheckboxScreenshotTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/RadioButtonScreenshotTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ScaffoldTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/SnackbarTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/SurfaceTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ripple/RippleIndicationTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/textfield/TextFieldScreenshotTest.kt
M ui/ui-material/src/main/java/androidx/ui/material/AppBar.kt
M ui/ui-material/src/main/java/androidx/ui/material/TextFieldImpl.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/AssertsTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/CallSemanticsActionTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/ErrorMessagesTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/FindersTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/PrintToStringTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/ScrollToTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/TextActionsTest.kt
M ui/ui-test/src/main/java/androidx/ui/test/Actions.kt
M ui/ui-test/src/main/java/androidx/ui/test/Filters.kt
M ui/ui-text/api/0.1.0-dev15.txt
M ui/ui-text/api/current.txt
M ui/ui-text/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-text/api/public_plus_experimental_current.txt
M ui/ui-text/api/restricted_0.1.0-dev15.txt
M ui/ui-text/api/restricted_current.txt
M ui/ui-text/src/commonMain/kotlin/androidx/ui/text/CoreTextField.kt
M ui/ui-text/src/commonMain/kotlin/androidx/ui/text/TextSemanticsProperties.kt

https://android-review.googlesource.com/1360099

le...@google.com <le...@google.com> #3Jul 24, 2024 01:54PM

This is an issue with how Talkback handles Pagers. Essentially you can use swipe-left-then-right to switch Pages for now, and we're investigating this on the Talkback side.

mo...@johnlewis.co.uk <mo...@johnlewis.co.uk> #4Sep 9, 2024 07:50PM

any updates regarding this issue ?

le...@google.com <le...@google.com> #5Sep 10, 2024 07:34AM

No updates yet, the oficial recommendation from Talkback team is that Pager navigation is triggered using swipe-left-then-right gestures. We're working with them to find a better solution since some people expect that simple swipes should also trigger navigation in Pagers.

ap...@google.com <ap...@google.com> #6Sep 20, 2024 06:51AM

Marked as fixed.

Project: platform/frameworks/support
Branch: androidx-main

commit 60e2f72189dec2fc080c2a8f545ea5a1061cb818
Author: Levi Albuquerque <levima@google.com>
Date: Wed Sep 18 18:24:39 2024

Introduce Carousel semantics Role

Introduce a new semantics Role that can be used to indicate that a Pager should behave like a Carousel and not a regular full-screen Pager.

Relnote: Introduced a new Semantics Role called Carousel to emulate the list behavior in Pagers for a11y services.

Fixes: 354109776
Fixes: 239672673
Fixes: 350097064
Fixes: 350647130
Fixes: 359498832

Test: Added new tests for behavior.
Change-Id: Id354b132da03348aaa68da0dd8459d4528438018

M compose/foundation/foundation/integration-tests/foundation-demos/src/main/java/androidx/compose/foundation/demos/pager/PagerCarrouselDemos.kt
M compose/ui/ui/api/current.txt
M compose/ui/ui/api/restricted_current.txt
M compose/ui/ui/src/androidInstrumentedTest/kotlin/androidx/compose/ui/AndroidAccessibilityTest.kt
M compose/ui/ui/src/androidMain/kotlin/androidx/compose/ui/platform/AndroidComposeViewAccessibilityDelegateCompat.android.kt
M compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/semantics/SemanticsProperties.kt

https://android-review.googlesource.com/3272492

pr...@google.com <pr...@google.com> #7Oct 2, 2024 05:37PM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.compose.foundation:foundation:1.8.0-alpha03
androidx.compose.foundation:foundation-android:1.8.0-alpha03
androidx.compose.foundation:foundation-jvmstubs:1.8.0-alpha03
androidx.compose.foundation:foundation-linuxx64stubs:1.8.0-alpha03
androidx.compose.ui:ui:1.8.0-alpha03
androidx.compose.ui:ui-android:1.8.0-alpha03
androidx.compose.ui:ui-jvmstubs:1.8.0-alpha03
androidx.compose.ui:ui-linuxx64stubs:1.8.0-alpha03