IssueTracker

Introduce Compose stack traces based on source information 
 
Appends a trace of @Composable functions retrieved from a slot table traversal as a suppressed exception on composition crash (coverage of other phases in the following commits). 
 
The trace frames are based on the source information which has an associated performance cost. Enabling this feature might regress performance of the app. 
 
Note that Compose also ships with a minifier config hat removes source information from the release builds. Enabling this feature in minified builds will have no effect. 
 
Test: ComposeErrorTraceTests 
Bug: 354163858 
Relnote: """ 
Introduce diagnostic Compose stack traces based on source information stored in composition. 
""" 
 
Change-Id: I3db9fb976f61c768e2d1cf11d69019e4d0a08330

Files:

• M compose/runtime/runtime-test-utils/src/commonMain/kotlin/androidx/compose/runtime/mock/CompositionTest.kt
• M compose/runtime/runtime/api/current.txt
• M compose/runtime/runtime/api/restricted_current.txt
• M compose/runtime/runtime/src/commonMain/kotlin/androidx/compose/runtime/Composer.kt
• M compose/runtime/runtime/src/commonMain/kotlin/androidx/compose/runtime/Composition.kt
• M compose/runtime/runtime/src/commonMain/kotlin/androidx/compose/runtime/CompositionContext.kt
• M compose/runtime/runtime/src/commonMain/kotlin/androidx/compose/runtime/Recomposer.kt
• M compose/runtime/runtime/src/commonMain/kotlin/androidx/compose/runtime/SlotTable.kt
• A compose/runtime/runtime/src/commonMain/kotlin/androidx/compose/runtime/tooling/ComposeTrace.kt
• A compose/runtime/runtime/src/commonMain/kotlin/androidx/compose/runtime/tooling/СomposeTraceBuilder.kt
• A compose/runtime/runtime/src/jvmMain/kotlin/androidx/compose/runtime/tooling/DiagnosticComposeException.jvm.kt
• A compose/runtime/runtime/src/linuxx64StubsMain/kotlin/androidx/compose/runtime/tooling/DiagnosticComposeException.linuxx64Stubs.kt
• A compose/runtime/runtime/src/nonEmulatorJvmTest/kotlin/androidx/compose/runtime/tooling/ErrorTraceComposables.kt
• A compose/runtime/runtime/src/nonEmulatorJvmTest/kotlin/androidx/compose/runtime/tooling/ErrorTraceTests.kt

Hash: f442c3e9ffc8598e743b8f540f0f4464942ea173
Date:  Mon Nov 18 19:37:30 2024

Support Compose stack traces in LayoutNode phases 
 
This change adds a composition local that exposes access to the slot table lookup through `CompositionErrorContext`. The layout node now rethrows exceptions in measure / layout / draw with a Compose stack trace attached. 
 
Test: UiErrorTraceTests 
Bug: 354163858 
Relnote: "Expose a composition local that allows to attach a compose stack trace based on a compose node location in composition." 
Change-Id: Ie0bdaffb43a46328057c31e7fc9db51a80789b5e

Files:

• M compose/runtime/runtime/api/current.txt
• M compose/runtime/runtime/api/restricted_current.txt
• M compose/runtime/runtime/src/commonMain/kotlin/androidx/compose/runtime/Composer.kt
• M compose/runtime/runtime/src/commonMain/kotlin/androidx/compose/runtime/internal/RememberEventDispatcher.kt
• M compose/runtime/runtime/src/commonMain/kotlin/androidx/compose/runtime/tooling/CompositionErrorContext.kt
• M compose/runtime/runtime/src/commonMain/kotlin/androidx/compose/runtime/tooling/CompositionTrace.kt
• M compose/ui/ui/api/current.txt
• M compose/ui/ui/api/restricted_current.txt
• A compose/ui/ui/src/androidInstrumentedTest/kotlin/androidx/compose/ui/tooling/UiErrorTraceTests.kt
• M compose/ui/ui/src/androidMain/kotlin/androidx/compose/ui/platform/AndroidComposeView.android.kt
• M compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/node/LayoutNode.kt
• M compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/node/LookaheadPassDelegate.kt
• M compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/node/MeasureAndLayoutDelegate.kt
• M compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/node/MeasurePassDelegate.kt
• M compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/node/RootForTest.kt

Hash: 7b1ea920699ea415434402b37c108421e3550776
Date:  Wed Jan 29 16:22:59 2025

Implement compose stack traces for applyChanges() 
 
Handles crashes in the apply phase by connecting crash execution place to a location in composition. 
 
For changelist: 
Updates Operation interface to have an overload that accept stack trace context. The context connects operation invocation place (usually marked by the slot writer position) with the parent context to provide a full trace to the root. 
For most operations it is enough to just use current location of the writer, which is handled by the default implementation. Some operations (e.g. node insertion fixups) require additional context stitching, so they are implemented separately. 
 
For remember observer events: 
Looks up the location of the node / observer holder in the slot table. This implementation does not provide context for `onForgotten` callbacks (or `onDetach`/`onRelease` of the node) at the moment. 
 
Test: ErrorTraceTests 
Bug: 354163858 
Change-Id: I6ccb66004099d895ddffecacb85f582c9f7c9cc8

Files:

• M compose/runtime/runtime-test-utils/src/commonMain/kotlin/androidx/compose/runtime/mock/CompositionTest.kt
• M compose/runtime/runtime-test-utils/src/commonMain/kotlin/androidx/compose/runtime/mock/View.kt
• M compose/runtime/runtime/src/commonMain/kotlin/androidx/compose/runtime/Composer.kt
• M compose/runtime/runtime/src/commonMain/kotlin/androidx/compose/runtime/Composition.kt
• M compose/runtime/runtime/src/commonMain/kotlin/androidx/compose/runtime/PausableComposition.kt
• M compose/runtime/runtime/src/commonMain/kotlin/androidx/compose/runtime/changelist/ChangeList.kt
• M compose/runtime/runtime/src/commonMain/kotlin/androidx/compose/runtime/changelist/FixupList.kt
• M compose/runtime/runtime/src/commonMain/kotlin/androidx/compose/runtime/changelist/Operation.kt
• M compose/runtime/runtime/src/commonMain/kotlin/androidx/compose/runtime/changelist/OperationArgContainer.kt
• M compose/runtime/runtime/src/commonMain/kotlin/androidx/compose/runtime/changelist/Operations.kt
• M compose/runtime/runtime/src/commonMain/kotlin/androidx/compose/runtime/internal/RememberEventDispatcher.kt
• A compose/runtime/runtime/src/commonMain/kotlin/androidx/compose/runtime/tooling/CompositionErrorContext.kt
• M compose/runtime/runtime/src/commonMain/kotlin/androidx/compose/runtime/tooling/CompositionTrace.kt
• M compose/runtime/runtime/src/commonMain/kotlin/androidx/compose/runtime/tooling/СompositionTraceBuilder.kt
• M compose/runtime/runtime/src/nonEmulatorJvmTest/kotlin/androidx/compose/runtime/tooling/ErrorTraceComposables.kt
• M compose/runtime/runtime/src/nonEmulatorJvmTest/kotlin/androidx/compose/runtime/tooling/ErrorTraceTests.kt

Hash: f24d76510c1b22ee54a36e74dddc80b35a40a6f7
Date:  Wed Nov 20 00:29:43 2024

Support composition traces in effects 
 
Uses `CompositionErorContext` primitive to look up the effect instance in the slot table from scopes that are connected to composition. The exception is intercepted with `CoroutineExceptionHandler`, so only uncaught exceptions contain the trace. 
 
Test: UiErrorTests 
Bug: 354163858 
Relnote: "Added support for compose stack traces in LaunchedEffect and rememberCoroutineScope" 
Change-Id: I705c0898bc527741d87cc9ff838016b87b14fb54

Files:

• M compose/runtime/runtime-test-utils/src/commonMain/kotlin/androidx/compose/runtime/mock/CompositionTest.kt
• M compose/runtime/runtime/src/commonMain/kotlin/androidx/compose/runtime/Composer.kt
• M compose/runtime/runtime/src/commonMain/kotlin/androidx/compose/runtime/Effects.kt
• M compose/runtime/runtime/src/commonMain/kotlin/androidx/compose/runtime/tooling/CompositionErrorContext.kt
• M compose/runtime/runtime/src/nonEmulatorJvmTest/kotlin/androidx/compose/runtime/tooling/ErrorTraceTests.kt
• M compose/ui/ui-test/src/androidMain/kotlin/androidx/compose/ui/test/ComposeUiTest.android.kt
• M compose/ui/ui-test/src/commonMain/kotlin/androidx/compose/ui/test/UncaughtExceptionHandler.kt
• M compose/ui/ui/src/androidInstrumentedTest/kotlin/androidx/compose/ui/tooling/UiErrorTraceTests.kt

Hash: 064b5505376311828509df9f3a822c7769fe466d
Date:  Wed Jan 29 10:43:20 2025