Benchmarks file many bugs for changes unrelated to the benchmark [354264743]

Assigned

Bug

Status Update

No update yet.

Description

mo...@google.com

created issue #1

Jul 19, 2024 09:47PM

I am currently the triage cop for toolkit and see many bugs created for false positives on benchmarks (both high and low). The symptom is that an unrelated change affects a benchmark. They usually bounce between two different values, but not in a noisy way. The metric will show high for a while, then low for a while, then high again. A bug is filed for both the high and low changes.

Comments

ap...@google.com <ap...@google.com> #2Jul 19, 2024 09:52PM

I realize this should be filed as a feature request

mo...@google.com <mo...@google.com> #3Jul 22, 2024 04:16PM

Project: platform/frameworks/support
Branch: androidx-main

commit ed2450ec5d2cdf62f1ebf13a29fe04295ad65e44
Author: Anastasia Soboleva <soboleva@google.com>
Date: Thu Dec 30 19:22:41 2021

Add material decoration box for TextField and OutlinedTextField

It allows additionally to what is customisable in text fields already to customise paddings (incl. for dense text field support), border or indicator line.

In the future we could add prefix/suffix, helper message slots.

Fixes: 203764564
Fixes: 191543915
Fixes: 189971673
Fixes: 183136600
Fixes: 179882597
Fixes: 168003617
Test: TextFieldTest and OutlinedTextFieldTest
Test: new tests TextFieldDecorationBoxTest
Relnote: "Added TextFieldDecorationBox and
OutlinedTextFieldDecorationBox. Using them together with BasicTextField
will help you build custom text field based on Material Design text
fields but with more options for customisation."
Relnote: "Provided a way to adjust horizontal and vertical paddings in text fields."

Change-Id: I8c9f168a687e337670c266e1eb3e985da6aebdc3

M compose/material/material/samples/src/main/java/androidx/compose/material/samples/TextFieldSamples.kt
M compose/material/material/api/current.txt
M compose/material/material/api/restricted_current.txt
M compose/material/material/src/androidAndroidTest/kotlin/androidx/compose/material/textfield/TextFieldTest.kt
A compose/material/material/src/androidAndroidTest/kotlin/androidx/compose/material/textfield/TextFieldDecorationBoxTest.kt
M compose/material/material/api/public_plus_experimental_current.txt
A compose/material/material/integration-tests/material-demos/src/main/java/androidx/compose/material/demos/TextFieldDecorationBoxDemos.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/TextFieldDefaults.kt
M compose/material/material/integration-tests/material-demos/src/main/java/androidx/compose/material/demos/MaterialDemos.kt
M compose/material/material/integration-tests/material-demos/src/main/java/androidx/compose/material/demos/MaterialTextField.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/TextField.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/OutlinedTextField.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/TextFieldImpl.kt

https://android-review.googlesource.com/1934969

ap...@google.com <ap...@google.com> #4Jul 31, 2024 08:57PM

Could be also great if the indicator lines can be a Brush not just a Color

cc...@google.com <cc...@google.com> #5Aug 16, 2024 08:34PM

Note this had to be reverted again here: https://android-review.git.corp.google.com/c/platform/frameworks/support/+/3205832 due to failures to load listeners set by instrumentation arg.

ap...@google.com <ap...@google.com> #6Aug 28, 2024 08:28PM

Project: platform/frameworks/support
Branch: androidx-main

commit ef02fd556a27c5ff582c4363bf39ec23faf34541
Author: Chris Craik <ccraik@google.com>
Date: Mon Aug 26 16:06:43 2024

Add JUnit runlisteners to benchmark proguard

Bug: 354264743
Test: ./gradlew compose:foundation:foundation-benchmark:cC -P android.testInstrumentationRunnerArguments.class=androidx.compose.foundation.benchmark.NestedScrollerBenchmark -P android.testInstrumentationRunnerArguments.listener=androidx.benchmark.junit4.SideEffectRunListener # with R8 enabled in the module

Relnote: "Keep subclasses of org.junit.runner.notification.RunListener
in benchmark library proguard"

Previously we covered InstrumentationRunListeners (such as we use for
reporting json files) in the proguard file, but were missing the JUnit ones.

Change-Id: Ic8ed5d229c53d4f7779429e003331c251a5f1b39

M benchmark/benchmark-junit4/proguard-rules.pro

https://android-review.googlesource.com/3241410

Issue 354264743