Assigned
Status Update
Comments
ap...@google.com <ap...@google.com> #2
Project: platform/frameworks/support
Branch: androidx-main
commit 87be311dd54147b46da4c5e8faf6af1d6384b61c
Author: George Mount <mount@google.com>
Date: Fri Jul 19 11:31:56 2024
Experiment: Enable R8 in foundation-library and compose-runtime benchmarks
Bug: 354264743
Benchmarks appear to bounce around when something in the library
changes, regardless of whether it should affect the benchmark.
For example, adding a new collection could cause a benchmark
to increase or decrease, even though the collection hasn't
been used anywhere.
This CL set minifyEnabled to true for compose foundation-library
and compose runtime benchmarks, two libraries that have seen
recent performance variability. This should be considered an
experiment that may be removed in the future or expanded to
other libraries, depending on whether this helps performance
alerts.
Test: ran perf tests locally
Change-Id: I5f0b06631b01e9491bffc5c005b15e7153aa8787
M compose/foundation/foundation-layout/benchmark/build.gradle
M compose/runtime/runtime/compose-runtime-benchmark/build.gradle
https://android-review.googlesource.com/3185620
Branch: androidx-main
commit 87be311dd54147b46da4c5e8faf6af1d6384b61c
Author: George Mount <mount@google.com>
Date: Fri Jul 19 11:31:56 2024
Experiment: Enable R8 in foundation-library and compose-runtime benchmarks
Bug: 354264743
Benchmarks appear to bounce around when something in the library
changes, regardless of whether it should affect the benchmark.
For example, adding a new collection could cause a benchmark
to increase or decrease, even though the collection hasn't
been used anywhere.
This CL set minifyEnabled to true for compose foundation-library
and compose runtime benchmarks, two libraries that have seen
recent performance variability. This should be considered an
experiment that may be removed in the future or expanded to
other libraries, depending on whether this helps performance
alerts.
Test: ran perf tests locally
Change-Id: I5f0b06631b01e9491bffc5c005b15e7153aa8787
M compose/foundation/foundation-layout/benchmark/build.gradle
M compose/runtime/runtime/compose-runtime-benchmark/build.gradle
mo...@google.com <mo...@google.com> #3
This CL doesn't seem to have fixed all the problems. I see this bug:
ap...@google.com <ap...@google.com> #4
Project: platform/frameworks/support
Branch: androidx-main
commit b3cff5328dfc448de4a05b4722806ea8b7ce33b9
Author: Chris Craik <ccraik@google.com>
Date: Tue Jul 30 15:48:16 2024
Reland Experiment: Enable R8 in foundation-library and compose-runtime benchmarks
Bug: 354264743
Test: DbMonsterBenchmark#dbMonster_count10_mutate10 (D8 = 1,677,855, R8 = 1,266,340)
Benchmarks appear to bounce around when something in the library
changes, regardless of whether it should affect the benchmark.
For example, adding a new collection could cause a benchmark
to increase or decrease, even though the collection hasn't
been used anywhere.
This CL set minifyEnabled to true for compose foundation-library
and compose runtime benchmarks, two libraries that have seen
recent performance variability. This should be considered an
experiment that may be removed in the future or expanded to
other libraries, depending on whether this helps performance
alerts.
(Reland with correct androidTest property)
Test: ran perf tests locally
Change-Id: I0740dd5fd83dd87e7bad95bbfaf2950593a1ec3a
M compose/foundation/foundation-layout/benchmark/build.gradle
M compose/runtime/runtime/compose-runtime-benchmark/build.gradle
https://android-review.googlesource.com/3199776
Branch: androidx-main
commit b3cff5328dfc448de4a05b4722806ea8b7ce33b9
Author: Chris Craik <ccraik@google.com>
Date: Tue Jul 30 15:48:16 2024
Reland Experiment: Enable R8 in foundation-library and compose-runtime benchmarks
Bug: 354264743
Test: DbMonsterBenchmark#dbMonster_count10_mutate10 (D8 = 1,677,855, R8 = 1,266,340)
Benchmarks appear to bounce around when something in the library
changes, regardless of whether it should affect the benchmark.
For example, adding a new collection could cause a benchmark
to increase or decrease, even though the collection hasn't
been used anywhere.
This CL set minifyEnabled to true for compose foundation-library
and compose runtime benchmarks, two libraries that have seen
recent performance variability. This should be considered an
experiment that may be removed in the future or expanded to
other libraries, depending on whether this helps performance
alerts.
(Reland with correct androidTest property)
Test: ran perf tests locally
Change-Id: I0740dd5fd83dd87e7bad95bbfaf2950593a1ec3a
M compose/foundation/foundation-layout/benchmark/build.gradle
M compose/runtime/runtime/compose-runtime-benchmark/build.gradle
cc...@google.com <cc...@google.com> #5
ap...@google.com <ap...@google.com> #6
Project: platform/frameworks/support
Branch: androidx-main
commit ef02fd556a27c5ff582c4363bf39ec23faf34541
Author: Chris Craik <ccraik@google.com>
Date: Mon Aug 26 16:06:43 2024
Add JUnit runlisteners to benchmark proguard
Bug: 354264743
Test: ./gradlew compose:foundation:foundation-benchmark:cC -P android.testInstrumentationRunnerArguments.class=androidx.compose.foundation.benchmark.NestedScrollerBenchmark -P android.testInstrumentationRunnerArguments.listener=androidx.benchmark.junit4.SideEffectRunListener # with R8 enabled in the module
Relnote: "Keep subclasses of org.junit.runner.notification.RunListener
in benchmark library proguard"
Previously we covered InstrumentationRunListeners (such as we use for
reporting json files) in the proguard file, but were missing the JUnit ones.
Change-Id: Ic8ed5d229c53d4f7779429e003331c251a5f1b39
M benchmark/benchmark-junit4/proguard-rules.pro
https://android-review.googlesource.com/3241410
Branch: androidx-main
commit ef02fd556a27c5ff582c4363bf39ec23faf34541
Author: Chris Craik <ccraik@google.com>
Date: Mon Aug 26 16:06:43 2024
Add JUnit runlisteners to benchmark proguard
Bug: 354264743
Test: ./gradlew compose:foundation:foundation-benchmark:cC -P android.testInstrumentationRunnerArguments.class=androidx.compose.foundation.benchmark.NestedScrollerBenchmark -P android.testInstrumentationRunnerArguments.listener=androidx.benchmark.junit4.SideEffectRunListener # with R8 enabled in the module
Relnote: "Keep subclasses of org.junit.runner.notification.RunListener
in benchmark library proguard"
Previously we covered InstrumentationRunListeners (such as we use for
reporting json files) in the proguard file, but were missing the JUnit ones.
Change-Id: Ic8ed5d229c53d4f7779429e003331c251a5f1b39
M benchmark/benchmark-junit4/proguard-rules.pro
Description