Night mode freezes when upgrading app to Gradle 8.5.1 [354824993]

Fixed

Bug

Status Update

No update yet.

Description

sh...@gmail.com

created issue #1

Jul 23, 2024 09:18AM

Hi Team CameraX,

Gradle version 8.5.1 seems to currently causing a crash (possibly due to minification) for CameraX extension usage. One of our users reported that switching to night mode caused the preview to freeze and switching to another mode (which rebinds a new camera instance) caused the preview to unfreeze.

Quoting their report on this issue,

After updating to v69, switching to Night mode (on a Pixel 6, but likely not specific to just this model), the preview frame freezes. Switching to another mode unfreezes it.

If you press the button to take a photo regardless, nothing happens, but when you try to switch to another mode after that, you get an error, with the following log:

osVersion: google/oriole/oriole:14/AP2A.240705.004/2024071600:user/release-keys package: app.grapheneos.camera:69

osVersion: google/oriole/oriole:14/AP2A.240705.004/2024071600:user/release-keys
package: app.grapheneos.camera:69


x.S: Camera is closed.
	at y.r.a(Unknown Source:9)
	at x.Q.v(Unknown Source:12)
	at q.A.o(Unknown Source:55)
	at E.h.s(Unknown Source:16)
	at androidx.camera.lifecycle.LifecycleCamera.onStop(Unknown Source:9)
	at androidx.camera.lifecycle.LifecycleCamera.k(Unknown Source:13)
	at androidx.camera.lifecycle.b.h(Unknown Source:48)
	at androidx.camera.lifecycle.b.g(Unknown Source:8)
	at androidx.camera.lifecycle.d.d(Unknown Source:63)
	at d1.q.t(Unknown Source:171)
	at d1.q.u(Unknown Source:257)
	at app.grapheneos.camera.ui.activities.MainActivity.F(Unknown Source:43)
	at d1.f.onTouch(Unknown Source:206)
	at android.view.View.performOnTouchCallback(View.java:16256)
	at android.view.View.dispatchTouchEvent(View.java:16223)
	at android.view.ViewGroup.dispatchTransformedTouchEvent(ViewGroup.java:3119)
	at android.view.ViewGroup.dispatchTouchEvent(ViewGroup.java:2792)
	at android.view.ViewGroup.dispatchTransformedTouchEvent(ViewGroup.java:3125)
	at android.view.ViewGroup.dispatchTouchEvent(ViewGroup.java:2806)
	at android.view.ViewGroup.dispatchTransformedTouchEvent(ViewGroup.java:3125)
	at android.view.ViewGroup.dispatchTouchEvent(ViewGroup.java:2806)
	at android.view.ViewGroup.dispatchTransformedTouchEvent(ViewGroup.java:3125)
	at android.view.ViewGroup.dispatchTouchEvent(ViewGroup.java:2806)
	at android.view.ViewGroup.dispatchTransformedTouchEvent(ViewGroup.java:3125)
	at android.view.ViewGroup.dispatchTouchEvent(ViewGroup.java:2806)
	at android.view.ViewGroup.dispatchTransformedTouchEvent(ViewGroup.java:3125)
	at android.view.ViewGroup.dispatchTouchEvent(ViewGroup.java:2806)
	at android.view.ViewGroup.dispatchTransformedTouchEvent(ViewGroup.java:3125)
	at android.view.ViewGroup.dispatchTouchEvent(ViewGroup.java:2806)
	at android.view.ViewGroup.dispatchTransformedTouchEvent(ViewGroup.java:3125)
	at android.view.ViewGroup.dispatchTouchEvent(ViewGroup.java:2806)
	at android.view.ViewGroup.dispatchTransformedTouchEvent(ViewGroup.java:3125)
	at android.view.ViewGroup.dispatchTouchEvent(ViewGroup.java:2806)
	at android.view.ViewGroup.dispatchTransformedTouchEvent(ViewGroup.java:3125)
	at android.view.ViewGroup.dispatchTouchEvent(ViewGroup.java:2806)
	at com.android.internal.policy.DecorView.superDispatchTouchEvent(DecorView.java:496)
	at com.android.internal.policy.PhoneWindow.superDispatchTouchEvent(PhoneWindow.java:1952)
	at android.app.Activity.dispatchTouchEvent(Activity.java:4518)
	at e.t.dispatchTouchEvent(Unknown Source:2)
	at com.android.internal.policy.DecorView.dispatchTouchEvent(DecorView.java:454)
	at android.view.View.dispatchPointerEvent(View.java:16548)
	at android.view.ViewRootImpl$ViewPostImeInputStage.processPointerEvent(ViewRootImpl.java:7559)
	at android.view.ViewRootImpl$ViewPostImeInputStage.onProcess(ViewRootImpl.java:7326)
	at android.view.ViewRootImpl$InputStage.deliver(ViewRootImpl.java:6723)
	at android.view.ViewRootImpl$InputStage.onDeliverToNext(ViewRootImpl.java:6780)
	at android.view.ViewRootImpl$InputStage.forward(ViewRootImpl.java:6746)
	at android.view.ViewRootImpl$AsyncInputStage.forward(ViewRootImpl.java:6912)
	at android.view.ViewRootImpl$InputStage.apply(ViewRootImpl.java:6754)
	at android.view.ViewRootImpl$AsyncInputStage.apply(ViewRootImpl.java:6969)
	at android.view.ViewRootImpl$InputStage.deliver(ViewRootImpl.java:6727)
	at android.view.ViewRootImpl$InputStage.onDeliverToNext(ViewRootImpl.java:6780)
	at android.view.ViewRootImpl$InputStage.forward(ViewRootImpl.java:6746)
	at android.view.ViewRootImpl$InputStage.apply(ViewRootImpl.java:6754)
	at android.view.ViewRootImpl$InputStage.deliver(ViewRootImpl.java:6727)
	at android.view.ViewRootImpl.deliverInputEvent(ViewRootImpl.java:9827)
	at android.view.ViewRootImpl.doProcessInputEvents(ViewRootImpl.java:9778)
	at android.view.ViewRootImpl.enqueueInputEvent(ViewRootImpl.java:9747)
	at android.view.ViewRootImpl$WindowInputEventReceiver.onInputEvent(ViewRootImpl.java:9969)
	at android.view.InputEventReceiver.dispatchInputEvent(InputEventReceiver.java:295)
	at android.os.MessageQueue.nativePollOnce(Native Method)
	at android.os.MessageQueue.next(MessageQueue.java:349)
	at android.os.Looper.loopOnce(Looper.java:189)
	at android.os.Looper.loop(Looper.java:317)
	at android.app.ActivityThread.main(ActivityThread.java:8623)
	at java.lang.reflect.Method.invoke(Native Method)
	at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:580)
	at com.android.internal.os.ExecInit.main(ExecInit.java:50)
	at com.android.internal.os.RuntimeInit.nativeFinishInit(Native Method)
	at com.android.internal.os.RuntimeInit.main(RuntimeInit.java:369)

(Source: https://github.com/GrapheneOS/Camera/issues/449)

Downgrading to Gradle 8.5.0 in our app's recent release caused the issue to no longer persist. Could you'll please help us fix this issue?

The CameraX version for which we're facing this issue is CameraX 1.4.0-beta01 and the device on which this issue was reported is Pixel 6.

Please do let us know if any additional information is required for the same

Thanks a lot for your time and all the help and support!

Regards,

Mohit

Comments

wu...@google.com <wu...@google.com> #2Jul 24, 2024 12:47AM

Thanks for reporting. We will look into the issue and update the status here.

sc...@google.com <sc...@google.com> #3Jul 24, 2024 02:54AM

Hi Thanks for reporting the issue. To have more context, can you help provide the following information ?

Can you show us how you configure the ImageCapture in the codes ?
Did you enable CameraX Extensions ?
so the occurrence rate is like 20%, right ?

sh...@gmail.com <sh...@gmail.com> #4Jul 24, 2024 05:46AM

Thanks for your response.

Sure. I can provide more data.

ImageCapture.Builder builder = new ImageCapture.Builder();
builder.setCaptureMode(ImageCapture.CAPTURE_MODE_MINIMIZE_LATENCY);

if (!extensionAvailable) {
    builder.setBufferFormat(ImageFormat.YUV_420_888);
}

imageCapture = builder.build();

UseCaseGroup useCaseGroup = new UseCaseGroup.Builder()
                    .addUseCase(preview)
                    .addUseCase(imageCapture)
                    .setViewPort(viewPort)
                    .build();

cameraProvider.unbindAll();
camera = cameraProvider.bindToLifecycle(this, cameraSelector, useCaseGroup);

Yes, Extensions are enabled, which means that the code is not configuring the buffer format and therefore will use the JPEG format. If I disable the extensions, than the error disapears. But I think its more a jpeg format issue then an extension problem.
Yes, occurrence rate is 20%.

ch...@google.com <ch...@google.com> #5Jul 24, 2024 06:40AM

Reassigned to sh...@gmail.com.

Thanks for the information! We will look into this.

sh...@gmail.com <sh...@gmail.com> #6Jul 24, 2024 09:50AM

Any updates on this?

ap...@google.com <ap...@google.com> #7Jul 25, 2024 06:57AM

Yes, we are able to reproduce it and are developing a fix to this.

sh...@gmail.com <sh...@gmail.com> #8Jul 25, 2024 11:18AM

Marked as fixed.

Project: platform/frameworks/support
Branch: androidx-main

commit 366c0b3e157615a4eb7f4597166bf30e0f1c9bdd
Author: Scott Nien <scottnien@google.com>
Date: Thu Dec 14 17:52:42 2023

Fixed the issue when takePicture with Extensions is interruped by lifecycle stop and it can't takePicture anymore after lifecyce start.

1. Handling the image of aborted request in CaptureNode
- When request is aborted, clear the pending request in NoMetadataImageReader
to avoid crash when next request is available.

- When incoming image has null stageId, close the image instead
of crash since this is the case when aborted request
still produce image.

2. Run the CaptureProcessorImpl.process() in non-camera thread instead.
to avoid it from blocking the camera thread which will freeze the preview.

Bug: 306202751
Test: CaptureNodeTest, extensions/ImageCaptureTest
Relnote: "Fixed the crash that happens when lifecycle is stopped before
takePicture request is completed"

Change-Id: Idf017ef3ec1400955066433dd8446f94728b8a1a

M camera/camera-core/src/main/java/androidx/camera/core/imagecapture/CaptureNode.java
M camera/camera-core/src/main/java/androidx/camera/core/imagecapture/NoMetadataImageReader.java
M camera/camera-core/src/test/java/androidx/camera/core/imagecapture/CaptureNodeTest.kt
M camera/camera-extensions/src/androidTest/java/androidx/camera/extensions/ImageCaptureTest.kt
M camera/camera-extensions/src/main/java/androidx/camera/extensions/internal/AdvancedVendorExtender.java
M camera/camera-extensions/src/main/java/androidx/camera/extensions/internal/BasicVendorExtender.java
M camera/camera-extensions/src/main/java/androidx/camera/extensions/internal/sessionprocessor/BasicExtenderSessionProcessor.java
M camera/camera-extensions/src/main/java/androidx/camera/extensions/internal/sessionprocessor/StillCaptureProcessor.java
M camera/camera-testing/src/main/java/androidx/camera/testing/impl/fakes/FakeImageReaderProxy.java
M camera/camera-testlib-extensions/src/main/java/androidx/camera/extensions/impl/NightImageCaptureExtenderImpl.java
M camera/camera-testlib-extensions/src/main/java/androidx/camera/extensions/impl/advanced/LongCaptureAdvancedExtenderImpl.java

https://android-review.googlesource.com/2875502

ju...@gomore.com <ju...@gomore.com> #9Aug 2, 2024 08:34AM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.camera:camera-core:1.4.0-alpha04
androidx.camera:camera-extensions:1.4.0-alpha04

Message last modified on Aug 2, 2024 08:40AM

sg...@google.com <sg...@google.com> #10Aug 2, 2024 09:35AM

This was caused by a bug in R8 (internal issue b/350689668). You can use R8 version 8.5.35 with the fix by merging the following into your settings.gradle or settings.gradle.kts:

pluginManagement {
    buildscript {
        repositories {
            mavenCentral()
            maven {
                url = uri("https://storage.googleapis.com/r8-releases/raw")
            }
        }
        dependencies {
            classpath("com.android.tools:r8:8.5.35")
        }
    }
}

sc...@google.com <sc...@google.com> #11Aug 5, 2024 03:52AM

Hi developer,

We are sorry to cause you so many troubles. We have been tried to add Proguard rules to fix it but seems not working as the problem is caused by missing file in the app instead of files being obfuscated incorrectly. That's why we end up doing such a weird solution to workaround it.

To avoid the issue from happening in the future, we have added the released flavor apk testing into our daily tests which will monitor any issues that only happen with Proguard/R8. We will fix any issue if found and mitigate any impacts to the developers.

Below are more technical details if you are interested:
The OEM's extensions implementation files are in the device runtime instead of in the app or the libraries. In CameraX, we use "compileOnly" dependency to invoke these runtime library so technically these files are missing in the apps. The R8 bug is that it can't handle the missing file case correctly when apps invoke instanceOf. So adding the Proguard rules doesn't help.

Message last modified on Aug 5, 2024 03:52AM

sc...@google.com <sc...@google.com> #12Aug 5, 2024 04:12AM

One thing to add,
We have always tested the released flavor apk with R8 enabled right before releasing the new CameraX libraries. It is enough for catching CameraX bug but it can't catch the R8/AGP issues quickly. That's why we integrate the released apk testing to our daily testing.

ju...@gomore.com <ju...@gomore.com> #13Aug 5, 2024 11:32AM

Thanks for the testing changes and the clarification!

pr...@google.com <pr...@google.com> #14Aug 13, 2024 06:58PM