Night mode freezes when upgrading app to Gradle 8.5.1 [354824993]

Fixed

Bug

Status Update

No update yet.

Description

sh...@gmail.com

created issue #1

Jul 23, 2024 09:18AM

Hi Team CameraX,

Gradle version 8.5.1 seems to currently causing a crash (possibly due to minification) for CameraX extension usage. One of our users reported that switching to night mode caused the preview to freeze and switching to another mode (which rebinds a new camera instance) caused the preview to unfreeze.

Quoting their report on this issue,

After updating to v69, switching to Night mode (on a Pixel 6, but likely not specific to just this model), the preview frame freezes. Switching to another mode unfreezes it.

If you press the button to take a photo regardless, nothing happens, but when you try to switch to another mode after that, you get an error, with the following log:

osVersion: google/oriole/oriole:14/AP2A.240705.004/2024071600:user/release-keys package: app.grapheneos.camera:69

osVersion: google/oriole/oriole:14/AP2A.240705.004/2024071600:user/release-keys
package: app.grapheneos.camera:69


x.S: Camera is closed.
	at y.r.a(Unknown Source:9)
	at x.Q.v(Unknown Source:12)
	at q.A.o(Unknown Source:55)
	at E.h.s(Unknown Source:16)
	at androidx.camera.lifecycle.LifecycleCamera.onStop(Unknown Source:9)
	at androidx.camera.lifecycle.LifecycleCamera.k(Unknown Source:13)
	at androidx.camera.lifecycle.b.h(Unknown Source:48)
	at androidx.camera.lifecycle.b.g(Unknown Source:8)
	at androidx.camera.lifecycle.d.d(Unknown Source:63)
	at d1.q.t(Unknown Source:171)
	at d1.q.u(Unknown Source:257)
	at app.grapheneos.camera.ui.activities.MainActivity.F(Unknown Source:43)
	at d1.f.onTouch(Unknown Source:206)
	at android.view.View.performOnTouchCallback(View.java:16256)
	at android.view.View.dispatchTouchEvent(View.java:16223)
	at android.view.ViewGroup.dispatchTransformedTouchEvent(ViewGroup.java:3119)
	at android.view.ViewGroup.dispatchTouchEvent(ViewGroup.java:2792)
	at android.view.ViewGroup.dispatchTransformedTouchEvent(ViewGroup.java:3125)
	at android.view.ViewGroup.dispatchTouchEvent(ViewGroup.java:2806)
	at android.view.ViewGroup.dispatchTransformedTouchEvent(ViewGroup.java:3125)
	at android.view.ViewGroup.dispatchTouchEvent(ViewGroup.java:2806)
	at android.view.ViewGroup.dispatchTransformedTouchEvent(ViewGroup.java:3125)
	at android.view.ViewGroup.dispatchTouchEvent(ViewGroup.java:2806)
	at android.view.ViewGroup.dispatchTransformedTouchEvent(ViewGroup.java:3125)
	at android.view.ViewGroup.dispatchTouchEvent(ViewGroup.java:2806)
	at android.view.ViewGroup.dispatchTransformedTouchEvent(ViewGroup.java:3125)
	at android.view.ViewGroup.dispatchTouchEvent(ViewGroup.java:2806)
	at android.view.ViewGroup.dispatchTransformedTouchEvent(ViewGroup.java:3125)
	at android.view.ViewGroup.dispatchTouchEvent(ViewGroup.java:2806)
	at android.view.ViewGroup.dispatchTransformedTouchEvent(ViewGroup.java:3125)
	at android.view.ViewGroup.dispatchTouchEvent(ViewGroup.java:2806)
	at android.view.ViewGroup.dispatchTransformedTouchEvent(ViewGroup.java:3125)
	at android.view.ViewGroup.dispatchTouchEvent(ViewGroup.java:2806)
	at android.view.ViewGroup.dispatchTransformedTouchEvent(ViewGroup.java:3125)
	at android.view.ViewGroup.dispatchTouchEvent(ViewGroup.java:2806)
	at com.android.internal.policy.DecorView.superDispatchTouchEvent(DecorView.java:496)
	at com.android.internal.policy.PhoneWindow.superDispatchTouchEvent(PhoneWindow.java:1952)
	at android.app.Activity.dispatchTouchEvent(Activity.java:4518)
	at e.t.dispatchTouchEvent(Unknown Source:2)
	at com.android.internal.policy.DecorView.dispatchTouchEvent(DecorView.java:454)
	at android.view.View.dispatchPointerEvent(View.java:16548)
	at android.view.ViewRootImpl$ViewPostImeInputStage.processPointerEvent(ViewRootImpl.java:7559)
	at android.view.ViewRootImpl$ViewPostImeInputStage.onProcess(ViewRootImpl.java:7326)
	at android.view.ViewRootImpl$InputStage.deliver(ViewRootImpl.java:6723)
	at android.view.ViewRootImpl$InputStage.onDeliverToNext(ViewRootImpl.java:6780)
	at android.view.ViewRootImpl$InputStage.forward(ViewRootImpl.java:6746)
	at android.view.ViewRootImpl$AsyncInputStage.forward(ViewRootImpl.java:6912)
	at android.view.ViewRootImpl$InputStage.apply(ViewRootImpl.java:6754)
	at android.view.ViewRootImpl$AsyncInputStage.apply(ViewRootImpl.java:6969)
	at android.view.ViewRootImpl$InputStage.deliver(ViewRootImpl.java:6727)
	at android.view.ViewRootImpl$InputStage.onDeliverToNext(ViewRootImpl.java:6780)
	at android.view.ViewRootImpl$InputStage.forward(ViewRootImpl.java:6746)
	at android.view.ViewRootImpl$InputStage.apply(ViewRootImpl.java:6754)
	at android.view.ViewRootImpl$InputStage.deliver(ViewRootImpl.java:6727)
	at android.view.ViewRootImpl.deliverInputEvent(ViewRootImpl.java:9827)
	at android.view.ViewRootImpl.doProcessInputEvents(ViewRootImpl.java:9778)
	at android.view.ViewRootImpl.enqueueInputEvent(ViewRootImpl.java:9747)
	at android.view.ViewRootImpl$WindowInputEventReceiver.onInputEvent(ViewRootImpl.java:9969)
	at android.view.InputEventReceiver.dispatchInputEvent(InputEventReceiver.java:295)
	at android.os.MessageQueue.nativePollOnce(Native Method)
	at android.os.MessageQueue.next(MessageQueue.java:349)
	at android.os.Looper.loopOnce(Looper.java:189)
	at android.os.Looper.loop(Looper.java:317)
	at android.app.ActivityThread.main(ActivityThread.java:8623)
	at java.lang.reflect.Method.invoke(Native Method)
	at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:580)
	at com.android.internal.os.ExecInit.main(ExecInit.java:50)
	at com.android.internal.os.RuntimeInit.nativeFinishInit(Native Method)
	at com.android.internal.os.RuntimeInit.main(RuntimeInit.java:369)

(Source: https://github.com/GrapheneOS/Camera/issues/449)

Downgrading to Gradle 8.5.0 in our app's recent release caused the issue to no longer persist. Could you'll please help us fix this issue?

The CameraX version for which we're facing this issue is CameraX 1.4.0-beta01 and the device on which this issue was reported is Pixel 6.

Please do let us know if any additional information is required for the same

Thanks a lot for your time and all the help and support!

Regards,

Mohit

Comments

wu...@google.com <wu...@google.com> #2Jul 24, 2024 12:47AM

Hi Ed, Thank you so much for these suggestions. I've been reviewing them and merging them in. Hopefully it should be live. I've included a thank you note too in the article.

sc...@google.com <sc...@google.com> #3Jul 24, 2024 02:54AM

Great! Thanks a lot, I'll look for the live updates soon!

sh...@gmail.com <sh...@gmail.com> #4Jul 24, 2024 05:46AM

Will stay subscribed to the notifications of this thread for the updates. Thanks a lot for all the help and support!

ch...@google.com <ch...@google.com> #5Jul 24, 2024 06:40AM

Reassigned to sh...@gmail.com.

Hi,

I can reproduce the preview freeze issue as you described by CameraXExtensions with AGP 8.5.1. But the callstack is different. The exception to cause the issue I can see is:

Unable to configure camera Camera@22b3c90[id=0]
java.lang.IllegalArgumentException: Not supported Camera2OutputConfigImpl: class androidx.camera.extensions.impl.advanced.Camera2OutputConfigImplBuilder$SurfaceOutputConfigImplImpl
	at androidx.camera.extensions.internal.sessionprocessor.m.a(SourceFile:1)
	at androidx.camera.extensions.internal.sessionprocessor.a.o(SourceFile:27)
	at androidx.camera.extensions.internal.sessionprocessor.a.e(SourceFile:116)
	at androidx.camera.extensions.internal.sessionprocessor.w.d(SourceFile:17)
	at p.A0.a(SourceFile:446)
	at B.b.run(SourceFile:10)
	at A.d.a(SourceFile:82)
	at A.d.run(SourceFile:590)
	at B.n.run(SourceFile:67)
	at p2.j.run(SourceFile:3)
	at p2.a.run(SourceFile:92)

This is an known issue that we also observed and are clarifying with AGP R8 team.

For the exception callstack you provided, it looks like an expected result when some operations (photo taking or camera control) can't be handled completely but the camera is closed. Then, the corresponding exception will be reported to the app. To prevent from missing any other potential issues different from the known one, could you help to:

Decode the obfuscate stack trace so that we can know what it really is?
Check with your user whether he/she also see the Camera2OutputConfigImpl related exception when reproducing the issue?

Thanks.

sh...@gmail.com <sh...@gmail.com> #6Jul 24, 2024 09:50AM

Hi,

Thanks for trying to reproduce the issue on your end and confirming the crash.

Our camera app currently attempts to enable the extension mode over the default camera selector when the extension is available according to the ExtensionManager and when the user is on an extension mode. It's hard to know whether it is the enabling of extension over the default camera selector that causes the crash, or the binding of an extension enabled camera selector, which makes it difficult to debug this further at the moment. However, downgrading the gradle version has helped fix the issue and it seems to be specifically happeing when we use minification in release mode while building.

I have contacted the user to confirm whether the stack trace you have shared is visible to them too to confirm this issue further.

Thanks a lot for your time and help!

Regards,

Mohit

ap...@google.com <ap...@google.com> #7Jul 25, 2024 06:57AM

Project: platform/frameworks/support
Branch: androidx-main

commit ff306631e8a500893a5497f741af1c11bb62efdb
Author: CharcoalChen <charcoalchen@google.com>
Date: Wed Jul 24 18:04:50 2024

Workaround Camera2OutputConfigImpl conversion issue after enabling minification

Use try-catch to force cast the input Camera2OutputConfigImpl instance to correct type. Verified the workaround on the real Pixel 7 and S24 Ultra devices which have advanced vendor library implementation.

Relnote: "Resolved a CameraX extensions malfunction on devices like Pixel 7/8 and Samsung Galaxy S24 series. The issue, stemming from a Camera2OutputConfigImpl conversion problem in release mode, surfaced after upgrading AGP to 8.5.1 and enabling minification."

Bug:

b/350689668

b/354824993

Test: manual test on Pixel 7 & S24 Ultra
Change-Id: I9959873ee37f47e07aa617b92859d2a5cadc7830

M camera/camera-extensions/src/main/java/androidx/camera/extensions/internal/sessionprocessor/Camera2OutputConfigConverter.java

https://android-review.googlesource.com/3195790

sh...@gmail.com <sh...@gmail.com> #8Jul 25, 2024 11:18AM

Marked as fixed.

Hi Charcoal Chen,

Thanks for making a fix for this issue. We'll test this fix and get back soon after this gets included in the one of the upcoming releases of the library.

Thank you for all your time and support!

Regards,

Mohit

ju...@gomore.com <ju...@gomore.com> #9Aug 2, 2024 08:34AM

It seems a bit odd that the fix is a series of try-catches of casts. Couldn't it had been solved by shipping extra ProGuard rules for whatever extra configuration R8 requires now after AGP 8.5.1? Regardless of that it will be appreciated if a fixed release of the CameraX dependency is made available as we needed to do an emergency rollout of a hot fix for our app with night mode disabled.

Message last modified on Aug 2, 2024 08:40AM

sg...@google.com <sg...@google.com> #10Aug 2, 2024 09:35AM

This was caused by a bug in R8 (internal issue b/350689668). You can use R8 version 8.5.35 with the fix by merging the following into your settings.gradle or settings.gradle.kts:

pluginManagement {
    buildscript {
        repositories {
            mavenCentral()
            maven {
                url = uri("https://storage.googleapis.com/r8-releases/raw")
            }
        }
        dependencies {
            classpath("com.android.tools:r8:8.5.35")
        }
    }
}

sc...@google.com <sc...@google.com> #11Aug 5, 2024 03:52AM

Hi developer,

We are sorry to cause you so many troubles. We have been tried to add Proguard rules to fix it but seems not working as the problem is caused by missing file in the app instead of files being obfuscated incorrectly. That's why we end up doing such a weird solution to workaround it.

To avoid the issue from happening in the future, we have added the released flavor apk testing into our daily tests which will monitor any issues that only happen with Proguard/R8. We will fix any issue if found and mitigate any impacts to the developers.

Below are more technical details if you are interested:
The OEM's extensions implementation files are in the device runtime instead of in the app or the libraries. In CameraX, we use "compileOnly" dependency to invoke these runtime library so technically these files are missing in the apps. The R8 bug is that it can't handle the missing file case correctly when apps invoke instanceOf. So adding the Proguard rules doesn't help.

Message last modified on Aug 5, 2024 03:52AM

sc...@google.com <sc...@google.com> #12Aug 5, 2024 04:12AM

One thing to add,
We have always tested the released flavor apk with R8 enabled right before releasing the new CameraX libraries. It is enough for catching CameraX bug but it can't catch the R8/AGP issues quickly. That's why we integrate the released apk testing to our daily testing.

ju...@gomore.com <ju...@gomore.com> #13Aug 5, 2024 11:32AM

Thanks for the testing changes and the clarification!

pr...@google.com <pr...@google.com> #14Aug 13, 2024 06:58PM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.camera:camera-extensions:1.4.0-rc01

Issue 354824993

Description

Issue summary

Comments

wu...@google.com <wu...@google.com> #2Jul 24, 2024 12:47AM

sc...@google.com <sc...@google.com> #3Jul 24, 2024 02:54AM

sh...@gmail.com <sh...@gmail.com> #4Jul 24, 2024 05:46AM

ch...@google.com <ch...@google.com> #5Jul 24, 2024 06:40AM

sh...@gmail.com <sh...@gmail.com> #6Jul 24, 2024 09:50AM

ap...@google.com <ap...@google.com> #7Jul 25, 2024 06:57AM

sh...@gmail.com <sh...@gmail.com> #8Jul 25, 2024 11:18AM

ju...@gomore.com <ju...@gomore.com> #9Aug 2, 2024 08:34AM

sg...@google.com <sg...@google.com> #10Aug 2, 2024 09:35AM

sc...@google.com <sc...@google.com> #11Aug 5, 2024 03:52AM

sc...@google.com <sc...@google.com> #12Aug 5, 2024 04:12AM

ju...@gomore.com <ju...@gomore.com> #13Aug 5, 2024 11:32AM

pr...@google.com <pr...@google.com> #14Aug 13, 2024 06:58PM

Add comment

Issue metadata