Fixed
Status Update
No update yet.
Comments
wu...@google.com
le...@google.com
Hi Ed, Thank you so much for these suggestions. I've been reviewing them and merging them in. Hopefully it should be live. I've included a thank you note too in the article.
sh...@gmail.com
Great! Thanks a lot, I'll look for the live updates soon!
le...@google.com
ap...@google.com
Project: platform/frameworks/support
Branch: androidx-main
commit 8716f7353f80ded5a193da936b6cbcf9ec792386
Author: leo huang <leohuang@google.com>
Date: Fri Aug 09 10:56:03 2024
Convert PendingRecording to kotlin
Relnote: "Converted PendingRecording into Kotlin implementation."
Bug: 354829267
Test: ./gradlew camera:camera-video:lintDebug
Change-Id: Icf8c197654c4c50e13c762a5680146d8938f7ced
M camera/camera-video/api/current.txt
M camera/camera-video/api/restricted_current.txt
D camera/camera-video/src/main/java/androidx/camera/video/PendingRecording.java
A camera/camera-video/src/main/java/androidx/camera/video/PendingRecording.kt
https://android-review.googlesource.com/3214136
Branch: androidx-main
commit 8716f7353f80ded5a193da936b6cbcf9ec792386
Author: leo huang <leohuang@google.com>
Date: Fri Aug 09 10:56:03 2024
Convert PendingRecording to kotlin
Relnote: "Converted PendingRecording into Kotlin implementation."
Bug: 354829267
Test: ./gradlew camera:camera-video:lintDebug
Change-Id: Icf8c197654c4c50e13c762a5680146d8938f7ced
M camera/camera-video/api/current.txt
M camera/camera-video/api/restricted_current.txt
D camera/camera-video/src/main/java/androidx/camera/video/PendingRecording.java
A camera/camera-video/src/main/java/androidx/camera/video/PendingRecording.kt
ap...@google.com
Project: platform/frameworks/support
Branch: androidx-main
commit 8cb3d84b328f682a37ec739da0372969943bc192
Author: leo huang <leohuang@google.com>
Date: Thu Aug 08 13:49:40 2024
Add mute button in core-test-app
Bug: 354829267
Test: manually testing
Change-Id: Ife6f39aa715dfb7e4345266b154ea8221babf89c
M camera/integration-tests/coretestapp/src/main/java/androidx/camera/integration/core/CameraXActivity.java
A camera/integration-tests/coretestapp/src/main/res/drawable/ic_mic_off.xml
A camera/integration-tests/coretestapp/src/main/res/drawable/ic_mic_on.xml
M camera/integration-tests/coretestapp/src/main/res/layout/activity_camera_xmain.xml
https://android-review.googlesource.com/3212836
Branch: androidx-main
commit 8cb3d84b328f682a37ec739da0372969943bc192
Author: leo huang <leohuang@google.com>
Date: Thu Aug 08 13:49:40 2024
Add mute button in core-test-app
Bug: 354829267
Test: manually testing
Change-Id: Ife6f39aa715dfb7e4345266b154ea8221babf89c
M camera/integration-tests/coretestapp/src/main/java/androidx/camera/integration/core/CameraXActivity.java
A camera/integration-tests/coretestapp/src/main/res/drawable/ic_mic_off.xml
A camera/integration-tests/coretestapp/src/main/res/drawable/ic_mic_on.xml
M camera/integration-tests/coretestapp/src/main/res/layout/activity_camera_xmain.xml
ap...@google.com
Project: platform/frameworks/support
Branch: androidx-main
commit 5c49f5ff204911510e3a2b57f73fa26fa38df428
Author: leo huang <leohuang@google.com>
Date: Tue Aug 06 17:27:24 2024
Add PendingRecording.withAudioEnabled(boolean initialMuted) to control the initial mute state
Relnote: "Added API PendingRecording.withAudioEnabled(boolean initialMuted) to control the initial mute state."
Bug: 354829267
Test: RecorderTest
Change-Id: I635c37a3a703425c58932acbc08051f994484709
M camera/camera-testing/src/main/java/androidx/camera/testing/impl/video/Recording.kt
M camera/camera-testing/src/main/java/androidx/camera/testing/impl/video/RecordingSession.kt
M camera/camera-video/api/current.txt
M camera/camera-video/api/restricted_current.txt
M camera/camera-video/src/androidTest/java/androidx/camera/video/RecorderTest.kt
M camera/camera-video/src/main/java/androidx/camera/video/PendingRecording.kt
M camera/camera-video/src/main/java/androidx/camera/video/Recorder.java
M camera/camera-video/src/main/java/androidx/camera/video/Recording.java
https://android-review.googlesource.com/3208072
Branch: androidx-main
commit 5c49f5ff204911510e3a2b57f73fa26fa38df428
Author: leo huang <leohuang@google.com>
Date: Tue Aug 06 17:27:24 2024
Add PendingRecording.withAudioEnabled(boolean initialMuted) to control the initial mute state
Relnote: "Added API PendingRecording.withAudioEnabled(boolean initialMuted) to control the initial mute state."
Bug: 354829267
Test: RecorderTest
Change-Id: I635c37a3a703425c58932acbc08051f994484709
M camera/camera-testing/src/main/java/androidx/camera/testing/impl/video/Recording.kt
M camera/camera-testing/src/main/java/androidx/camera/testing/impl/video/RecordingSession.kt
M camera/camera-video/api/current.txt
M camera/camera-video/api/restricted_current.txt
M camera/camera-video/src/androidTest/java/androidx/camera/video/RecorderTest.kt
M camera/camera-video/src/main/java/androidx/camera/video/PendingRecording.kt
M camera/camera-video/src/main/java/androidx/camera/video/Recorder.java
M camera/camera-video/src/main/java/androidx/camera/video/Recording.java
le...@google.com
The new API will be released with the upcoming CameraX 1.5.0-alpha01
pr...@google.com
The following release(s) address this bug.It is possible this bug has only been partially addressed:
androidx.camera:camera-video:1.5.0-alpha01
Description
We're facing an issue with muting the audio by default in a recording.
Starting a recording without `PendingRecording.withAudioEnabled` causes the entire recording to not have audio, even after `Recording.mute(false)` which seems to silently fail/ignore the call
If we call `PendingRecording.withAudioEnabled` while the necessary permission is available, we can only mute the recording after `PendingRecording.start` is called which returns the `Recording` instance that has the method needed to mute/unmute the recording.
The potential issue with muting the `Recording` after calling `PendingRecording.start` for the same is that there's a small possibility that the start of the recording could have recorded some audio since logically there's no guarantee that the recording wouldn't have been started by then
Is there any reliable way we can start the recording with the mic mute by default while allowing it to be unmute later/could you'll please introduce a way in the library to reliably achieve the same?
Thanks a lot for your time and all the help and support!
Regards,
Mohit