R8 (AGP 8.5.0+) fails with error "Unexpected rewriting of item: ... to two distinct items:..." [354878031]

Verified

Bug

Status Update

No update yet.

Description

va...@gmail.com

created issue #1

Jul 23, 2024 02:13PM

After updating to AGP 8.5.0 my project build fails with following error (works fine with AGP 8.4.2):

com.android.tools.r8.internal.Lk0: Unexpected rewriting of item: void androidx.constraintlayout.widget.ConstraintLayout.setOnClickListener(android.view.View$OnClickListener) to two distinct items: void android.view.View.setOnClickListener(android.view.View$OnClickListener) and void android.view.ViewGroup.setOnClickListener(android.view.View$OnClickListener)

After investigation, I have found the following code that reproduces this error:

class MyConstraintLayout : ConstraintLayout {
    constructor(context: Context) : super(context)
    constructor(context: Context, attrs: AttributeSet?) : super(context, attrs)
    constructor(context: Context, attrs: AttributeSet?, defStyleAttr: Int) : super(
        context,
        attrs,
        defStyleAttr
    )

    private val child = ConstraintLayout(context)

    override fun setOnClickListener(l: OnClickListener?) {
        super.setOnClickListener(l)
        child.setOnClickListener(l)
    }
}

Comments

va...@gmail.com <va...@gmail.com> #2Jul 23, 2024 02:21PM

It seems the print is benign so I'll remove it; Could be worth it to find out how the message carrying information about "cb 0" (0 is not a valid color buffer handle) ever arrives to that line though

MyApplication.zip

113 KB

Download

cl...@google.com <cl...@google.com> Jul 25, 2024 06:42AM

Reassigned to cl...@google.com.

cl...@google.com <cl...@google.com> #3Jul 25, 2024 10:19AM

I don't think we should necessarily remove these messages from the emulator code since at least some of them may point to real problems. I'm going to make sure that they are not treated as errors in Studio.

dump.zip

14 MB

Download

cl...@google.com <cl...@google.com> #4Jul 26, 2024 08:20AM

Reassigned to ch...@google.com.

I agree with Sergey -- while I think it's fine to remove some logging messages that aren't necessary, the root problem here is that Studio shows everything emitted as if they are errors, with one notification bubble per message. We don't do that for other tools that Studio launches, and in particular, this isn't specific to the "cb 0" message I showed here; there were earlier (different) error messages during the boot as well.

cl...@google.com <cl...@google.com> #5Jul 26, 2024 08:21AM

This behavior was requested specifically by the emulator team (vharron@ iirc, so at least 3-4 years ago). Let me see if I have any more details on why this was requested.

ar...@transfergo.com <ar...@transfergo.com> #6Jul 29, 2024 01:53PM

I couldn't find any relevant threads. IIRC, the main concern at that time was that warnings at startup (e.g. missing acceleration) really needed to be bubbled up to the users. If that is not an issue anymore, and the emulator team only wants errors to be visible, then the proposed change SGTM.

ap...@google.com <ap...@google.com> #7Jul 30, 2024 10:24AM

Yes, I vaguely remember that in some cases, you'd hit run, and then the emulator would fail to start (for example aborting because of some missing thing it needed), so we needed a way to surface these reasons. I don't know if there are any fatal startup errors like this. It seems like there are several things we could do here:

(1) Simplest: just reroute the errors into the log, and if emulator fails to start, that's where people can look. (I think that's what Sergey has already implemented?)

(2) If emulator could update itself to prefix truly fatal error messages in some way (such as error:) and use that for only fatal/exit(-1) reasons, then we could multiplex the output -- errors are shown in notifications as today, everything else is silently dumped to the log

(3) Hold on to the emulator output, and if there's a problem starting the emulator (say if it exits within a few seconds), then show all the emulator output.

ap...@google.com <ap...@google.com> #8Jul 30, 2024 12:29PM

(1) ag/11396356 does write all emulator's messages into Studio log at INFO level.
(2) More discipline in the emulator's messages would definitely help. Right now they don't seem to follow any simple set of rules (the "Emulator: " prefix is added by Studio):

2020-05-06 11:07:04,587 [ 38858] INFO - manager.EmulatorProcessHandler - Emulator: /usr/local/google/home/sprigogin/Android/Sdk/emulator/emulator -netdelay none -netspeed full -avd Nexus_10_API_29 -no-window -gpu auto-no-window -grpc-use-token
2020-05-06 11:07:04,976 [ 39247] INFO - manager.EmulatorProcessHandler - Emulator: pulseaudio: Failed to initialize PA contextaudio: Could not init `pa' audio driver
2020-05-06 11:07:04,985 [ 39256] INFO - manager.EmulatorProcessHandler - Emulator: E0506 11:07:04.983601525 31440 socket_utils_common_posix.cc:201] check for SO_REUSEPORT: {"created":"@1588788424.983585430","description":"SO_REUSEPORT unavailable on compiling system","file":"/mnt/tmpfs/src/android/emu-master-dev/external/grpc/src/core/lib/iomgr/socket_utils_common_posix.cc","file_line":169}
2020-05-06 11:07:05,321 [ 39592] INFO - manager.EmulatorProcessHandler - Emulator: Your emulator is out of date, please update by launching Android Studio:
2020-05-06 11:07:05,321 [ 39592] INFO - manager.EmulatorProcessHandler - Emulator: - Start Android Studio
2020-05-06 11:07:05,321 [ 39592] INFO - manager.EmulatorProcessHandler - Emulator: - Select menu "Tools > Android > SDK Manager"
2020-05-06 11:07:05,321 [ 39592] INFO - manager.EmulatorProcessHandler - Emulator: - Click "SDK Tools" tab
2020-05-06 11:07:05,321 [ 39592] INFO - manager.EmulatorProcessHandler - Emulator: - Check "Android Emulator" checkbox
2020-05-06 11:07:05,321 [ 39592] INFO - manager.EmulatorProcessHandler - Emulator: - Click "OK"
2020-05-06 11:07:05,321 [ 39592] INFO - manager.EmulatorProcessHandler - Emulator:
2020-05-06 11:07:06,475 [ 40746] INFO - manager.EmulatorProcessHandler - Emulator: emulator: INFO: LoggingInterceptor.cpp:70: 1588788426470945, rcvTime: 84, sndTime: 995, UNARY, rcv: 24, snd: 12156, /android.emulation.control.EmulatorController/getStatus() -> [...], OK
2020-05-06 11:07:07,355 [ 41626] INFO - manager.EmulatorProcessHandler - Emulator: emulator: INFO: LoggingInterceptor.cpp:70: 1588788426597819, rcvTime: 34, sndTime: 12945, SERVER_STREAMING, rcv: 48, snd: 1104071, /android.emulation.control.EmulatorController/streamScreenshot(format: RGBA8888 width: 665 height: 1064) -> [...], OK

ap...@google.com <ap...@google.com> #9Jul 30, 2024 01:10PM

Project: r8
Branch: 8.5

commit c7acb443063dedec73d460fb14e64e82abb5cb64
Author: Christoffer Adamsen <christofferqa@google.com>
Date: Tue Jul 30 14:34:33 2024

Reproduce collision in lir rewriting

Bug:

b/354878031

Change-Id: Id9cb083513e5f5bcf59c283c75c8bd6e1c3f47e2

A src/test/java/com/android/tools/r8/lightir/LirLensRewritingWithOneToManyMappingTest.java

https://r8-review.googlesource.com/94543

ap...@google.com <ap...@google.com> #10Jul 30, 2024 01:10PM

Project: r8
Branch: 8.5

commit 2c176ec131a9edb97721fb8578b7fbb462376632
Author: Christoffer Adamsen <christofferqa@google.com>
Date: Tue Jul 30 15:06:38 2024

Version 8.5.35

Bug:

b/354878031

Change-Id: Idb5334baeec9bae3ac86fadab80bb7d6476523cb

M src/main/java/com/android/tools/r8/Version.java

https://r8-review.googlesource.com/94567

ap...@google.com <ap...@google.com> #11Jul 30, 2024 01:10PM

Project: r8
Branch: 8.5

commit 09b617180bba086b1680da94006fd666d38a9c8d
Author: Christoffer Adamsen <christofferqa@google.com>
Date: Tue Jul 30 15:06:29 2024

Account for collisions in lir rewriting

Bug:

b/354878031

Change-Id: I0f141936f2835497fa6553a0e260f4d7fb04d20b

M src/main/java/com/android/tools/r8/lightir/LirLensCodeRewriter.java
M src/test/java/com/android/tools/r8/lightir/LirLensRewritingWithOneToManyMappingTest.java

https://r8-review.googlesource.com/94545

ap...@google.com <ap...@google.com> #12Jul 30, 2024 01:10PM

Project: r8
Branch: 8.6

commit 0010e225978e5ba992085b9634b82b2f19ee01f4
Author: Christoffer Adamsen <christofferqa@google.com>
Date: Tue Jul 30 14:33:38 2024

Reproduce collision in lir rewriting

Bug:

b/354878031

Change-Id: Id9cb083513e5f5bcf59c283c75c8bd6e1c3f47e2

A src/test/java/com/android/tools/r8/lightir/LirLensRewritingWithOneToManyMappingTest.java

https://r8-review.googlesource.com/94565

ap...@google.com <ap...@google.com> #13Jul 30, 2024 01:11PM

Project: r8
Branch: 8.6

commit 031da36bee13038b4c52fa6388afb8a9e65ad86d
Author: Christoffer Adamsen <christofferqa@google.com>
Date: Tue Jul 30 14:53:38 2024

Version 8.6.17

Bug:

b/354878031

Change-Id: I72eb3eb36ed9dfc36d8676d53f3897141ef285f2

M src/main/java/com/android/tools/r8/Version.java

https://r8-review.googlesource.com/94566

ap...@google.com <ap...@google.com> #14Jul 30, 2024 01:11PM

Project: r8
Branch: 8.6

commit a5a913b2f601a142c93f260beb01ce53b3903dc9
Author: Christoffer Adamsen <christofferqa@google.com>
Date: Tue Jul 30 14:53:08 2024

Account for collisions in lir rewriting

Bug:

b/354878031

https://r8-review.googlesource.com/94544

ap...@google.com <ap...@google.com> #15Jul 30, 2024 01:14PM

b/354878031

Change-Id: Id9cb083513e5f5bcf59c283c75c8bd6e1c3f47e2

A src/test/java/com/android/tools/r8/lightir/LirLensRewritingWithOneToManyMappingTest.java

https://r8-review.googlesource.com/94543

ap...@google.com <ap...@google.com> #16Jul 30, 2024 01:14PM

b/354878031

https://r8-review.googlesource.com/94545

ch...@google.com <ch...@google.com> #17Jul 31, 2024 06:55AM

Marked as fixed.

Thanks for the feedback and for supplying a reproduction! This should now be fixed in R8 versions 8.5.35 and 8.6.17. It would be great if you could confirm whether this resolves your issue.

ar...@transfergo.com <ar...@transfergo.com> #18Jul 31, 2024 01:31PM

I tested R8 version 8.5.35:
> Task :r8Version
8.5.35 (build 2c176ec131a9edb97721fb8578b7fbb462376632 from go/r8bot (luci-r8-custom-ci-archive-0-gths))
My issue mentioned above no longer occurs and release build succeeds.
Thank you!

ch...@google.com <ch...@google.com> Jul 31, 2024 03:40PM

Verified by ch...@google.com.

an...@google.com <an...@google.com> #19Aug 6, 2024 10:15PM

Thank you for your patience while our engineering team worked to resolve this issue. A fix for this issue is now available in:

Android Studio Koala Feature Drop | 2024.1.2 RC 1
Android Gradle Plugin 8.6.0-rc01

We encourage you to try the latest update.

If you notice further issues or have questions, please file a new bug report.

Thank you for taking the time to submit feedback — we really appreciate it!

an...@google.com <an...@google.com> #20Aug 9, 2024 12:55AM

The fixes for this issue are now also available in:

Android Studio Koala | 2024.1.1 Patch 2
Android Gradle Plugin 8.5.2

We encourage you to try the latest update.

If you notice further issues or have questions, please file a new bug report.

va...@gmail.com <va...@gmail.com> #21Aug 12, 2024 08:52AM

Thank you! AGP 8.5.2 resolves my issue.

Issue 354878031

Description

Issue summary

Comments

va...@gmail.com <va...@gmail.com> #2Jul 23, 2024 02:21PM

cl...@google.com <cl...@google.com> Jul 25, 2024 06:42AM

cl...@google.com <cl...@google.com> #3Jul 25, 2024 10:19AM

cl...@google.com <cl...@google.com> #4Jul 26, 2024 08:20AM

cl...@google.com <cl...@google.com> #5Jul 26, 2024 08:21AM

ar...@transfergo.com <ar...@transfergo.com> #6Jul 29, 2024 01:53PM

ap...@google.com <ap...@google.com> #7Jul 30, 2024 10:24AM

ap...@google.com <ap...@google.com> #8Jul 30, 2024 12:29PM

ap...@google.com <ap...@google.com> #9Jul 30, 2024 01:10PM

ap...@google.com <ap...@google.com> #10Jul 30, 2024 01:10PM

ap...@google.com <ap...@google.com> #11Jul 30, 2024 01:10PM

ap...@google.com <ap...@google.com> #12Jul 30, 2024 01:10PM

ap...@google.com <ap...@google.com> #13Jul 30, 2024 01:11PM

ap...@google.com <ap...@google.com> #14Jul 30, 2024 01:11PM

ap...@google.com <ap...@google.com> #15Jul 30, 2024 01:14PM

ap...@google.com <ap...@google.com> #16Jul 30, 2024 01:14PM

ch...@google.com <ch...@google.com> #17Jul 31, 2024 06:55AM

ar...@transfergo.com <ar...@transfergo.com> #18Jul 31, 2024 01:31PM

ch...@google.com <ch...@google.com> Jul 31, 2024 03:40PM

an...@google.com <an...@google.com> #19Aug 6, 2024 10:15PM

an...@google.com <an...@google.com> #20Aug 9, 2024 12:55AM

va...@gmail.com <va...@gmail.com> #21Aug 12, 2024 08:52AM

Add comment

Issue metadata