R8 (AGP 8.5.0+) fails with error "Unexpected rewriting of item: ... to two distinct items:..." [354878031]

Verified

Bug

Status Update

No update yet.

Description

va...@gmail.com

created issue #1

Jul 23, 2024 02:13PM

After updating to AGP 8.5.0 my project build fails with following error (works fine with AGP 8.4.2):

com.android.tools.r8.internal.Lk0: Unexpected rewriting of item: void androidx.constraintlayout.widget.ConstraintLayout.setOnClickListener(android.view.View$OnClickListener) to two distinct items: void android.view.View.setOnClickListener(android.view.View$OnClickListener) and void android.view.ViewGroup.setOnClickListener(android.view.View$OnClickListener)

After investigation, I have found the following code that reproduces this error:

class MyConstraintLayout : ConstraintLayout {
    constructor(context: Context) : super(context)
    constructor(context: Context, attrs: AttributeSet?) : super(context, attrs)
    constructor(context: Context, attrs: AttributeSet?, defStyleAttr: Int) : super(
        context,
        attrs,
        defStyleAttr
    )

    private val child = ConstraintLayout(context)

    override fun setOnClickListener(l: OnClickListener?) {
        super.setOnClickListener(l)
        child.setOnClickListener(l)
    }
}

Comments

va...@gmail.com <va...@gmail.com> #2Jul 23, 2024 02:21PM

This was broken by 3bca759a5ff08352de831bb1e9b61b1ec2b3362d.
Fix (pending) is I2c2dc7b600603ee430fd0d91b23d52ea8aa29ca9.

MyApplication.zip

113 KB

Download

cl...@google.com <cl...@google.com> Jul 25, 2024 06:42AM

Reassigned to cl...@google.com.

cl...@google.com <cl...@google.com> #3Jul 25, 2024 10:19AM

Almost 2 months later and this is still broken

dump.zip

14 MB

Download

cl...@google.com <cl...@google.com> #4Jul 26, 2024 08:20AM

Reassigned to ch...@google.com.

Since there is no progression, I wanted to share our quick-fix for the issue.

#sdkmanager --package_file=${PATH_WORKSPACE}/packages
while read p; do echo "y" | sdkmanager "${p}"; done <${PATH_WORKSPACE}/packages

cl...@google.com <cl...@google.com> #5Jul 26, 2024 08:21AM

jb...@google.com What is the update on this?

ar...@transfergo.com <ar...@transfergo.com> #6Jul 29, 2024 01:53PM

What is the status of this item?

ap...@google.com <ap...@google.com> #7Jul 30, 2024 10:24AM

This has been fixed on master today (internal ref: ag/2945015) and will be available in the next SDK release.

ap...@google.com <ap...@google.com> #8Jul 30, 2024 12:29PM

Any ETA on next release?

ap...@google.com <ap...@google.com> #9Jul 30, 2024 01:10PM

Still broken and not updated? --package_file argument is not usable in it's current form on 26.1.1 straight from the developer site.

ap...@google.com <ap...@google.com> #10Jul 30, 2024 01:10PM

Comfirmed that this seems to still be broken. Can we have an update please?

```
(15:58:11) C02W513SHTD8:files aso$ /opt/android-sdk-macosx/tools/bin/sdkmanager --version
26.1.1

(15:58:17) C02W513SHTD8:files aso$ /opt/android-sdk-macosx/tools/bin/sdkmanager --install --package_file=package_file
Warning: Unknown argument --package_file=package_file
```

ap...@google.com <ap...@google.com> #11Jul 30, 2024 01:10PM

Hi, is there any update to this issue? Thanks.

ap...@google.com <ap...@google.com> #12Jul 30, 2024 01:10PM

Hi Google. You claim it's been fixed on master, but we haven't had a new release since the broken version 26.1.1. Can you please release the fix?

ap...@google.com <ap...@google.com> #13Jul 30, 2024 01:11PM

Yeah, still not fixed --'

ap...@google.com <ap...@google.com> #14Jul 30, 2024 01:11PM

Can't believe this still isn't fixed 2 years later for a command line utility that sits on the main dev site.

ap...@google.com <ap...@google.com> #15Jul 30, 2024 01:14PM

Any updates on this? The help for this command clearly states this argument is supported.

ap...@google.com <ap...@google.com> #16Jul 30, 2024 01:14PM

Has anyone re-tried it? We switched back to RUN sdkmanager --package_file=$ANDROID_HOME/packages.txt in our Dockerfile back in March of 2021.

ch...@google.com <ch...@google.com> #17Jul 31, 2024 06:55AM

Marked as fixed.

For what it's worth, I did a quick test with the latest CLI: 11076708 (https://developer.android.com/studio#downloads) on OSX and tried it with a simple:

./sdkmanager --sdk_root="../sdk" --package_file=deps.txt

Deps.txt:

platform-tools
extras;google;instantapps
build-tools;35.0.0-rc3

So perhaps this is now resolved? I haven't tried it with more packages

ar...@transfergo.com <ar...@transfergo.com> #18Jul 31, 2024 01:31PM

I tested R8 version 8.5.35:
> Task :r8Version
8.5.35 (build 2c176ec131a9edb97721fb8578b7fbb462376632 from go/r8bot (luci-r8-custom-ci-archive-0-gths))
My issue mentioned above no longer occurs and release build succeeds.
Thank you!

ch...@google.com <ch...@google.com> Jul 31, 2024 03:40PM

Verified by ch...@google.com.

an...@google.com <an...@google.com> #19Aug 6, 2024 10:15PM

Thank you for your patience while our engineering team worked to resolve this issue. A fix for this issue is now available in:

Android Studio Koala Feature Drop | 2024.1.2 RC 1
Android Gradle Plugin 8.6.0-rc01

We encourage you to try the latest update.

If you notice further issues or have questions, please file a new bug report.

Thank you for taking the time to submit feedback — we really appreciate it!

an...@google.com <an...@google.com> #20Aug 9, 2024 12:55AM

The fixes for this issue are now also available in:

Android Studio Koala | 2024.1.1 Patch 2
Android Gradle Plugin 8.5.2