IssueTracker

eclass: Don't patch LLVM with new branch workflows

There's no particularly easy way to extract whether
we're on a specific sha with the manifest, or whether
we're on an upstream branch. The easiest way seems to
be to just say later versions use this new workflow.

BUG=b:368393962
TEST=sudo emerge sys-devel/llvm on new branch
TEST=CQ

Change-Id: I8cbc5c620d3ba429576b6cba02f761760e2e5ceb
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/overlays/chromiumos-overlay/+/5905716
Commit-Queue: Jordan Abrahams-Whitehead <ajordanr@google.com>
Tested-by: Jordan Abrahams-Whitehead <ajordanr@google.com>
Reviewed-by: George Burgess <gbiv@chromium.org>

Files:

• M eclass/cros-llvm.eclass

Hash: f553966e5e54820caa194785da5cbd5335976cc3
Date:  Mon Oct 07 19:40:07 2024

llvm_tools: Add --keep-non-patch for git_am calls

We want to preserve the leading tags like [libc++] and
[lldb], and this flag lets us do that.

BUG=b:368393962
TEST=Applied patch stack and uploaded

Change-Id: Ic452e4c0a03291dd6530f0c23bead9a6a883d470
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/toolchain-utils/+/5923000
Commit-Queue: George Burgess <gbiv@chromium.org>
Auto-Submit: Jordan Abrahams-Whitehead <ajordanr@google.com>
Tested-by: George Burgess <gbiv@chromium.org>
Tested-by: Jordan Abrahams-Whitehead <ajordanr@google.com>
Commit-Queue: ChromeOS Auto Runner <chromeos-auto-runner@chromeos-bot.iam.gserviceaccount.com>
Reviewed-by: George Burgess <gbiv@chromium.org>

Files:

• M llvm_tools/patch_utils.py

Hash: 729fc0df0e556eda0fbbcecd905b3a8ab347ac55
Date:  Thu Oct 10 21:33:42 2024

llvm_tools: Update llvm-next revision and SHA

This commit does 2 things:
1. Move LLVM Next officially to r547379
2. Disable warnings for nightly SDK builds

BUG=b:368393962
TEST=CQ

Change-Id: I8a73f94c1c77892da79d266fc81c907d27d50982
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/toolchain-utils/+/5923001
Commit-Queue: Jordan Abrahams-Whitehead <ajordanr@google.com>
Reviewed-by: George Burgess <gbiv@chromium.org>
Tested-by: Jordan Abrahams-Whitehead <ajordanr@google.com>

Files:

• M llvm_tools/llvm_next.py

Hash: eff66fbbb676e266959c94286e2ecb460438c54e
Date:  Thu Oct 10 22:36:41 2024

llvm_tools: Fetch external remote with verify_patch_consistency

Before we were fetching "origin", which I'm not actually sure went
anywhere? But running this in a clean chroot seems to do what we want.
The `git fetch cros main` above this seems to get us the latest
upstream llvm-project commits, it's that we don't find the right SHA
during translation.

Also add some error logging/helpful messaging for when patches fail to
apply.

BUG=b:368393962
TEST=verify_patch_consistency --cl 5902466

Change-Id: Id65ac1e1805778bf26cc34e19d344fc0691082df
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/toolchain-utils/+/5926252
Reviewed-by: George Burgess <gbiv@chromium.org>
Commit-Queue: Jordan Abrahams-Whitehead <ajordanr@google.com>
Tested-by: Jordan Abrahams-Whitehead <ajordanr@google.com>

Files:

• M llvm_tools/verify_patch_consistency.py

Hash: 9375ed17fff353aca9956c5b5bb18c8c2fc17996
Date:  Fri Oct 11 17:05:00 2024

llvm_tools: Add verified label command to verify_patch_consistency

This step was missing in the approval commands.

It's a bit messy of an addition but works fine.

BUG=b:368393962
TEST=Ran it and looked at the printed output

Change-Id: Iedf3b3d1cbf4860c50ec9f2f7ea554f86f222919
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/toolchain-utils/+/5926253
Reviewed-by: George Burgess <gbiv@chromium.org>
Tested-by: Jordan Abrahams-Whitehead <ajordanr@google.com>
Commit-Queue: Jordan Abrahams-Whitehead <ajordanr@google.com>

Files:

• M llvm_tools/verify_patch_consistency.py

Hash: d924cc28b63e3baaa250a8966f2f07b5ad5a43c6
Date:  Fri Oct 11 17:57:49 2024