R8 8.5.x StackOverflowError in SimpleInliningConstraintAnalysis [355238622]

Fixed

Bug

Status Update

No update yet.

Description

se...@team.bumble.com

created issue #1

Jul 25, 2024 11:06AM

AGP: 8.5.1
R8 versions tested: 8.5.27 and 8.5.33

AGP 8.4.2/R8 8.4.26 worked fine.

The failure happens in about 20% of release builds minified by R8, not every time.

Stacktrace:

com.android.tools.r8.CompilationFailedException: Compilation failed to complete
at Version.fakeStackEntry(Version_8.5.33.java:0)	
at com.android.tools.r8.InternalCompilationFailedExceptionUtils.create(InternalCompilationFailedExceptionUtils.java:29)	
at com.android.tools.r8.utils.ExceptionUtils.failWithFakeEntry(ExceptionUtils.java:145)	
at com.android.tools.r8.utils.ExceptionUtils.failCompilation(ExceptionUtils.java:89)	
at com.android.tools.r8.utils.ExceptionUtils.withCompilationHandler(ExceptionUtils.java:83)	
at com.android.tools.r8.utils.ExceptionUtils.withR8CompilationHandler(ExceptionUtils.java:69)	
at com.android.tools.r8.R8.runForTesting(R8.java:238)	
at com.android.tools.r8.R8.run(R8.java:194)	
at com.android.builder.dexing.R8Tool.runR8(r8Tool.kt:332)	
at com.android.build.gradle.internal.tasks.R8Task$Companion.shrink(R8Task.kt:782)	
at com.android.build.gradle.internal.tasks.R8Task$R8Runnable.execute(R8Task.kt:856)
...
Caused by: java.lang.StackOverflowError: (No message provided)
at com.android.tools.r8.ir.analysis.inlining.SimpleInliningConstraintAnalysis.computeConstraintForJumpInstruction(SimpleInliningConstraintAnalysis.java:158)	
at com.android.tools.r8.ir.analysis.inlining.SimpleInliningConstraintAnalysis.analyzeInstructionsInBlock(SimpleInliningConstraintAnalysis.java:122)	
at com.android.tools.r8.ir.analysis.inlining.SimpleInliningConstraintAnalysis.analyzeInstructionsInBlock(SimpleInliningConstraintAnalysis.java:86)	
at com.android.tools.r8.ir.analysis.inlining.SimpleInliningConstraintAnalysis.lambda$computeConstraintForJumpInstruction$0(SimpleInliningConstraintAnalysis.java:185)	
at com.android.tools.r8.ir.analysis.inlining.SimpleInliningConstraint.lazyMeet(SimpleInliningConstraint.java:72)	
at com.android.tools.r8.ir.analysis.inlining.SimpleInliningConstraintAnalysis.computeConstraintForJumpInstruction(SimpleInliningConstraintAnalysis.java:184)	
at com.android.tools.r8.ir.analysis.inlining.SimpleInliningConstraintAnalysis.analyzeInstructionsInBlock(SimpleInliningConstraintAnalysis.java:122)	
at com.android.tools.r8.ir.analysis.inlining.SimpleInliningConstraintAnalysis.analyzeInstructionsInBlock(SimpleInliningConstraintAnalysis.java:86)	
at com.android.tools.r8.ir.analysis.inlining.SimpleInliningConstraintAnalysis.lambda$computeConstraintForJumpInstruction$0(SimpleInliningConstraintAnalysis.java:185)	
at com.android.tools.r8.ir.analysis.inlining.SimpleInliningConstraint.lazyMeet(SimpleInliningConstraint.java:72)	
at com.android.tools.r8.ir.analysis.inlining.SimpleInliningConstraintAnalysis.computeConstraintForJumpInstruction(SimpleInliningConstraintAnalysis.java:184)	
at com.android.tools.r8.ir.analysis.inlining.SimpleInliningConstraintAnalysis.analyzeInstructionsInBlock(SimpleInliningConstraintAnalysis.java:122)	
at com.android.tools.r8.ir.analysis.inlining.SimpleInliningConstraintAnalysis.analyzeInstructionsInBlock(SimpleInliningConstraintAnalysis.java:86)	
at com.android.tools.r8.ir.analysis.inlining.SimpleInliningConstraintAnalysis.lambda$computeConstraintForJumpInstruction$0(SimpleInliningConstraintAnalysis.java:185)	
at com.android.tools.r8.ir.analysis.inlining.SimpleInliningConstraint.lazyMeet(SimpleInliningConstraint.java:72)	
at com.android.tools.r8.ir.analysis.inlining.SimpleInliningConstraintAnalysis.computeConstraintForJumpInstruction(SimpleInliningConstraintAnalysis.java:184)	
at com.android.tools.r8.ir.analysis.inlining.SimpleInliningConstraintAnalysis.analyzeInstructionsInBlock(SimpleInliningConstraintAnalysis.java:122)	
at com.android.tools.r8.ir.analysis.inlining.SimpleInliningConstraintAnalysis.analyzeInstructionsInBlock(SimpleInliningConstraintAnalysis.java:86)	
at com.android.tools.r8.ir.analysis.inlining.SimpleInliningConstraintAnalysis.lambda$computeConstraintForJumpInstruction$0(SimpleInliningConstraintAnalysis.java:185)	
at com.android.tools.r8.ir.analysis.inlining.SimpleInliningConstraint.lazyMeet(SimpleInliningConstraint.java:72)
...

Comments

ja...@google.com <ja...@google.com> Jul 25, 2024 07:41PM

Assigned to an...@google.com.

cl...@google.com <cl...@google.com> #2Jul 26, 2024 09:21AM

Reassigned to ch...@google.com.

This was broken by 3bca759a5ff08352de831bb1e9b61b1ec2b3362d.
Fix (pending) is I2c2dc7b600603ee430fd0d91b23d52ea8aa29ca9.

se...@team.bumble.com <se...@team.bumble.com> #3Jul 26, 2024 02:11PM

Almost 2 months later and this is still broken

Message last modified on Jul 26, 2024 02:28PM

ch...@google.com <ch...@google.com> #4Jul 30, 2024 07:00AM

Since there is no progression, I wanted to share our quick-fix for the issue.

#sdkmanager --package_file=${PATH_WORKSPACE}/packages
while read p; do echo "y" | sdkmanager "${p}"; done <${PATH_WORKSPACE}/packages

se...@team.bumble.com <se...@team.bumble.com> #5Aug 14, 2024 10:03PM

jb...@google.com What is the update on this?

Message last modified on Aug 14, 2024 10:04PM

ch...@google.com <ch...@google.com> #6Aug 15, 2024 06:24AM

What is the status of this item?

se...@team.bumble.com <se...@team.bumble.com> #7Aug 15, 2024 04:19PM

This has been fixed on master today (internal ref: ag/2945015) and will be available in the next SDK release.

deleted

0 B

deleted

0 B

se...@team.bumble.com <se...@team.bumble.com> #8Aug 15, 2024 04:22PM

Any ETA on next release?

Message last modified on Aug 15, 2024 04:23PM

Main.kt

129 B

Download

Mapper.kt

147 KB

Download

R.java

197 KB

View

Download

ap...@google.com <ap...@google.com> #9Aug 19, 2024 07:38AM

Still broken and not updated? --package_file argument is not usable in it's current form on 26.1.1 straight from the developer site.

ch...@google.com <ch...@google.com> Aug 19, 2024 11:22AM

Marked as fixed.

ap...@google.com <ap...@google.com> #10Aug 19, 2024 12:13PM

Comfirmed that this seems to still be broken. Can we have an update please?

```
(15:58:11) C02W513SHTD8:files aso$ /opt/android-sdk-macosx/tools/bin/sdkmanager --version
26.1.1

(15:58:17) C02W513SHTD8:files aso$ /opt/android-sdk-macosx/tools/bin/sdkmanager --install --package_file=package_file
Warning: Unknown argument --package_file=package_file
```

ap...@google.com <ap...@google.com> #11Aug 19, 2024 12:13PM

Hi, is there any update to this issue? Thanks.

ap...@google.com <ap...@google.com> #12Aug 19, 2024 12:13PM

Hi Google. You claim it's been fixed on master, but we haven't had a new release since the broken version 26.1.1. Can you please release the fix?

ap...@google.com <ap...@google.com> #13Aug 19, 2024 12:13PM

Yeah, still not fixed --'

ap...@google.com <ap...@google.com> #14Aug 19, 2024 12:15PM

Can't believe this still isn't fixed 2 years later for a command line utility that sits on the main dev site.

an...@google.com <an...@google.com> #15Sep 17, 2024 09:19PM

Any updates on this? The help for this command clearly states this argument is supported.

Issue 355238622

Description

Issue summary

Comments

ja...@google.com <ja...@google.com> Jul 25, 2024 07:41PM

cl...@google.com <cl...@google.com> #2Jul 26, 2024 09:21AM

se...@team.bumble.com <se...@team.bumble.com> #3Jul 26, 2024 02:11PM

ch...@google.com <ch...@google.com> #4Jul 30, 2024 07:00AM

se...@team.bumble.com <se...@team.bumble.com> #5Aug 14, 2024 10:03PM

ch...@google.com <ch...@google.com> #6Aug 15, 2024 06:24AM

se...@team.bumble.com <se...@team.bumble.com> #7Aug 15, 2024 04:19PM

se...@team.bumble.com <se...@team.bumble.com> #8Aug 15, 2024 04:22PM

ap...@google.com <ap...@google.com> #9Aug 19, 2024 07:38AM

ch...@google.com <ch...@google.com> Aug 19, 2024 11:22AM

ap...@google.com <ap...@google.com> #10Aug 19, 2024 12:13PM

ap...@google.com <ap...@google.com> #11Aug 19, 2024 12:13PM

ap...@google.com <ap...@google.com> #12Aug 19, 2024 12:13PM

ap...@google.com <ap...@google.com> #13Aug 19, 2024 12:13PM

ap...@google.com <ap...@google.com> #14Aug 19, 2024 12:15PM

an...@google.com <an...@google.com> #15Sep 17, 2024 09:19PM

Add comment

Issue metadata