Remove use of Thread.sleep() in `waitForNotificationToDisappears` [355417923]

Bug

Status Update

No update yet.

Description

al...@google.com

created issue #1

Jul 25, 2024 02:40PM

We do not allow Thread.sleep() in tests. The usage in protolayout tests is causing problems for other developers, and we will need to disable any tests relying on waitForNotificationToDisappears as a synchronization barrier.

This bug is specifically for a fix, but you may also need to re-enable tests after you land one. The infrastructure team has asked developers blocked by tests that use this method to disable the relevant tests.

Comments

xi...@google.com <xi...@google.com> #2Jul 25, 2024 04:20PM

Assigned to tn...@google.com.

Automatic regression verification started for measurement:

ChromiumPerf/android-pixel6-perf/system_health.memory_mobile/memory:chrome:all_processes:reported_by_chrome:malloc:max_committed_size_avg/browse_news

Verification workflow id: projects/62121018386/locations/us-central1/workflows/sandwich-verification-workflow-prod/executions/f430dab5-4642-48dd-a3d6-a50904c1d68e

al...@google.com <al...@google.com> #3Jul 25, 2024 04:56PM

🥪 Regression verification projects/62121018386/locations/us-central1/workflows/sandwich-verification-workflow-prod/executions/f430dab5-4642-48dd-a3d6-a50904c1d68e job 169445e4610000 for test: ChromiumPerf/android-pixel6-perf/system_health.memory_mobile/memory:chrome:all_processes:reported_by_chrome:malloc:max_committed_size_avg/browse_news
did NOT reproduce the regression with statistic: {'control_median': 135405568, 'lower': -2.0340368398504394, 'p_value': 0.42795460671186447, 'treatment_median': 135325696, 'upper': 1.0165479548803757}.
Issue closed.

tn...@google.com <tn...@google.com> #4Jul 25, 2024 04:58PM

alanv@google.com Do you have some suggestion please on a workarounds? If I remember correctly (need to have a look in more detailes), we added it because we are taking a screenshot of the top left corner (cropping to a watch size) which was before that sleep taken over by some notification appearing. Is there a way to disable notifications or similar, so that nothing from system is shown on the emulator?

al...@google.com <al...@google.com> #5Jul 25, 2024 06:11PM

I'm asking the SysUI Notifications team, but I think we might not have an elegant solution that works outside of CTS.

al...@google.com <al...@google.com> #6Jul 25, 2024 06:25PM

+cc Jeff on that team in case he has any ideas

tn...@google.com <tn...@google.com> #7Aug 7, 2024 12:12PM

jeffdq@google.com any thoughts on this please?

tn...@google.com <tn...@google.com> Aug 16, 2024 10:16PM

Status: New