AutomaticGenerationDuringBuild and managedDevices used together break benchmark tests [355515798]

Fixed

Bug

Status Update

No update yet.

Description

ma...@google.com

created issue #1

Jul 25, 2024 11:31PM

When automaticGenerationDuringBuild is enabled and managedDevices are used, benchmark tests fail with:

java.lang.AssertionError: ERRORS (not suppressed): EMULATOR
WARNINGS (suppressed): 

ERROR: Running on Emulator
    Benchmark is running on an emulator, which is not representative of
    real user devices. Use a physical device to benchmark. Emulator
    benchmark improvements might not carry over to a real user's
    experience (or even regress real device performance).

Example configuration in consumer module:

baselineProfile {
    variants {
        // This works
        create("release") {
            automaticGenerationDuringBuild = true
            saveInSrc = true
        }
    }
}

Example configuration in producer module:

baselineProfile {
    useConnectedDevices = false
    managedDevices = [...] 
}

Comments

ap...@google.com <ap...@google.com> #2Aug 19, 2024 11:59PM

Any suggestions on where such an interface might live? I don't think it makes sense for the interface to be in the drawerlayout artifact if you're specifically going to use the interface to *not* use DrawerLayout.

ap...@google.com <ap...@google.com> #3Aug 20, 2024 12:11AM

androidx.customview would be a good candidate. This is used by all of the widget libraries.

ma...@google.com <ma...@google.com> #4Aug 20, 2024 04:02PM

Marked as fixed.

Project: platform/frameworks/support
Branch: androidx-master-dev

commit 3ed3fb003fa6c1244f923202859a616225b5b2fa
Author: Ian Lake <ilake@google.com>
Date: Fri Feb 14 11:17:46 2020

Create an interface for layouts that can be opened

Create a common interface that represents layouts
that have two states: open and closed. This allows
higher level libraries to rely on the interface,
rather than concrete implementations such as
DrawerLayout, making them more resilient to
changes in the current recommended implementation.

Fixes: 129979320
Test: ./gradlew checkApi
Change-Id: I0f2a1414977825aa053c6555261f2b7d4417bd19

M customview/customview/api/1.1.0-alpha02.txt
M customview/customview/api/current.txt
M customview/customview/api/public_plus_experimental_1.1.0-alpha02.txt
M customview/customview/api/public_plus_experimental_current.txt
M customview/customview/api/restricted_1.1.0-alpha02.txt
M customview/customview/api/restricted_current.txt
A customview/customview/src/main/java/androidx/customview/widget/Openable.java
M drawerlayout/drawerlayout/api/1.1.0-alpha03.txt
M drawerlayout/drawerlayout/api/current.txt
M drawerlayout/drawerlayout/api/public_plus_experimental_1.1.0-alpha03.txt
M drawerlayout/drawerlayout/api/public_plus_experimental_current.txt
M drawerlayout/drawerlayout/api/restricted_1.1.0-alpha03.txt
M drawerlayout/drawerlayout/api/restricted_current.txt
M drawerlayout/drawerlayout/build.gradle
M drawerlayout/drawerlayout/src/main/java/androidx/drawerlayout/widget/DrawerLayout.java
M jetifier/jetifier/migration.config
M slidingpanelayout/slidingpanelayout/api/1.1.0-alpha01.txt
M slidingpanelayout/slidingpanelayout/api/current.txt
M slidingpanelayout/slidingpanelayout/api/public_plus_experimental_1.1.0-alpha01.txt
M slidingpanelayout/slidingpanelayout/api/public_plus_experimental_current.txt
M slidingpanelayout/slidingpanelayout/api/restricted_1.1.0-alpha01.txt
M slidingpanelayout/slidingpanelayout/api/restricted_current.txt
M slidingpanelayout/slidingpanelayout/src/main/java/androidx/slidingpanelayout/widget/SlidingPaneLayout.java

https://android-review.googlesource.com/940787

na...@google.com <na...@google.com> #5Sep 18, 2024 05:37PM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.benchmark:benchmark-baseline-profile-gradle-plugin:1.3.1
androidx.benchmark:benchmark-common:1.3.1
androidx.benchmark:benchmark-junit4:1.3.1
androidx.benchmark:benchmark-macro:1.3.1

Issue 355515798

Description

Issue summary

Comments

ap...@google.com <ap...@google.com> #2Aug 19, 2024 11:59PM

ap...@google.com <ap...@google.com> #3Aug 20, 2024 12:11AM

ma...@google.com <ma...@google.com> #4Aug 20, 2024 04:02PM

na...@google.com <na...@google.com> #5Sep 18, 2024 05:37PM

Add comment

Issue metadata