PullToRefreshBox indicator keeps on screen inside ComposeView on ViewPager2 page change [356039090]

Fixed

Bug

Status Update

No update yet.

Description

az...@tab-trader.com

created issue #1

Jul 29, 2024 01:43PM

Jetpack Compose version: 1.6.8

Material Library Version (M2, M3 or Both?): material3 1.3.0-beta05

Material Compose component used: PullToRefreshBox

Android Studio Build: Android Studio Koala | 2024.1.1 Build #AI-241.15989.150.2411.11948838

Kotlin version: 1.9.24

Steps to Reproduce:

Trigger pullToRefresh
Immediately move to different tab
Return back to initial tab

Video Showcase: https://www.youtube.com/shorts/xOzNCZlT45Q

Code example:

class MainActivity : AppCompatActivity() {
    override fun onCreate(savedInstanceState: Bundle?) {
        super.onCreate(savedInstanceState)

        setContentView(R.layout.activity_main)

        findViewById<ViewPager2>(R.id.view_pager).adapter = PagerAdapter(supportFragmentManager, lifecycle)
    }
}

class PagerAdapter(
    fm: FragmentManager,
    lifecycle: Lifecycle
) : FragmentStateAdapter(fm, lifecycle) {
    override fun createFragment(position: Int): Fragment =
        when (position) {
            0 -> PageFragment()
            1 -> PageFragment()
            else -> error("Wrong position")
        }

    override fun getItemCount() = 2
}

class PageFragment: Fragment() {
    override fun onCreateView(inflater: LayoutInflater, container: ViewGroup?, savedInstanceState: Bundle?): View {
        return ComposeView(requireContext()).apply {
            setViewCompositionStrategy(ViewCompositionStrategy.DisposeOnLifecycleDestroyed(lifecycle))
            setContent { Page() }
        }
    }
}

@Composable
fun Page() {
    var isRefreshing by remember { mutableStateOf(false) }
    PullToRefreshBox(
        isRefreshing = isRefreshing,
        onRefresh = {
            thread {
                isRefreshing = true
                Thread.sleep(1000)
                isRefreshing = false
            }
        },
        modifier = Modifier.fillMaxSize()
    ) {
        LazyColumn {
            items(100) {
                Text("Item $it", modifier = Modifier.fillMaxWidth())
            }
        }
    }
}

Comments

ma...@google.com <ma...@google.com> Jul 29, 2024 04:39PM

Reassigned to ma...@google.com.

ma...@google.com <ma...@google.com> #2Sep 4, 2024 02:02PM

Reassigned to az...@tab-trader.com.

Project: platform/frameworks/support
Branch: androidx-main
Author: Louis Pullen-Freilich <lpf@google.com>
Link: https://android-review.googlesource.com/3328184

Adds OverscrollEffect#withoutDrawing and OverscrollEffect#withoutEventHandling

Expand for full commit details

Adds OverscrollEffect#withoutDrawing and OverscrollEffect#withoutEventHandling 
 
These APIs allow overscroll to have events dispatched to it by one component, and rendered in a separate component. 
 
Fixes: b/266550551 
Fixes: b/204650733 
Fixes: b/255554340 
Fixes: b/229537244 
Test: OverscrollTest 
Relnote: "Adds OverscrollEffect#withoutDrawing and OverscrollEffect#withoutEventHandling APIs - these APIs create a wrapped instance of the provided overscroll effect that doesn't draw / handle events respectively, which allows for rendering  overscroll in a separate component from the component that is dispatching events. For example, disabling drawing the overscroll inside a lazy list, and then drawing the overscroll separately on top / elsewhere." 
Change-Id: Idbb3d91546b49c1987a041f959bce4b2b09a9f61

Files:

M compose/foundation/foundation/api/current.txt
M compose/foundation/foundation/api/restricted_current.txt
M compose/foundation/foundation/integration-tests/foundation-demos/src/main/java/androidx/compose/foundation/demos/OverscrollDemo.kt
M compose/foundation/foundation/samples/src/main/java/androidx/compose/foundation/samples/OverscrollSample.kt
M compose/foundation/foundation/src/androidInstrumentedTest/kotlin/androidx/compose/foundation/OverscrollTest.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/Overscroll.kt

Hash: f64e25b7a473c757d080521e7dd97b3f6670f60d
Date: Fri Nov 01 18:43:56 2024

Message last modified on Sep 4, 2024 03:01PM

aj...@gmail.com <aj...@gmail.com> #3Sep 5, 2024 02:54PM

Comment has been deleted.

Message last modified on Sep 5, 2024 02:56PM

az...@tab-trader.com <az...@tab-trader.com> #4Sep 5, 2024 02:56PM

Reassigned to ma...@google.com.

Hi,

Here is full sample https://github.com/jukov/PullToRefreshBug

ma...@google.com <ma...@google.com> #5Sep 5, 2024 05:24PM

Thanks I think I was able to identify the issue and a potential fix

ap...@google.com <ap...@google.com> #6Sep 10, 2024 05:36PM

Project: platform/frameworks/support
Branch: androidx-main

commit f1515ea14143b5754df3dcbcb47537eee49c30f2
Author: Mariano Martin <ymarian@google.com>
Date: Thu Sep 05 13:12:04 2024

[PullToRefresh] Fix issue where graphics layer doesnt invalidate

Test: tested manually that now graphics layer invalidates, in some edge cases
where pullToRefresh is used in fragments

Bug: 356039090

Change-Id: Ib80663f6dcf2f7f05bda4189b0931ee697230698

M compose/material3/material3/src/commonMain/kotlin/androidx/compose/material3/pulltorefresh/PullToRefresh.kt

https://android-review.googlesource.com/3256138

ma...@google.com <ma...@google.com> Sep 17, 2024 01:23PM

Marked as fixed.

pr...@google.com <pr...@google.com> #7Oct 2, 2024 05:37PM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.compose.material3:material3:1.4.0-alpha01
androidx.compose.material3:material3-android:1.4.0-alpha01

ap...@google.com <ap...@google.com> #8Nov 19, 2024 04:53PM

Project: platform/frameworks/support
Branch: androidx-main
Author: Mariano Martin <ymarian@google.com>
Link: https://android-review.googlesource.com/3361967

[WideNavigationRail] API Feedback