Fixed
Status Update
Comments
wu...@google.com <wu...@google.com>
ch...@google.com <ch...@google.com> #2
Hi Ed, Thank you so much for these suggestions. I've been reviewing them and merging them in. Hopefully it should be live. I've included a thank you note too in the article.
pr...@paralleldots.com <pr...@paralleldots.com> #3
Great! Thanks a lot, I'll look for the live updates soon!
wu...@google.com <wu...@google.com>
ch...@google.com <ch...@google.com>
ap...@google.com <ap...@google.com> #4
Project: platform/frameworks/support
Branch: androidx-main
commit 179a0b60db3106af27bbd5fa440c58f2751a9630
Author: CharcoalChen <charcoalchen@google.com>
Date: Mon Sep 09 14:43:09 2024
Enable IncorrectJpegMetadataQuirk for Samsung S10e, S10+ devices
Relnote: "Enabled the workaround to fix the incorrect JPEG image metadata issue on Samsung S10e and S10+ devices. With the fix, CameraX can successfully save the JPEG image, or correct Bitmap objects can be returned when calling the ImageProxy.toBitmap() function on these devices if the incorrect JPEG image metadata issue happens."
Bug: 356428987
Test: JpegMetadataCorrectorTest
Change-Id: Iae493350efac5696dd9c210522015c1d3799a6eb
M camera/camera-core/src/main/java/androidx/camera/core/internal/compat/quirk/IncorrectJpegMetadataQuirk.java
M camera/camera-core/src/test/java/androidx/camera/core/internal/compat/workaround/JpegMetadataCorrectorTest.kt
https://android-review.googlesource.com/3255541
Branch: androidx-main
commit 179a0b60db3106af27bbd5fa440c58f2751a9630
Author: CharcoalChen <charcoalchen@google.com>
Date: Mon Sep 09 14:43:09 2024
Enable IncorrectJpegMetadataQuirk for Samsung S10e, S10+ devices
Relnote: "Enabled the workaround to fix the incorrect JPEG image metadata issue on Samsung S10e and S10+ devices. With the fix, CameraX can successfully save the JPEG image, or correct Bitmap objects can be returned when calling the ImageProxy.toBitmap() function on these devices if the incorrect JPEG image metadata issue happens."
Bug: 356428987
Test: JpegMetadataCorrectorTest
Change-Id: Iae493350efac5696dd9c210522015c1d3799a6eb
M camera/camera-core/src/main/java/androidx/camera/core/internal/compat/quirk/IncorrectJpegMetadataQuirk.java
M camera/camera-core/src/test/java/androidx/camera/core/internal/compat/workaround/JpegMetadataCorrectorTest.kt
ch...@google.com <ch...@google.com>
pr...@google.com <pr...@google.com> #5
The following release(s) address this bug.It is possible this bug has only been partially addressed:
androidx.camera:camera-core:1.5.0-alpha02
Description
CAMERAX VERSION 1.3.4
CAMERA APPLICATION NAME AND VERSION: Shelfwatch and 5.3.0
DEVICE NAME:
Samsung Galaxy S10e
Samsung Galaxy A24
Samsung Galaxy S10+
Samsung Galaxy S20 +/FE
DESCRIPTION: Users are facing crashes while taking images, does not happen for all images but happens randomly.
STEPS TO REPRODUCE:
1. Click multiple images with camera x library
REPRODUCIBILITY: As this is faced by our users on specific devices we have not reproduced but from the logs it seems like it happens for 1/20 pictures.
STACK TRACE :
Fatal Exception: java.lang.UnsupportedOperationException: Decode jpeg byte array failed
at androidx.camera.core.internal.utils.ImageUtil.createBitmapFromJpegImage(ImageUtil.java:453)
at androidx.camera.core.internal.utils.ImageUtil.createBitmapFromImageProxy(ImageUtil.java:82)
at androidx.camera.core.ImageProxy.toBitmap(ImageProxy.java:154)
Additonal comments :
Have upgraded to 1.3.4 version of Camera X for the fix in Galaxy A24, will it be fixed for other devices as well?