Fixed
Status Update
No update yet.
Comments
jb...@google.com
il...@google.com
ap...@google.com
Project: platform/frameworks/support
Branch: androidx-main
commit bf060cfe986a88720351c138d9d122a6e2bedff7
Author: Ian Lake <ilake@google.com>
Date: Wed Aug 21 22:08:36 2024
Ensure AndroidFragment works when the state is saved
Since composition continues even after the containing
activity/fragment has its state saved, it is possible
for AndroidFragment to be added for the first time
while FragmentManager.isStateSaved returns true.
AndroidFragment now better handles this scenario by:
1) Using commitNowAllowingStateLoss() to avoid crashes
2) Adding extra logic to fully remove the Fragment
instance if the AndroidFragment is removed from
composition before isStateSaved ever becomes true.
Relnote: "`AndroidFragment` no longer crashes if it is
added to composition while the containing activity/fragment's
state is already saved."
BUG: 356643968
Test: newly added AndroidFragmentTest tests
Change-Id: I985e91e6d654815c99e97927154d0fd8f2228c0b
M fragment/fragment-compose/src/androidTest/java/androidx/fragment/compose/AndroidFragmentTest.kt
M fragment/fragment-compose/src/main/java/androidx/fragment/compose/AndroidFragment.kt
https://android-review.googlesource.com/3235949
Branch: androidx-main
commit bf060cfe986a88720351c138d9d122a6e2bedff7
Author: Ian Lake <ilake@google.com>
Date: Wed Aug 21 22:08:36 2024
Ensure AndroidFragment works when the state is saved
Since composition continues even after the containing
activity/fragment has its state saved, it is possible
for AndroidFragment to be added for the first time
while FragmentManager.isStateSaved returns true.
AndroidFragment now better handles this scenario by:
1) Using commitNowAllowingStateLoss() to avoid crashes
2) Adding extra logic to fully remove the Fragment
instance if the AndroidFragment is removed from
composition before isStateSaved ever becomes true.
Relnote: "`AndroidFragment` no longer crashes if it is
added to composition while the containing activity/fragment's
state is already saved."
BUG: 356643968
Test: newly added AndroidFragmentTest tests
Change-Id: I985e91e6d654815c99e97927154d0fd8f2228c0b
M fragment/fragment-compose/src/androidTest/java/androidx/fragment/compose/AndroidFragmentTest.kt
M fragment/fragment-compose/src/main/java/androidx/fragment/compose/AndroidFragment.kt
il...@google.com
We've hardened AndroidFragment to avoid crashing if you add an AndroidFragment to composition while your activity/fragment has already saved its state. This will be available in Fragment 1.8.3.
ni...@gmail.com
Comment has been deleted.
ni...@soprasteria.com
Thank You. This fix responds exactly to our trouble.
Best Regards,
Nicolas V.
Description
Component used: AndroidFragment
Version used:
Devices/Android versions reproduced on: Any (See attached image)
Reproduction :
Discussion We have no clue why it's triggered, anyway :
When we explore the source code of "Androidfragment", the usage of "commitNow" leads to the famous crash when application go to / come back from the background.
one of the explored solution today is to override this component and replace commitNow with the least unstable commitAllowingStateLoss.
Do you have any advice / opinion to this situation ?
Best Regards,
Nicolas V.