Fixed
Status Update
Comments
jp...@google.com <jp...@google.com>
ya...@google.com <ya...@google.com> #2
Project: platform/frameworks/support
Branch: androidx-master-dev
commit b90079595f33f58fece04026a97faa0d243acdb1
Author: Yuichi Araki <yaraki@google.com>
Date: Wed Sep 18 16:55:49 2019
Change the way to detect mismatch between POJO and query
This fixes cursor mismatch warnings with expandProjection.
Bug: 140759491
Test: QueryMethodProcessorTest
Change-Id: I7659002e5e0d1ef60fc1af2a625c0c36da0664d8
M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt
M room/compiler/src/test/kotlin/androidx/room/processor/QueryMethodProcessorTest.kt
M room/compiler/src/test/kotlin/androidx/room/testing/TestProcessor.kt
https://android-review.googlesource.com/1123258
https://goto.google.com/android-sha1/b90079595f33f58fece04026a97faa0d243acdb1
Branch: androidx-master-dev
commit b90079595f33f58fece04026a97faa0d243acdb1
Author: Yuichi Araki <yaraki@google.com>
Date: Wed Sep 18 16:55:49 2019
Change the way to detect mismatch between POJO and query
This fixes cursor mismatch warnings with expandProjection.
Bug: 140759491
Test: QueryMethodProcessorTest
Change-Id: I7659002e5e0d1ef60fc1af2a625c0c36da0664d8
M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt
M room/compiler/src/test/kotlin/androidx/room/processor/QueryMethodProcessorTest.kt
M room/compiler/src/test/kotlin/androidx/room/testing/TestProcessor.kt
Description
The following Vulkan related problems were found on emulator 35.1.18 and emu-master-dev.
While running android emulators with big parallelism (10+ instances in parallel) i've noticed that occasionally there are errors like:
which do seem to affect the succeeding sessions. Most likely it could be a problem in the gpu vulkan library or smth else, but the issue is that I'm running the emulators withhttps://android.googlesource.com/platform/external/qemu/+/refs/heads/emu-master-dev/android/android-ui/modules/aemu-gl-init/src/android/opengl/emugl_config.cpp#246 )
-feature -Vulkan
to turn of Vulkan in order to be able to use snapshots, but nevertheless some Vulkan APIs are called (as seen from the error) which seems to cause issues at my scale. The problematic place seems to beemuglConfig_get_vulkan_hardware_gpu
inexternal/qemu/android/android-ui/modules/aemu-gl-init/src/android/opengl/emugl_config.cpp
(stack:
For now I've been able to get around this by renaming the
vulkan
folder underlib64
so that no Vulkan API calls are ever made (the flow just stops since it cannot load the library), but could it be possible to adjust this so that-feature -Vulkan
really disabled Vulkan.Another much smaller related issues is that even with
-feature -Vulkan
, the following lines are logged:This seems to come fromhttps://android.googlesource.com/platform/external/qemu/+/refs/heads/emu-master-dev/android/android-ui/modules/aemu-ui-window/src/android/main-common-ui.c#315 ) which does not seem to honour the feature flag (eventually Vulkan is not used since lower in the logic it does check the override state, but that could have been done at the very start to avoid the confusing log messages).
main-common-ui.c
(