OutlinedTextField Shrinks with Fixed Height on Focus [356905963]

Fixed

Bug

Status Update

No update yet.

Description

at...@vitapstudent.ac.in

created issue #1

Aug 2, 2024 05:07AM

Jetpack Compose version:

Jetpack Compose component(s) used: OutlinedTextField

Android Studio Build: Koala

Kotlin version:

Steps to Reproduce or Code Sample to Reproduce:

Create a simple Composable function containing an OutlinedTextField with a fixed height constraint (e.g., using Modifier.height(42.5.dp))
Run the app on an emulator.
Observe that the OutlinedTextField initially displays with the correct fixed height.
Tap on the OutlinedTextField to bring it into focus.
Notice that the height of the OutlinedTextField shrinks unexpectedly, despite the fixed height constraint.

Code

var email by remember { mutableStateOf("") }
                    OutlinedTextField(value = email, onValueChange = {email=it},
                        modifier = Modifier
                            .fillMaxWidth()
                            .requiredHeightIn(min = 42.5.dp, max = 42.5.dp)
                            .wrapContentHeight(Alignment.CenterVertically)
                            , // Set maximum height
                        label = { Text(text = "Enter Email", fontFamily = varelaRound, modifier =  Modifier) },
                        placeholder = { Text(text = "Enter Email", fontFamily = varelaRound) },
                        colors = TextFieldDefaults.outlinedTextFieldColors(
                            focusedBorderColor = Color(colorlolite),
                            unfocusedBorderColor = Color(colorlolite)
                        ),
                        singleLine = true,
                        shape = RoundedCornerShape(9.5.dp),
                    )

Stack trace (if applicable):

<add stack trace here>

Comments

an...@google.com <an...@google.com> Aug 6, 2024 04:01PM

Assigned to ma...@google.com.

ma...@google.com <ma...@google.com> Aug 6, 2024 05:21PM

Reassigned to ma...@google.com.

ma...@google.com <ma...@google.com> #2Nov 13, 2024 10:26PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit c60f33e229e31ab328ef6b59dab63b264954831c
Author: Alexandre Elias <aelias@google.com>
Date: Fri Jul 10 16:23:09 2020

Semantics no-op cleanups

Partly in response to lmr's broad code review, I did a pass of
superficial API/implementation cleanup. The main changes are:

- I changed each Boolean SemanticsProperty where false is equivalent to
not being present to take "Unit" instead. This is conceptually
clearer: it avoids questions like "can I cancel out a semantics from a
merged child by setting it to false?" Because "property = Unit" looks
weird, I also changed the style of these to "property()".

- I moved the Semantics id generator closer to where it's used, in
SemanticsModifierCore. I made it internal and an AtomicInt.
(Note that integer ids are heavily used in the Android
AccessibilityNodeInfo APIs so I can't simply remove them entirely.)

- I deleted dead code. Some examples include SemanticsHintOverrides,
a public API not connected to anything, and SemanticsPropertyKey
merge() open method which is never called. (In both cases I have
a different plan in mind for accessibility.)

Fixes: 145951226
Fixes: 145955412
Test: existing tests
Relnote: "Single-value semantics properties now use a calling style.
For example, 'semantics { hidden = true }' is now written as:
'semantics { hidden() }'."

Change-Id: Ic1afd12ea22c926babc9662f1804d80b33aa0cfc

M ui/integration-tests/benchmark/src/androidTest/java/androidx/ui/benchmark/test/LayoutNodeModifierBenchmark.kt
M ui/ui-core/api/0.1.0-dev15.txt
M ui/ui-core/api/current.txt
M ui/ui-core/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-core/api/public_plus_experimental_current.txt
M ui/ui-core/api/restricted_0.1.0-dev15.txt
M ui/ui-core/api/restricted_current.txt
M ui/ui-core/src/androidAndroidTest/kotlin/androidx/ui/graphics/vector/VectorTest.kt
M ui/ui-core/src/androidAndroidTest/kotlin/androidx/ui/semantics/SemanticsTests.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidActuals.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidComposeView.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidComposeViewAccessibilityDelegateCompat.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidPopup.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/Expect.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsConfiguration.kt
D ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsHintOverrides.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsModifier.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsNode.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsOwner.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsWrapper.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/semantics/SemanticsProperties.kt
M ui/ui-foundation/api/0.1.0-dev15.txt
M ui/ui-foundation/api/current.txt
M ui/ui-foundation/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-foundation/api/public_plus_experimental_current.txt
M ui/ui-foundation/api/restricted_0.1.0-dev15.txt
M ui/ui-foundation/api/restricted_current.txt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Clickable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Dialog.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Scroller.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/selection/Selectable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/selection/Toggleable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/semantics/FoundationSemanticsProperties.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ButtonTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/CardTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/CheckboxScreenshotTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/RadioButtonScreenshotTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ScaffoldTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/SnackbarTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/SurfaceTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ripple/RippleIndicationTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/textfield/TextFieldScreenshotTest.kt
M ui/ui-material/src/main/java/androidx/ui/material/AppBar.kt
M ui/ui-material/src/main/java/androidx/ui/material/TextFieldImpl.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/AssertsTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/CallSemanticsActionTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/ErrorMessagesTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/FindersTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/PrintToStringTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/ScrollToTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/TextActionsTest.kt
M ui/ui-test/src/main/java/androidx/ui/test/Actions.kt
M ui/ui-test/src/main/java/androidx/ui/test/Filters.kt
M ui/ui-text/api/0.1.0-dev15.txt
M ui/ui-text/api/current.txt
M ui/ui-text/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-text/api/public_plus_experimental_current.txt
M ui/ui-text/api/restricted_0.1.0-dev15.txt
M ui/ui-text/api/restricted_current.txt
M ui/ui-text/src/commonMain/kotlin/androidx/ui/text/CoreTextField.kt
M ui/ui-text/src/commonMain/kotlin/androidx/ui/text/TextSemanticsProperties.kt

https://android-review.googlesource.com/1360099

ma...@google.com <ma...@google.com> Dec 2, 2024 08:09PM

Accepted by ma...@google.com.

ap...@google.com <ap...@google.com> #3Dec 3, 2024 08:21PM

Project: platform/frameworks/support
Branch: androidx-main
Author: Max Alfonso-Ying <maxying@google.com>
Link: https://android-review.googlesource.com/3387683

Clean up text field size calculations

Expand for full commit details

Clean up text field size calculations 
 
Bug: b/356905963 
Test: existing unit tests 
Relnote: "Fix text field size modifiers sometimes not being followed." 
Change-Id: I98895ce82f45ba7c9df67cfa787c08f0460426db

Files:

M compose/material/material/src/commonMain/kotlin/androidx/compose/material/OutlinedTextField.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/TextField.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/TextFieldImpl.kt
M compose/material3/material3/src/commonMain/kotlin/androidx/compose/material3/OutlinedTextField.kt
M compose/material3/material3/src/commonMain/kotlin/androidx/compose/material3/TextField.kt

Hash: 93f37ea8ad82aa7e65743b36f08d6f4b404c6465
Date: Mon Dec 02 20:09:00 2024

ma...@google.com <ma...@google.com> Dec 3, 2024 09:03PM

Marked as fixed.

ap...@google.com <ap...@google.com> #4Dec 4, 2024 11:18PM

Project: platform/frameworks/support
Branch: androidx-main
Author: Max Alfonso-Ying <maxying@google.com>
Link: https://android-review.googlesource.com/3393057

Clean up text field size calculations

Expand for full commit details

Clean up text field size calculations 
 
Bug: b/356905963 
Test: existing unit tests 
Relnote: "Fix text field size modifiers sometimes not being followed." 
Change-Id: I90d4c690aabd1b4e35cb3934998a8c379671163f

Files:

M compose/material/material/src/commonMain/kotlin/androidx/compose/material/OutlinedTextField.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/TextField.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/TextFieldImpl.kt
M compose/material3/material3/src/commonMain/kotlin/androidx/compose/material3/OutlinedTextField.kt
M compose/material3/material3/src/commonMain/kotlin/androidx/compose/material3/TextField.kt

Hash: 3dfabb8562bd2ad420bc20b8a2dabf316dc6c562
Date: Wed Dec 04 20:44:55 2024

pr...@google.com <pr...@google.com> #5Dec 11, 2024 06:27PM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.compose.material:material:1.8.0-alpha07
androidx.compose.material:material-android:1.8.0-alpha07
androidx.compose.material:material-jvmstubs:1.8.0-alpha07
androidx.compose.material:material-linuxx64stubs:1.8.0-alpha07