Lint Warning when passing a data class Companion object to popBackStack [358095343]

Fixed

Bug

Status Update

No update yet.

Description

il...@google.com

created issue #1

Aug 7, 2024 03:36PM

Component used: Navigation

Version used: 2.8.0-beta06

Given a data class like:

@Serializable
data class ScreenBRoute(val arg: String)

If you do navigate(ScreenBRoute), you get a Lint warning, but you don't get the same kind of error when doing popBackStack(ScreenBRoute, inclusive = false).

Ideally, it would warn you and offer it to replace to popBackStack<ScreenBRoute>(inclusive = false).

Comments

jb...@google.com <jb...@google.com> #2Aug 28, 2024 03:25PM

Marked as fixed.

We have logic to match exact deep links, since you have a path argument maybe this doesn't fall within that case.

But definitely feel free to upload a pull request with tests for this particular test case and we can work it out there.

ap...@google.com <ap...@google.com> #3Aug 28, 2024 03:26PM

I've created a pull request on GitHub. Can you check it?

I not sure about names picked for test functions.

Issue 358095343

Description

Issue summary

Comments

jb...@google.com <jb...@google.com> #2Aug 28, 2024 03:25PM

ap...@google.com <ap...@google.com> #3Aug 28, 2024 03:26PM

Add comment

Issue metadata