Status Update
Comments
au...@google.com <au...@google.com> #2
Project: platform/frameworks/support
Branch: androidx-main
Author: Radha Nakade <
Link:
Migrate traffic from pixel2 to mediumphone on FTL emulators.
Expand for full commit details
Migrate traffic from pixel2 to mediumphone on FTL emulators.
Bug: 396715333
Test: ./gradlew emoji2:emoji2-emojipicker:ftlmediumphoneapi33
Change-Id: If5555443ca1a91479128e1bd6f4f909154c40ba2
Files:
- M
buildSrc/private/src/main/kotlin/androidx/build/FtlRunner.kt
Hash: c76f8094154101867327912e659ae47509755957
Date: Wed Feb 26 11:27:46 2025
au...@google.com <au...@google.com> #5
ap...@google.com <ap...@google.com> #6
Branch: androidx-main
commit f15b185af74be27ec0189f4fd735cac6d0be938f
Author: Aurimas Liutikas <aurimas@google.com>
Date: Thu Aug 08 14:38:55 2024
Make Room and Baseline Profile Gradle Plugins more project isolation compatible
- Move away from using Project.getProperties. This API tries to get
values not only from the current project, but also all the parent
projects. That means, it relies of parent projects to be configured
before the current project. In our case for detecting whether the sync
is running, these gradle properties are injected into every project,
so there is no need to check parent projects. This change moves to
providers.gradleProperty that only looks at properties for the current
project.
Test: ./gradlew bOS --dry-run -Dorg.gradle.unsafe.isolated-projects=true
-> report no longer has room and benchmark baseline profile
plugins flagged as violating project isolation for this invocation
Bug: 358128051
Change-Id: Id15e02c0e8a8a0bc0ff0aa3eaf5e555d0ccdfd2d
M benchmark/baseline-profile-gradle-plugin/src/main/kotlin/androidx/baselineprofile/gradle/utils/AgpPlugin.kt
M buildSrc/private/src/main/kotlin/androidx/build/AndroidXImplPlugin.kt
M room/room-gradle-plugin/src/main/java/androidx/room/gradle/RoomGradlePlugin.kt
ap...@google.com <ap...@google.com> #7
Branch: androidx-main
commit dfe6619d73dd7307b9398da18887df81b0dc16e7
Author: Aurimas Liutikas <aurimas@google.com>
Date: Wed Aug 28 12:20:45 2024
Clean up access to gradle properties
- Add a lint check to flag calls to hasProperty
- Stop using hasProperty and findProperty in benchmark gradle plugins
and buildSrc as these APIs by default look at parent projects,
instead move to using providers.gradleProperty that only looks at current project.
Bug: 358128051
Test: None
Change-Id: I2f4759f16e8a573a6cb3f4ac3e47107231887109
M benchmark/baseline-profile-gradle-plugin/lint-baseline.xml
M benchmark/baseline-profile-gradle-plugin/src/main/kotlin/androidx/baselineprofile/gradle/producer/BaselineProfileProducerPlugin.kt
M benchmark/baseline-profile-gradle-plugin/src/main/kotlin/androidx/baselineprofile/gradle/utils/AgpPlugin.kt
D benchmark/gradle-plugin/lint-baseline.xml
M benchmark/gradle-plugin/src/main/kotlin/androidx/benchmark/gradle/BenchmarkPlugin.kt
M buildSrc-tests/lint-baseline.xml
M buildSrc/private/src/main/kotlin/androidx/build/AndroidXRootImplPlugin.kt
M buildSrc/private/src/main/kotlin/androidx/build/FilteredAnchorTask.kt
M lint/lint-gradle/src/main/java/androidx/lint/gradle/DiscouragedGradleMethodDetector.kt
ap...@google.com <ap...@google.com> #8
Branch: androidx-main
commit e24bd852a76445b3cd7d51cb653d63f00008d46f
Author: Aurimas Liutikas <aurimas@google.com>
Date: Tue Aug 06 15:45:10 2024
Flag calls to Project.getRootProject, findProject and getParent
Usages of these are generally not project isolation safe.
Bug: 358128051
Test: ./gradlew buildSrc-tests:uLB
Change-Id: I251a6a14fee8a0d44223a791eec87259b239e949
M benchmark/benchmark-darwin-gradle-plugin/lint-baseline.xml
A benchmark/gradle-plugin/lint-baseline.xml
M buildSrc-tests/lint-baseline.xml
M inspection/inspection-gradle-plugin/lint-baseline.xml
M lint/lint-gradle/src/main/java/androidx/lint/gradle/DiscouragedGradleMethodDetector.kt
ap...@google.com <ap...@google.com> #9
Branch: androidx-main
commit 3a66e1e301f830ec071922398763973aaa1300e2
Author: Omar Ismail <omarismail@google.com>
Date: Wed Sep 18 13:03:39 2024
Move CreateYarnRc Task to root project to support project isolation
BUG:358128051
TESTED: Ran ./gradlew :annotation:annotation:wasmJsTests and it still printed the "Yarn packages will be fetched..." message
Change-Id: I357dd7a3198118366eb78d4e9002de22a25fa303
M buildSrc-tests/lint-baseline.xml
M buildSrc/private/src/main/kotlin/androidx/build/AndroidXMultiplatformExtension.kt
M buildSrc/private/src/main/kotlin/androidx/build/AndroidXRootImplPlugin.kt
M development/build_log_simplifier/messages.ignore
ap...@google.com <ap...@google.com> #10
Branch: androidx-main
commit 08f94ae6d581718d9e7b2438b4039f6c5c67f16e
Author: Aurimas Liutikas <aurimas@google.com>
Date: Thu Sep 19 21:40:37 2024
Remove exclude.espresso
It was originally added when gradle could not handle prebuilt
dependencies depending on androidx libraries that were also added
as project dependencies.
Bug: 358128051
Test: ./gradlew assebleAndroidTest -> success
Change-Id: Icacf16bc4cafdd54c77ff6f04a749e148eac66e5
M activity/activity/build.gradle
M appcompat/appcompat-resources/build.gradle
M appcompat/appcompat/build.gradle
M browser/browser/build.gradle
M build.gradle
D buildSrc/dependencies.gradle
M contentpager/contentpager/build.gradle
M coordinatorlayout/coordinatorlayout/build.gradle
M core/core-animation-integration-tests/testapp/build.gradle
M core/core-animation/build.gradle
M core/core/build.gradle
M drawerlayout/drawerlayout/build.gradle
M dynamicanimation/dynamicanimation-ktx/build.gradle
M dynamicanimation/dynamicanimation/build.gradle
M emoji/emoji/build.gradle
M emoji2/emoji2-bundled/build.gradle
M emoji2/emoji2-emojipicker/build.gradle
M emoji2/emoji2-views-helper/build.gradle
M emoji2/emoji2-views/build.gradle
M emoji2/emoji2/build.gradle
M fragment/fragment-compose/build.gradle
M fragment/fragment/build.gradle
M gridlayout/gridlayout/build.gradle
M heifwriter/heifwriter/build.gradle
M leanback/leanback-grid/build.gradle
M leanback/leanback-paging/build.gradle
M leanback/leanback-tab/build.gradle
M leanback/leanback/build.gradle
M loader/loader-ktx/build.gradle
M loader/loader/build.gradle
M media/media/build.gradle
M mediarouter/mediarouter/build.gradle
M metrics/metrics-performance/build.gradle
M percentlayout/percentlayout/build.gradle
M playground-common/playground-build.gradle
M preference/preference/build.gradle
M recyclerview/recyclerview-selection/build.gradle
M recyclerview/recyclerview/build.gradle
M slice/slice-benchmark/build.gradle
M slice/slice-test/build.gradle
M slice/slice-view/build.gradle
M slidingpanelayout/slidingpanelayout/build.gradle
M swiperefreshlayout/swiperefreshlayout/build.gradle
M testutils/testutils-espresso/build.gradle
M transition/transition/build.gradle
M vectordrawable/vectordrawable-animated/build.gradle
M vectordrawable/vectordrawable-seekable/build.gradle
M viewpager/viewpager/build.gradle
M viewpager2/viewpager2/build.gradle
M wear/wear/build.gradle
M webkit/integration-tests/instrumentation/build.gradle
M webkit/integration-tests/testapp/build.gradle
M webkit/webkit/build.gradle
M window/window-demos/demo/build.gradle
ap...@google.com <ap...@google.com> #11
Project: platform/frameworks/support
Branch: androidx-main
Author: Aurimas Liutikas <
Link:
Clean up project isolation violations for androidx { samples(project()) }
Expand for full commit details
Clean up project isolation violations for androidx { samples(project()) }
Adds a `project(name: String): Project` to AndroidXExtension.
Without this method, the call above results into a call to the parent object, because
AndroidXExtension has `val project: Project`, which from groovy `project` call within
`androidx` block tries retrieves that project object and calls to look for :foo property
on it, then checking all the parents for it
Bug: 358128051
Test: ./gradlew bOS -Dorg.gradle.unsafe.isolated-projects=true ->
warnings about samples calls are gone
Change-Id: Ide2746b7dddcfd10e21e9e2ad870c899d23f7ec5
Files:
- M
buildSrc/public/src/main/kotlin/androidx/build/AndroidXExtension.kt
Hash: 938c980a2e2b9be37e242eba4379e5ce3d47a7b9
Date: Mon Sep 30 02:17:21 2024
ap...@google.com <ap...@google.com> #12
Project: platform/frameworks/support
Branch: androidx-main
Author: Aurimas Liutikas <
Link:
Clean up project isolation violations for androidxMultiplatform
Expand for full commit details
Clean up project isolation violations for androidxMultiplatform
androidXMultiplatform {
sourceSets {
commonMain {
dependencies {
api(project(":foo"))
}
}
}
}
Adds a `project(name: String): Project` to AndroidXMultiplatformExtension.
Without this method, the call above results into a call to the parent object, because
AndroidXMultiplatformExtension has `val project: Project`, which from groovy `project` call within
`androidxMultiplatform` block tries retrieves that project object and calls to look for :foo property
on it, then checking all the parents for it
Bug: 358128051
Test: ./gradlew bOS -Dorg.gradle.unsafe.isolated-projects=true ->
warnings about samples calls are gone
Change-Id: Ie7de22a5e8413fd2b8672ccbc1777373c549d0be
Files:
- M
buildSrc/private/src/main/kotlin/androidx/build/AndroidXMultiplatformExtension.kt
Hash: a7b155768e9bc1f10cc7beb7bd13303a52384184
Date: Wed Oct 02 06:04:12 2024
ap...@google.com <ap...@google.com> #13
Project: platform/frameworks/support
Branch: androidx-main
Author: Aurimas Liutikas <
Link:
Upgrade to shadow plugin 8.3.3
Expand for full commit details
Upgrade to shadow plugin 8.3.3
Pulls in a fix https://github.com/GradleUp/shadow/issues/907
to avoid project isolation violations
Bug: 358128051
Test: ./gradlew bOS --dry-run
Change-Id: Ib5f62c6e5616fddb0eef6849b3291fc38339c1b1
Files:
- M
buildSrc/public/src/main/kotlin/androidx/build/BundleInsideHelper.kt
- M
gradle/libs.versions.toml
- M
gradle/verification-keyring.keys
- M
gradle/verification-metadata.xml
- M
inspection/inspection-gradle-plugin/src/main/kotlin/androidx/inspection/gradle/ShadowDependenciesTask.kt
Hash: 9f60e09516b8c3c30e591e011203de3708b59c9a
Date: Wed Oct 02 04:54:42 2024
ap...@google.com <ap...@google.com> #14
Project: platform/frameworks/support
Branch: androidx-main
Author: Aurimas Liutikas <
Link:
Disable incompatible build logic when IP is enabled
Expand for full commit details
Disable incompatible build logic when IP is enabled
Gradle is currently missing APIs for aggregating data and artifacts
across multiple projects in a clean way that is project isolation
compatible (https://github.com/gradle/gradle/issues/29403).
Conditionally disabling this allows us to continue addressing other
issues within androidx build as we make progress on project isolation.
Bug: 358128051
Test: ALLOW_PUBLIC_REPOS=true PROJECT_PREFIX=:core:core ./gradlew bOS --dry-run -Dorg.gradle.unsafe.isolated-projects=true
Change-Id: I043be49189f79eb359d7162a8da6937ea7bd7285
Files:
- M
buildSrc/private/src/main/kotlin/androidx/build/AndroidXImplPlugin.kt
- M
buildSrc/private/src/main/kotlin/androidx/build/AndroidXRootImplPlugin.kt
- M
buildSrc/private/src/main/kotlin/androidx/build/Release.kt
- M
buildSrc/private/src/main/kotlin/androidx/build/buildInfo/CreateLibraryBuildInfoFileTask.kt
- M
buildSrc/private/src/main/kotlin/androidx/build/testConfiguration/OwnersService.kt
- M
buildSrc/private/src/main/kotlin/androidx/build/testConfiguration/TestSuiteConfiguration.kt
- M
buildSrc/public/src/main/kotlin/androidx/build/AndroidXExtension.kt
- A
buildSrc/public/src/main/kotlin/androidx/build/ProjectIsolation.kt
Hash: 326d9a28a4f0bcd1fe3fca694d3ca899d2c0b211
Date: Tue Oct 01 12:45:31 2024
ap...@google.com <ap...@google.com> #15
Project: platform/frameworks/support
Branch: androidx-main
Author: Aurimas Liutikas <
Link:
Remove usage of root project in ProjectParser
Expand for full commit details
Remove usage of root project in ProjectParser
Services are global to the project, so there is no need to reach to the
root project to get a service instance.
Test: ./gradlew bOS --dry-run
Bug: 358128051
Change-Id: I027acf126ac51f1f5b07f16396607c430070bf5d
Files:
- M
buildSrc-tests/lint-baseline.xml
- M
buildSrc/private/src/main/kotlin/androidx/build/ProjectParser.kt
Hash: 5317aefa1655aaad680ba3d094949bf687477b44
Date: Fri Dec 13 13:11:11 2024
ap...@google.com <ap...@google.com> #17
Project: platform/frameworks/support
Branch: androidx-main
Author: Aurimas Liutikas <
Link:
Migrate inspection-gradle-plugin to build.gradle.kts
Expand for full commit details
Migrate inspection-gradle-plugin to build.gradle.kts
This allows us to remove findGradleKotlinDsl that is not isolated
project compatible.
Also fixes an assumption in AndroidXImplPlugin that all projects use
build.gradle for their build file.
Bug: 358128051
Test: ./gradlew inspection:inspection-gradle-plugin:test
Change-Id: Ib17ba3b15928b76a08d3fc6c8c85fe71a1e203ec
Files:
- M
buildSrc/private/src/main/kotlin/androidx/build/AndroidXImplPlugin.kt
- M
inspection/inspection-gradle-plugin/build.gradle.kts
Hash: 916becb0303c91e846c84f6c382f7e157c8ed4fb
Date: Wed Mar 05 14:36:33 2025
Description
Make androidx build Gradle project isolation compatible as Gradle is looking to enable parallel project configuration in CLI.