API request: allow changing SegmentedButton padding [358414376]

Fixed

Feature Request

Status Update

No update yet.

Description

st...@gmail.com

created issue #1

Aug 12, 2024 03:13PM

Jetpack Compose version: (BOM) 2024.06.00
Material Library Version: have only tested with M3
Material Compose component used: SingleChoiceSegmentedButtonRow
Android Studio Build: Build #AI-241.18034.62.2411.12169540, built on August 1, 2024
Kotlin version: 2.0.0

Code Sample to Reproduce:

SingleChoiceSegmentedButtonRow(modifier = modifier) {
    for ((index, choice) in listOf("Weekly", "Monthly", "Yearly", "Custom").withIndex()) {
        SegmentedButton(
            selected = index == 0,
            shape = RectangleShape,
            label = {
                Text(choice, maxLines = 1, overflow = TextOverflow.Ellipsis)
            },
            onClick = {},
        )
    }
}

For large font scales, the SegmentedButtons in the sample above show text truncation (see attachments). To increase the range of font scales for which truncation is not needed, I would like to be able to reduce the horizontal padding for SegmentedButton. However, that is not possible; 12dp of padding is hard-coded into the library-private Composable SegmentedButtonContent. So, to reduce padding with the current APIs, I would need to:

Duplicate and edit SingleChoiceSegmentedButtonRowScope.SegmentedButton, which requires that I
Duplicate and edit SegmentedButtonContent, which requires that I
Inline the private value of OutlinedSegmentedButtonTokens.LabelTextFont and
Duplicate SegmentedButtonContentMeasurePolicy, which requires that I
Inline the private values of SegmentedButton.IconSpacing and MotionTokens.DurationMedium3.
etc.

It would be helpful if SegmentedButton's API allowed simpler editing (or removal) of the hard-coded minimum horizontal padding.

Separately, it would be helpful in general if the Material libraries didn't make so many APIs internal/private, as doing so hinders our ability to make small edits to Material components while benefiting from future updates to the library code.

Thank you for reading and considering this!

20240812_000247.png

94 KB

View

Download

Comments

st...@gmail.com <st...@gmail.com> #2Aug 12, 2024 04:44PM

Project: platform/frameworks/support
Branch: androidx-main

commit a330c0d3bcdd41326f37968a60e6084ad4a2e32c
Author: Chet Haase <chet@google.com>
Date: Wed Jul 05 07:26:46 2023

Convert APIs using PointF to use Float instead

PointF is a convenient mechanism for passing around x.y values
representing 2D points. But there are downsides, including:
- Converting to PointF: You may not have the data in PointF form
to begin with, so using an API which takes PointF requires converting
the data to that form (including allocating a PointF object every time)
- Mutability: Point structures can be mutated internally, causing
unpredictability in what that mutation means. Should the library
react to those changes? Ignore them? Do defensive copies (requiring
even more allocations)? Using primitive types like Float make the
behavior more obvious (by making the data inherently immutable).
- Allocations: Whenever we use object types, there are necessarily
allocations on the Java heap for them. This puts pressure on the GC
at both allocation and collection time. Given the amount of points
being passed around (especially at morph creation time, when curves
are being split and created), this causes a lot of PointF objects to
be allocated (even temporarily). Using Float avoids that problem.

Also fixed bug with unclosed paths causing discontinuity at the
start/end point.

Bug: 276466399
Bug: 290254314
Test: integration and unit tests pass
Relnote: PointF parameters changed to Float pairs
Change-Id: Id4705d27c7be31b26ade8186b99fffe2e2f8450e

M graphics/graphics-shapes/api/current.txt
M graphics/graphics-shapes/api/restricted_current.txt
M graphics/graphics-shapes/src/androidTest/java/androidx/graphics/shapes/CubicShapeTest.kt
M graphics/graphics-shapes/src/androidTest/java/androidx/graphics/shapes/CubicTest.kt
M graphics/graphics-shapes/src/androidTest/java/androidx/graphics/shapes/PolygonMeasureTest.kt
M graphics/graphics-shapes/src/androidTest/java/androidx/graphics/shapes/PolygonTest.kt
M graphics/graphics-shapes/src/androidTest/java/androidx/graphics/shapes/RoundedPolygonTest.kt
M graphics/graphics-shapes/src/androidTest/java/androidx/graphics/shapes/ShapesTest.kt
M graphics/graphics-shapes/src/androidTest/java/androidx/graphics/shapes/TestUtils.kt
M graphics/graphics-shapes/src/main/java/androidx/graphics/shapes/Cubic.kt
M graphics/graphics-shapes/src/main/java/androidx/graphics/shapes/CubicShape.kt
M graphics/graphics-shapes/src/main/java/androidx/graphics/shapes/FeatureMapping.kt
M graphics/graphics-shapes/src/main/java/androidx/graphics/shapes/FloatMapping.kt
M graphics/graphics-shapes/src/main/java/androidx/graphics/shapes/Morph.kt
M graphics/graphics-shapes/src/main/java/androidx/graphics/shapes/PolygonMeasure.kt
M graphics/graphics-shapes/src/main/java/androidx/graphics/shapes/RoundedPolygon.kt
M graphics/graphics-shapes/src/main/java/androidx/graphics/shapes/Shapes.kt
M graphics/graphics-shapes/src/main/java/androidx/graphics/shapes/Utils.kt
M graphics/integration-tests/testapp-compose/src/main/java/androidx/graphics/shapes/testcompose/DebugDraw.kt
M graphics/integration-tests/testapp-compose/src/main/java/androidx/graphics/shapes/testcompose/ShapeEditor.kt
M graphics/integration-tests/testapp/src/main/java/androidx/graphics/shapes/test/MaterialShapes.kt

https://android-review.googlesource.com/2649119

co...@google.com <co...@google.com> Sep 10, 2024 07:57PM

Accepted by ma...@google.com.

ap...@google.com <ap...@google.com> #3Sep 18, 2024 03:32PM

PointF was the main (possibly only) mutability issue, marking this as fixed

ma...@google.com <ma...@google.com> Sep 18, 2024 03:45PM

Marked as fixed.

st...@gmail.com <st...@gmail.com> #4Sep 20, 2024 08:15PM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.graphics:graphics-shapes:1.0.0-alpha04

pr...@google.com <pr...@google.com> #5Oct 2, 2024 05:37PM