Fixed
Status Update
Comments
st...@gmail.com <st...@gmail.com> #2
Project: platform/frameworks/support
Branch: androidx-main
Author: Louis Pullen-Freilich <
Link:
Adds OverscrollEffect#withoutDrawing and OverscrollEffect#withoutEventHandling
Expand for full commit details
Adds OverscrollEffect#withoutDrawing and OverscrollEffect#withoutEventHandling
These APIs allow overscroll to have events dispatched to it by one component, and rendered in a separate component.
Fixes: b/266550551
Fixes: b/204650733
Fixes: b/255554340
Fixes: b/229537244
Test: OverscrollTest
Relnote: "Adds OverscrollEffect#withoutDrawing and OverscrollEffect#withoutEventHandling APIs - these APIs create a wrapped instance of the provided overscroll effect that doesn't draw / handle events respectively, which allows for rendering overscroll in a separate component from the component that is dispatching events. For example, disabling drawing the overscroll inside a lazy list, and then drawing the overscroll separately on top / elsewhere."
Change-Id: Idbb3d91546b49c1987a041f959bce4b2b09a9f61
Files:
- M
compose/foundation/foundation/api/current.txt
- M
compose/foundation/foundation/api/restricted_current.txt
- M
compose/foundation/foundation/integration-tests/foundation-demos/src/main/java/androidx/compose/foundation/demos/OverscrollDemo.kt
- M
compose/foundation/foundation/samples/src/main/java/androidx/compose/foundation/samples/OverscrollSample.kt
- M
compose/foundation/foundation/src/androidInstrumentedTest/kotlin/androidx/compose/foundation/OverscrollTest.kt
- M
compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/Overscroll.kt
Hash: f64e25b7a473c757d080521e7dd97b3f6670f60d
Date: Fri Nov 01 18:43:56 2024
co...@google.com <co...@google.com>
ap...@google.com <ap...@google.com> #3
The following release(s) address this bug.It is possible this bug has only been partially addressed:
androidx.compose.foundation:foundation:1.8.0-alpha06
androidx.compose.foundation:foundation-android:1.8.0-alpha06
androidx.compose.foundation:foundation-jvmstubs:1.8.0-alpha06
androidx.compose.foundation:foundation-linuxx64stubs:1.8.0-alpha06
ma...@google.com <ma...@google.com>
st...@gmail.com <st...@gmail.com> #4
Appreciate it, thank you!
pr...@google.com <pr...@google.com> #5
The following release(s) address this bug.It is possible this bug has only been partially addressed:
androidx.compose.material3:material3:1.4.0-alpha01
androidx.compose.material3:material3-android:1.4.0-alpha01
Description
Jetpack Compose version: (BOM)
2024.06.00
Material Library Version: have only tested with M3
Material Compose component used:
SingleChoiceSegmentedButtonRow
Android Studio Build:
Build #AI-241.18034.62.2411.12169540, built on August 1, 2024
Kotlin version:
2.0.0
Code Sample to Reproduce:
For large font scales, the
SegmentedButton
s in the sample above show text truncation (see attachments). To increase the range of font scales for which truncation is not needed, I would like to be able to reduce the horizontal padding forSegmentedButton
. However, that is not possible; 12dp of padding is hard-coded into the library-private ComposableSegmentedButtonContent
. So, to reduce padding with the current APIs, I would need to:SingleChoiceSegmentedButtonRowScope.SegmentedButton
, which requires that ISegmentedButtonContent
, which requires that IOutlinedSegmentedButtonTokens.LabelTextFont
andSegmentedButtonContentMeasurePolicy
, which requires that ISegmentedButton.IconSpacing
andMotionTokens.DurationMedium3
.It would be helpful if
SegmentedButton
's API allowed simpler editing (or removal) of the hard-coded minimum horizontal padding.Separately, it would be helpful in general if the Material libraries didn't make so many APIs internal/private, as doing so hinders our ability to make small edits to Material components while benefiting from future updates to the library code.
Thank you for reading and considering this!