[IP] projectOrArtifact is not isolated project safe [358448803]

Assigned

Internal Cleanup

Status Update

No update yet.

Description

au...@google.com

created issue #1

Aug 8, 2024 11:05PM

Project `:activity:activity-compose-lint` cannot dynamically look up a method in the parent project `:activity`

org.gradle.api.InvalidUserCodeException: Project ':activity:activity-compose-lint' cannot dynamically look up a method in the parent project ':activity'
	at org.gradle.internal.configuration.problems.DefaultProblemFactory$problem$1$build$diagnostics$1.get(DefaultProblemFactory.kt:89)
	at org.gradle.internal.configuration.problems.DefaultProblemFactory$problem$1$build$diagnostics$1.get(DefaultProblemFactory.kt:89)
	at org.gradle.internal.problems.DefaultProblemDiagnosticsFactory$DefaultProblemStream.getImplicitThrowable(DefaultProblemDiagnosticsFactory.java:165)
	at org.gradle.internal.problems.DefaultProblemDiagnosticsFactory$DefaultProblemStream.forCurrentCaller(DefaultProblemDiagnosticsFactory.java:154)
	at org.gradle.internal.configuration.problems.DefaultProblemFactory$problem$1.build(DefaultProblemFactory.kt:89)
	at org.gradle.internal.cc.impl.CrossProjectModelAccessTrackingParentDynamicObject.maybeReportProjectIsolationViolation(CrossProjectModelAccessTrackingParentDynamicObject.kt:137)
	at org.gradle.internal.cc.impl.CrossProjectModelAccessTrackingParentDynamicObject.onAccess(CrossProjectModelAccessTrackingParentDynamicObject.kt:109)
	at org.gradle.internal.cc.impl.CrossProjectModelAccessTrackingParentDynamicObject.tryInvokeMethod(CrossProjectModelAccessTrackingParentDynamicObject.kt:47)
	at org.gradle.internal.metaobject.CompositeDynamicObject.tryInvokeMethod(CompositeDynamicObject.java:99)
	at org.gradle.internal.extensibility.MixInClosurePropertiesAsMethodsDynamicObject.tryInvokeMethod(MixInClosurePropertiesAsMethodsDynamicObject.java:38)
	at org.gradle.groovy.scripts.BasicScript$ScriptDynamicObject.tryInvokeMethod(BasicScript.java:138)
	at org.gradle.internal.metaobject.ConfigureDelegate.invokeMethod(ConfigureDelegate.java:79)
	at org.codehaus.groovy.runtime.metaclass.ClosureMetaClass.invokeOnDelegationObjects(ClosureMetaClass.java:408)
	at org.codehaus.groovy.runtime.metaclass.ClosureMetaClass.invokeMethod(ClosureMetaClass.java:348)
	at org.codehaus.groovy.runtime.callsite.PogoMetaClassSite.callCurrent(PogoMetaClassSite.java:61)
	at org.codehaus.groovy.runtime.callsite.CallSiteArray.defaultCallCurrent(CallSiteArray.java:51)
	at org.codehaus.groovy.runtime.callsite.AbstractCallSite.callCurrent(AbstractCallSite.java:171)
	at org.codehaus.groovy.runtime.callsite.AbstractCallSite.callCurrent(AbstractCallSite.java:185)
	at build_avoe93mcdmujimgtq0jnox5gd$_run_closure1.doCall$original(/usr/local/google/home/aurimas/Code/androidx-main/frameworks/support/activity/activity-compose-lint/build.gradle:37)

Comments

ga...@gmail.com <ga...@gmail.com> #2Aug 11, 2024 04:21PM

Project: platform/frameworks/support
Branch: androidx-main
Author: Radha Nakade <radhanakade@google.com>
Link: https://android-review.googlesource.com/3510337

Migrate traffic from pixel2 to mediumphone on FTL emulators.

Expand for full commit details

Migrate traffic from pixel2 to mediumphone on FTL emulators. 
 
Bug: 396715333 
 
Test: ./gradlew emoji2:emoji2-emojipicker:ftlmediumphoneapi33 
Change-Id: If5555443ca1a91479128e1bd6f4f909154c40ba2

Files:

M buildSrc/private/src/main/kotlin/androidx/build/FtlRunner.kt

Hash: c76f8094154101867327912e659ae47509755957
Date: Wed Feb 26 11:27:46 2025

ap...@google.com <ap...@google.com> #3Aug 30, 2024 06:15PM

Project: platform/frameworks/support
Branch: androidx-main

commit 6fee22192f37ae36fda239df233c7abfa891abd2
Author: Aurimas <aurimas@liutikas.net>
Date: Fri Aug 30 00:38:08 2024

[GH] Remove uses of projectOrArtifact in androidx

projectOrArtifact has already been replacing playground usages to project since

r.android.com/2924929 so these usage do not do anything already.

Test: github actions
Bug: 358448803

This is an imported pull request from

https://github.com/androidx/androidx/pull/694.

Resolves #694
Github-Pr-Head-Sha: 6a9acb0ae64150a63cb9fbca55a65dc6cc62ccfc
GitOrigin-RevId: df7eca6bbcdea48d5546a038b92086714ce175af
Change-Id: I8317a3a1067232b15601fe51985c88d0ba977822

M activity/activity-compose-lint/build.gradle
M activity/activity-compose/build.gradle
M activity/activity-compose/samples/build.gradle
M activity/integration-tests/baselineprofile/build.gradle
M appcompat/appcompat-lint/integration-tests/build.gradle
M appcompat/integration-tests/receive-content-testapp/build.gradle
M compose/benchmark-utils/build.gradle
M compose/integration-tests/demos/common/build.gradle
M compose/material/material-navigation/build.gradle
M compose/material3/material3/build.gradle
M compose/runtime/runtime-lint/build.gradle
M compose/runtime/runtime-livedata/build.gradle
M compose/runtime/runtime-livedata/samples/build.gradle
M compose/runtime/runtime-rxjava2/build.gradle
M compose/runtime/runtime-rxjava2/samples/build.gradle
M compose/runtime/runtime-rxjava3/build.gradle
M compose/runtime/runtime-rxjava3/samples/build.gradle
M compose/runtime/runtime-saveable-lint/build.gradle
M compose/runtime/runtime-test-utils/build.gradle
M compose/runtime/runtime/compose-runtime-benchmark/build.gradle
M compose/runtime/runtime/integration-tests/build.gradle
M compose/test-utils/build.gradle
M core/core-graphics-integration-tests/testapp/build.gradle
M core/core-splashscreen/build.gradle
M core/core-splashscreen/samples/build.gradle
M core/core/build.gradle
M core/haptics/haptics/build.gradle
M datastore/datastore-compose-samples/build.gradle
M emoji2/emoji2-benchmark/build.gradle
M fragment/fragment/build.gradle
M fragment/integration-tests/testapp/build.gradle
M glance/glance-appwidget-testing/build.gradle
M glance/glance-appwidget/build.gradle
M hilt/hilt-navigation-compose/build.gradle
M hilt/hilt-navigation-compose/samples/build.gradle
M lifecycle/lifecycle-runtime-compose/build.gradle
M lifecycle/lifecycle-runtime-compose/samples/build.gradle
M lifecycle/lifecycle-runtime-testing-lint/build.gradle
M lifecycle/lifecycle-viewmodel-compose-lint/build.gradle
M lifecycle/lifecycle-viewmodel-compose/build.gradle
M lifecycle/lifecycle-viewmodel-compose/samples/build.gradle
M lifecycle/lifecycle-viewmodel-savedstate/build.gradle
M loader/loader/build.gradle
M navigation/integration-tests/testapp/build.gradle
M navigation/navigation-common-lint/build.gradle
M navigation/navigation-compose-lint/build.gradle
M navigation/navigation-compose/build.gradle
M navigation/navigation-compose/samples/build.gradle
M navigation/navigation-runtime-lint/build.gradle
M navigation/navigation-runtime/build.gradle
M navigation/navigation-safe-args-generator/build.gradle
M paging/integration-tests/testapp/build.gradle
M paging/paging-compose/build.gradle
M paging/paging-compose/integration-tests/paging-demos/build.gradle
M paging/paging-runtime/build.gradle
M profileinstaller/profileinstaller-benchmark/build.gradle
M room/benchmark/build.gradle
M room/integration-tests/testapp/build.gradle
M room/room-compiler/build.gradle
M samples/SupportLeanbackDemos/build.gradle
M savedstate/savedstate/build.gradle
M testutils/testutils-lifecycle/build.gradle
M testutils/testutils-navigation/build.gradle
M wear/benchmark/integration-tests/macrobenchmark-target/build.gradle
M work/integration-tests/testapp/build.gradle
M work/work-benchmark/build.gradle
M work/work-runtime/build.gradle

https://android-review.googlesource.com/3250911

ap...@google.com <ap...@google.com> #4Mar 5, 2025 04:09PM

Project: platform/frameworks/support
Branch: androidx-main
Author: Aurimas Liutikas <aurimas@google.com>
Link: https://android-review.googlesource.com/3525059

Add more fixes for Gradle Project Isolation

Expand for full commit details

Add more fixes for Gradle Project Isolation 
 
- Fix DarwinBenchmarkPlugin to not use findProperty that reaches out 
  to parent projects 
- Disable wasm and js targets in KMP projects when project isolation is 
  enabled (currently not compatible) 
- Moved to ext.registerPrepareSqliteSourcesTask in 
  sqlite-bundled/build.gradle to make sure property search is not used 
  accessing parent projects 
- Stop passing in root project to get distribution directory in 
  tracing-perfetto-handshake 
- Stop passing root project in car/app/app to get outDir 
- Do not use rootProject.projectDir in collection-benchmark and benchmark-darwin-samples 
  as accessing rootProject is unsafe, use rootDir instead. 
 
Test: ./gradlew projects -Dorg.gradle.unsafe.isolated-projects=true -Dorg.gradle.internal.isolated-projects.configure-on-demand.tasks=true 
      List of failures slighly shorter 
Bug: 358448803 
Change-Id: I8d294ea96b01a6edd8495574516102b68ec2fb74

Files:

M benchmark/benchmark-darwin-gradle-plugin/src/main/kotlin/androidx/benchmark/darwin/gradle/DarwinBenchmarkPlugin.kt
M benchmark/benchmark-darwin-samples/build.gradle
M buildSrc/private/src/main/kotlin/androidx/build/AndroidXMultiplatformExtension.kt
M car/app/app/build.gradle
M collection/collection-benchmark/build.gradle
M sqlite/sqlite-bundled/build.gradle
M tracing/tracing-perfetto-handshake/build.gradle

Hash: 39b969d1528d0870a7054a4e23041f3d9a0a0038
Date: Tue Mar 04 18:26:17 2025

ap...@google.com <ap...@google.com> #5Mar 5, 2025 11:09PM

Project: platform/frameworks/support
Branch: androidx-main
Author: Aurimas Liutikas <aurimas@google.com>
Link: https://android-review.googlesource.com/3528516

Make projectOrArtifact Gradle Isolated Projects safe.

Expand for full commit details

Make projectOrArtifact Gradle Isolated Projects safe. 
 
In groovy, a call to projectOrArtifact triggers a property search in the 
project and all of its ancestors, before it finally tries ext["projectOrArtifact"]. 
This causes a project isolation violation. 
 
Moving to androidx.projectOrArtifact avoids reaching out to parent projects. 
 
Note, it is still broken in playground, that will have to be follow up 
work. 
 
Bug: 358448803 
Test: ./gradlew projects -Dorg.gradle.unsafe.isolated-projects=true -Dorg.gradle.internal.isolated-projects.configure-on-demand.tasks=true 
      fewer warnings in the report 
Change-Id: I5321069b22f15de30a2b2c46f1c9f60dd9f00def

Files:

M activity/integration-tests/baselineprofile/build.gradle
M appcompat/appcompat-benchmark/build.gradle
M buildSrc-tests/lint-baseline.xml
M buildSrc/private/src/main/kotlin/androidx/build/AndroidXImplPlugin.kt
M buildSrc/private/src/main/kotlin/androidx/build/AndroidXPlaygroundRootImplPlugin.kt
M buildSrc/private/src/main/kotlin/androidx/build/VerifyDependencyVersionsTask.kt
M buildSrc/public/src/main/kotlin/androidx/build/AndroidXExtension.kt
A buildSrc/public/src/main/kotlin/androidx/build/ProjectOrArtifact.kt
M collection/collection-benchmark/build.gradle
M compose/benchmark-utils/build.gradle
M compose/runtime/runtime/compose-runtime-benchmark/build.gradle
M datastore/datastore-benchmark/build.gradle
M navigation/navigation-benchmark/build.gradle
M room/benchmark/build.gradle
M savedstate/savedstate/build.gradle
M work/work-benchmark/build.gradle

Hash: 5b08851a5558eff1c74bd61932b2c987891e943a
Date: Wed Mar 05 10:37:48 2025

au...@google.com <au...@google.com> #6Mar 6, 2025 12:16AM

The AOSP usage of this is fixed. Playground still needs fixing as it uses rootProject to locate projects.

Issue 358448803

Description

Issue summary

Comments

ga...@gmail.com <ga...@gmail.com> #2Aug 11, 2024 04:21PM

ap...@google.com <ap...@google.com> #3Aug 30, 2024 06:15PM

ap...@google.com <ap...@google.com> #4Mar 5, 2025 04:09PM

ap...@google.com <ap...@google.com> #5Mar 5, 2025 11:09PM

au...@google.com <au...@google.com> #6Mar 6, 2025 12:16AM

Add comment

Issue metadata