Fixed
Status Update
Comments
se...@google.com <se...@google.com>
se...@google.com <se...@google.com>
ap...@google.com <ap...@google.com> #2
See also
se...@google.com <se...@google.com>
na...@google.com <na...@google.com> #3
Project: platform/frameworks/support
Branch: androidx-main
commit 1a48f33d2d01d135a0d647f83b1baaac10499ef0
Author: Chris Craik <ccraik@google.com>
Date: Tue Jan 25 12:35:23 2022
Clarify FrameTimingMetric names
Fixes: 216337830
Relnote: "Renamed FrameCpuTime -> FrameDurationCpu, FrameUiTime -> FrameDurationUi to clarify these are durations, not timestamps, and to match prefixes."
Test: ./gradlew benchmark:benchmark-common:cC
Test: TrivialListScrollBenchmark
Change-Id: I0eba35542431905ab926f5dc7db4ab6e292fde69
M benchmark/benchmark-macro/src/main/java/androidx/benchmark/macro/Metric.kt
M benchmark/benchmark-macro/src/main/java/androidx/benchmark/macro/perfetto/FrameTimingQuery.kt
M benchmark/benchmark-macro/src/androidTest/java/androidx/benchmark/macro/perfetto/FrameTimingQueryTest.kt
https://android-review.googlesource.com/1960660
Branch: androidx-main
commit 1a48f33d2d01d135a0d647f83b1baaac10499ef0
Author: Chris Craik <ccraik@google.com>
Date: Tue Jan 25 12:35:23 2022
Clarify FrameTimingMetric names
Fixes: 216337830
Relnote: "Renamed FrameCpuTime -> FrameDurationCpu, FrameUiTime -> FrameDurationUi to clarify these are durations, not timestamps, and to match prefixes."
Test: ./gradlew benchmark:benchmark-common:cC
Test: TrivialListScrollBenchmark
Change-Id: I0eba35542431905ab926f5dc7db4ab6e292fde69
M benchmark/benchmark-macro/src/main/java/androidx/benchmark/macro/Metric.kt
M benchmark/benchmark-macro/src/main/java/androidx/benchmark/macro/perfetto/FrameTimingQuery.kt
M benchmark/benchmark-macro/src/androidTest/java/androidx/benchmark/macro/perfetto/FrameTimingQueryTest.kt
Description
After updating
compose-material3
from1.3.0-beta01
to1.3.0-beta05
, we noticed that TalkBack's initial focus shifted to the scrim instead of the content within a bottom sheet when it was opened. This requires screen reader users to perform an additional swipe to hear what's on the screen. We believe that Android should not require screen reader users to re-learn how to use the bottom sheet by swiping one more time.Currently, our codebase includes both legacy (view-based) and Compose bottom sheets. The legacy bottom sheet functions as expected, while the Compose bottom sheet exhibits incorrect behavior. This inconsistency can be confusing for screen reader users, depending on which bottom sheet they are interacting with.
Jetpack Compose version: 1.7.0-beta07
Material Library Version (M2, M3 or Both?): M3/1.3.0-beta05
Material Compose component used: ModalBottomSheet
Android Studio Build: AI-241.18034.62.2412.12084018
Kotlin version: 1.9.25
Steps to Reproduce or Code Sample to Reproduce:
Stack trace (if applicable):