TalkBack's initial focus moves to scrim when ModalBottomSheet after compose-material3 update. [358594665]

Fixed

Bug

Status Update

No update yet.

Description

hy...@salesforce.com

created issue #1

Aug 9, 2024 09:31PM

After updating compose-material3 from 1.3.0-beta01 to 1.3.0-beta05, we noticed that TalkBack's initial focus shifted to the scrim instead of the content within a bottom sheet when it was opened. This requires screen reader users to perform an additional swipe to hear what's on the screen. We believe that Android should not require screen reader users to re-learn how to use the bottom sheet by swiping one more time.

Currently, our codebase includes both legacy (view-based) and Compose bottom sheets. The legacy bottom sheet functions as expected, while the Compose bottom sheet exhibits incorrect behavior. This inconsistency can be confusing for screen reader users, depending on which bottom sheet they are interacting with.

Jetpack Compose version: 1.7.0-beta07

Material Library Version (M2, M3 or Both?): M3/1.3.0-beta05

Material Compose component used: ModalBottomSheet

Android Studio Build: AI-241.18034.62.2412.12084018

Kotlin version: 1.9.25

Steps to Reproduce or Code Sample to Reproduce:

In any simple app, open a ModalBottomSheet when TalkBack is on.
Observe and hear what TalkBack announces. (attached two videos of before and after)

Stack trace (if applicable):

before_compose_bottom_sheet.mp4

267 KB

Download

after_compose_bottom_sheet.mp4

243 KB

Download

Comments

se...@google.com <se...@google.com> Aug 12, 2024 04:38PM

Reassigned to se...@google.com.

se...@google.com <se...@google.com> Aug 12, 2024 06:45PM

Accepted by se...@google.com.

ap...@google.com <ap...@google.com> #2Aug 14, 2024 01:49PM

Project: platform/frameworks/support
Branch: androidx-main
Author: Louis Pullen-Freilich <lpf@google.com>
Link: https://android-review.googlesource.com/3328184

Adds OverscrollEffect#withoutDrawing and OverscrollEffect#withoutEventHandling

Expand for full commit details

Adds OverscrollEffect#withoutDrawing and OverscrollEffect#withoutEventHandling 
 
These APIs allow overscroll to have events dispatched to it by one component, and rendered in a separate component. 
 
Fixes: b/266550551 
Fixes: b/204650733 
Fixes: b/255554340 
Fixes: b/229537244 
Test: OverscrollTest 
Relnote: "Adds OverscrollEffect#withoutDrawing and OverscrollEffect#withoutEventHandling APIs - these APIs create a wrapped instance of the provided overscroll effect that doesn't draw / handle events respectively, which allows for rendering  overscroll in a separate component from the component that is dispatching events. For example, disabling drawing the overscroll inside a lazy list, and then drawing the overscroll separately on top / elsewhere." 
Change-Id: Idbb3d91546b49c1987a041f959bce4b2b09a9f61

Files:

M compose/foundation/foundation/api/current.txt
M compose/foundation/foundation/api/restricted_current.txt
M compose/foundation/foundation/integration-tests/foundation-demos/src/main/java/androidx/compose/foundation/demos/OverscrollDemo.kt
M compose/foundation/foundation/samples/src/main/java/androidx/compose/foundation/samples/OverscrollSample.kt
M compose/foundation/foundation/src/androidInstrumentedTest/kotlin/androidx/compose/foundation/OverscrollTest.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/Overscroll.kt

Hash: f64e25b7a473c757d080521e7dd97b3f6670f60d
Date: Fri Nov 01 18:43:56 2024

se...@google.com <se...@google.com> Aug 15, 2024 02:45PM

Marked as fixed.

na...@google.com <na...@google.com> #3Aug 21, 2024 07:55PM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.compose.foundation:foundation:1.8.0-alpha06
androidx.compose.foundation:foundation-android:1.8.0-alpha06
androidx.compose.foundation:foundation-jvmstubs:1.8.0-alpha06
androidx.compose.foundation:foundation-linuxx64stubs:1.8.0-alpha06

Issue 358594665