IssueTracker

Component used: Navigation
Version used: Latest snapshot
Devices/Android versions reproduced on: Any

This bug report is to track the discussion that has started over at https://issuetracker.google.com/issues/358137294#comment6

The problem is that in minified builds, even though navigation now has support for enum classes, kotlinx.serialization at that point knows the name of the class before it was obfuscated by r8, and the navigation library is trying to find it by using the obfuscated name. That's my understanding of the issue.

The real effect this has when using the type-safe apis is that one is simply not able to have enums inside their serializable type-safe destinations.

The one workaround which works is to annotate the enum class with @androidx.annotation.Keep, however this is not mentioned anywhere, there is no compile-time warning for it, nor any lint which could help.

I am reporting this here with the hopes that there can be some improvement in this area. Optimally this should "just work", even in minified builds, but if that turns out to be infeasible, perhaps some lint could help us out. And if that is infeasible too, perhaps a special error message at compile time could inform the user that they should use this annotation, or whatever other solution may be considered best.

There is a repro project here https://github.com/StylianosGakis/navigation-predictive-back-breaking-shared-element/tree/b401ce64c0d2b48585d92f96f626b970fb01bb4a which as seen here https://issuetracker.google.com/issues/358137294#comment9 shows this crash happening.