test leak: release not called [358913893]

Obsolete

Bug

Status Update

No update yet.

Description

ga...@gmail.com

created issue #1

Aug 11, 2024 05:05PM

(sorry if this is a duplicate or if it isn't happening often or otherwise not worth keeping open)

I noticed an error at https://ci.android.com/builds/submitted/12210773/androidx_host_tests/latest/view/logs%2Fbuild_error.log saying

  > Task :tv:tv-foundation:processDebugManifest
  System.logW: A resource was acquired at attached stack trace but never released. See java.io.Closeable for information on avoiding resource leaks.
  java.lang.Throwable: Explicit termination method 'release' not called

It reminds me of https://issuetracker.google.com/issues/176979872#comment4 where Ian resolved what looks to me like a similar message - maybe he knows more about how to figure this out

Comments

au...@google.com <au...@google.com> Aug 13, 2024 04:35PM

Assigned to rv...@google.com.

rv...@google.com <rv...@google.com> #2Aug 14, 2024 11:24AM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit 8739fcde521e3f7f92111b7424ab924fb22eed16
Author: rohitsat13 <rohitsat@google.com>
Date: Fri Nov 20 10:29:57 2020

RxDataStore.kt, the RxJava wrapper for the core API.

Future cls: 1) RxDataBuilder 2) RxDataMigration

Test: RxDataStoreTest.java
Relnote: There is now a RxJava Wrapper for the core DataStore API. Future updates will include a Builder and RxDataMigrations.
Bug: 170311106
Change-Id: I3e7e099488035cca906b5f6e6de0a387acb5b964

A datastore/datastore-rxjava2/api/current.txt
A datastore/datastore-rxjava2/api/public_plus_experimental_current.txt
A datastore/datastore-rxjava2/api/res-current.txt
A datastore/datastore-rxjava2/api/restricted_current.txt
A datastore/datastore-rxjava2/build.gradle
A datastore/datastore-rxjava2/src/main/AndroidManifest.xml
A datastore/datastore-rxjava2/src/main/java/androidx/datastore/rxjava2/RxDataStore.kt
A datastore/datastore-rxjava2/src/test-common/java/androidx/datastore/rxjava2/TestingSerializer.kt
A datastore/datastore-rxjava2/src/test/java/androidx/datastore/rxjava2/RxDataStoreTest.java
M docs-tip-of-tree/build.gradle
M settings.gradle

https://android-review.googlesource.com/1470342

au...@google.com <au...@google.com> #3Aug 14, 2024 04:52PM

Assigned to rv...@google.com.

Project: platform/frameworks/support
Branch: androidx-master-dev

commit a65952abc062e0b8cde3b291cde64c804b70701c
Author: rohitsat13 <rohitsat@google.com>
Date: Fri Nov 20 10:39:49 2020

RxDataStoreBuilder.kt to make constructing DataStores from java easier.

Relnote: Added a builder to make constructing Datastores from java easier.
Test: RxDataStoreBuilderTest
Bug: 170311106
Change-Id: Id2b5a4fdcd166cab45aea92db6e76f9e7814e24f

M datastore/datastore-rxjava2/api/current.txt
M datastore/datastore-rxjava2/api/public_plus_experimental_current.txt
M datastore/datastore-rxjava2/api/restricted_current.txt
A datastore/datastore-rxjava2/src/androidTest/java/androidx/datastore/rxjava2/AssertThrows.kt
A datastore/datastore-rxjava2/src/androidTest/java/androidx/datastore/rxjava2/RxDataStoreBuilderTest.java
A datastore/datastore-rxjava2/src/main/java/androidx/datastore/rxjava2/RxDataStoreBuilder.kt

https://android-review.googlesource.com/1470343

ap...@google.com <ap...@google.com> #4Aug 19, 2024 10:42AM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit 0e34cf4861bfffcd328a07d59fdeb78f7211019c
Author: rohitsat13 <rohitsat@google.com>
Date: Mon Nov 30 14:06:48 2020

Modify RxDataStoreBuilder constructors to accept required params.

Test: Modified existing tests.
Bug: 170311106
Relnote: N/A
Change-Id: I7f4190dec2f4f62500818c97f2beb55034774c35

M datastore/datastore-rxjava2/api/current.txt
M datastore/datastore-rxjava2/api/public_plus_experimental_current.txt
M datastore/datastore-rxjava2/api/restricted_current.txt
M datastore/datastore-rxjava2/src/androidTest/java/androidx/datastore/rxjava2/RxDataStoreBuilderTest.java
M datastore/datastore-rxjava2/src/main/java/androidx/datastore/rxjava2/RxDataStoreBuilder.kt

https://android-review.googlesource.com/1513602

rv...@google.com <rv...@google.com> #5Sep 9, 2024 03:46PM

Status: Won't Fix (Obsolete)

Project: platform/frameworks/support
Branch: androidx-master-dev

commit aba42ee317b69068fb6da49575dca03671ec547f
Author: rohitsat13 <rohitsat@google.com>
Date: Fri Nov 20 10:40:14 2020

RxDataMigration and RxSharedPreferencesMigration.

Add a wrapper for the RxDataMigration interface so that people can define migrations using RxJava

Relnote: """Added support for migrations written using RxJava with the RxDataMigration interface. The RxDataMigration interface is like the DataMigration interface, except using reactivex.Single's instead of suspend functions. You can implement this interface to define a custom migration.
This change also adds support for SharedPreferencesMigrationBuilder which allows easier construction of SharedPreferencesMigrations from java.
"""
Test: RxSharedPreferencesMigrationTest.kt
Bug: 170311106
Change-Id: If929664956cd1434eee5178432958b58722cd76c

M datastore/datastore-rxjava2/api/current.txt
M datastore/datastore-rxjava2/api/public_plus_experimental_current.txt
M datastore/datastore-rxjava2/api/restricted_current.txt
M datastore/datastore-rxjava2/build.gradle
M datastore/datastore-rxjava2/src/androidTest/java/androidx/datastore/rxjava2/RxDataStoreBuilderTest.java
A datastore/datastore-rxjava2/src/androidTest/java/androidx/datastore/rxjava2/RxSharedPreferencesMigrationTest.java
A datastore/datastore-rxjava2/src/main/java/androidx/datastore/rxjava2/RxDataMigration.java
M datastore/datastore-rxjava2/src/main/java/androidx/datastore/rxjava2/RxDataStoreBuilder.kt
A datastore/datastore-rxjava2/src/main/java/androidx/datastore/rxjava2/RxSharedPreferencesMigration.kt
M testutils/testutils-truth/src/main/java/androidx/testutils/assertions.kt
A testutils/testutils-truth/src/test/java/androidx/testutils/AssertionsTest.kt

https://android-review.googlesource.com/1470344

pr...@google.com <pr...@google.com> #6Jan 15, 2025 06:30PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit 842f0818490cd3f31806c13bd2c0db681ac67e46
Author: rohitsat13 <rohitsat@google.com>
Date: Fri Dec 11 11:30:24 2020

Split preferencesKey<T> into individual types, e.g. intPreferencesKey, longPreferencesKey, etc.

Test: PreferencesFromJavaTest
Relnote: """ The preferencesKey<T>(name: String): Key<T> method has been removed and replaced with methods specific to each supported type, for example preferencesKey<Int>("int") is now preferencesIntKey("int") """
Bug: 170311106
Change-Id: Ibcfac9cca7c8a3dbf2eaae17bdb8c22a8ce5a9f7

M datastore/datastore-preferences-core/api/current.txt
M datastore/datastore-preferences-core/api/public_plus_experimental_current.txt
M datastore/datastore-preferences-core/api/restricted_current.txt
M datastore/datastore-preferences-core/src/main/java/androidx/datastore/preferences/core/Preferences.kt
A datastore/datastore-preferences-core/src/main/java/androidx/datastore/preferences/core/PreferencesFactory.kt
A datastore/datastore-preferences-core/src/main/java/androidx/datastore/preferences/core/PreferencesKeys.kt
M datastore/datastore-preferences-core/src/main/java/androidx/datastore/preferences/core/PreferencesSerializer.kt
M datastore/datastore-preferences-core/src/test/java/androidx/datastore/preferences/core/PreferenceDataStoreFactoryTest.kt
A datastore/datastore-preferences-core/src/test/java/androidx/datastore/preferences/core/PreferencesFromJavaTest.java
M datastore/datastore-preferences-core/src/test/java/androidx/datastore/preferences/core/PreferencesSerializerTest.kt
M datastore/datastore-preferences-core/src/test/java/androidx/datastore/preferences/core/PreferencesTest.kt
M datastore/datastore-preferences/src/androidTest/java/androidx/datastore/preferences/PreferenceDataStoreFactoryTest.kt
M datastore/datastore-preferences/src/androidTest/java/androidx/datastore/preferences/SharedPreferencesToPreferencesTest.kt
M datastore/datastore-preferences/src/main/java/androidx/datastore/preferences/SharedPreferencesMigration.kt
M datastore/datastore-sampleapp/src/main/java/com/example/datastoresampleapp/PreferencesDataStoreActivity.kt

https://android-review.googlesource.com/1526348

Issue 358913893