test leak: release not called [358913893]

Obsolete

Bug

Status Update

No update yet.

Description

ga...@gmail.com

created issue #1

Aug 11, 2024 05:05PM

(sorry if this is a duplicate or if it isn't happening often or otherwise not worth keeping open)

I noticed an error at https://ci.android.com/builds/submitted/12210773/androidx_host_tests/latest/view/logs%2Fbuild_error.log saying

  > Task :tv:tv-foundation:processDebugManifest
  System.logW: A resource was acquired at attached stack trace but never released. See java.io.Closeable for information on avoiding resource leaks.
  java.lang.Throwable: Explicit termination method 'release' not called

It reminds me of https://issuetracker.google.com/issues/176979872#comment4 where Ian resolved what looks to me like a similar message - maybe he knows more about how to figure this out

Comments

au...@google.com <au...@google.com> Aug 13, 2024 04:35PM

Assigned to rv...@google.com.

rv...@google.com <rv...@google.com> #2Aug 14, 2024 11:24AM

Thank you for the report and the code causing the issue. I have landed a reproduction which shows that the code thrown an ArrayIndexOutOfBoundsException from the last bitSet.toByteArray()[0] when not processed by R8.

au...@google.com <au...@google.com> #3Aug 14, 2024 04:52PM

Assigned to rv...@google.com.

Project: r8
Branch: main
Author: Søren Gjesse <sgjesse@google.com>
Link: https://r8-review.googlesource.com/100168

Add reproduction of issue 391417819

Expand for full commit details

Add reproduction of issue 391417819 
 
Bug: b/391417819 
Change-Id: I37eb909c100104fadeb895bf5d930f4f54e94ba0

Files:

A src/test/java/com/android/tools/r8/B391417819Repro.java

Hash: bf9b1962052bf91689120a09deded518e37862a2
Date: Wed Jan 22 09:41:15 2025

ap...@google.com <ap...@google.com> #4Aug 19, 2024 10:42AM

deleted

rv...@google.com <rv...@google.com> #5Sep 9, 2024 03:46PM

Status: Won't Fix (Obsolete)

I'm really sorry, please use the source code below:

public class R8Test {

    public byte[] toBytes(boolean on) {
        byte[] bytes = new byte[3];
        bytes[0] = 1;
        BitSet bits = new BitSet(8);
        byte[] byteArray = bits.toByteArray();
        if (byteArray != null && byteArray.length >= 1) {
            bytes[1] = bits.toByteArray()[0];
        }

        BitSet bitSet = new BitSet(8);
        byte[] byteArray2 = bits.toByteArray();
        if (byteArray2 != null && byteArray2.length >= 1) {
            bytes[2] = bitSet.toByteArray()[0];
        }
        return bytes;
    }
}

pr...@google.com <pr...@google.com> #6Jan 15, 2025 06:30PM

Thank you for the update. Most likely the initial source code will still be sufficient to fix the issue.

Issue 358913893