java.lang.NullPointerException: Cannot invoke "com.android.tools.r8.ir.analysis.type.TypeElement.asClassType()" [358913905]

Fixed

Bug

Status Update

No update yet.

Description

qi...@gmail.com

created issue #1

Aug 12, 2024 03:42AM

Versions

r8 version: R8 main (build engineering)
art version: ART version 2.1.0 x86_64
java version: 17.0.12

Description

When we use R8 to process the code shown in the testcase, R8 crashes. We're not sure how to resolve this issue, and the testcase is a simplified version of the actual scenario. It seems like R8 might be missing some libraries, or there might be an issue with the return values of some R8 functions. Is this a bug in R8?

Step to Reproduce

javac -source 8 -target 8 -cp . Test.java
jar cvf classes.jar ./*.class
java -cp r8.jar com.android.tools.r8.R8 --pg-conf rules.pro --release --output ./ ./classes.jar

Expected Result(d8 dex output)

over

Actual Result(r8 dex output)

Error in ./classes.jar:Test.class at LTest;main([Ljava/lang/String;)V:
java.lang.NullPointerException: Cannot invoke "com.android.tools.r8.ir.analysis.type.TypeElement.asClassType()" because the return value of "com.android.tools.r8.ir.analysis.type.DynamicTypeWithUpperBound.getDynamicUpperBoundType()" is null
Compilation failed with an internal error.
Exception in thread "main" java.lang.RuntimeException: com.android.tools.r8.CompilationFailedException: Compilation failed to complete, position: LTest;main([Ljava/lang/String;)V, origin: ./classes.jar:Test.class
	at com.android.tools.r8.utils.ExceptionUtils.withMainProgramHandler(ExceptionUtils.java:195)
	at com.android.tools.r8.R8.main(R8.java:1290)
Caused by: com.android.tools.r8.CompilationFailedException: Compilation failed to complete, position: LTest;main([Ljava/lang/String;)V, origin: ./classes.jar:Test.class
	at Version.fakeStackEntry(Version_main.java:0)
	at com.android.tools.r8.InternalCompilationFailedExceptionUtils.create(InternalCompilationFailedExceptionUtils.java:29)
	at com.android.tools.r8.utils.ExceptionUtils.failWithFakeEntry(ExceptionUtils.java:145)
	at com.android.tools.r8.utils.ExceptionUtils.failCompilation(ExceptionUtils.java:89)
	at com.android.tools.r8.utils.ExceptionUtils.withCompilationHandler(ExceptionUtils.java:83)
	at com.android.tools.r8.utils.ExceptionUtils.withR8CompilationHandler(ExceptionUtils.java:69)
	at com.android.tools.r8.R8.run(R8.java:1273)
	at com.android.tools.r8.R8.lambda$main$26(R8.java:1290)
	at com.android.tools.r8.utils.ExceptionUtils.withMainProgramHandler(ExceptionUtils.java:192)
	... 1 more
Caused by: java.lang.NullPointerException: Cannot invoke "com.android.tools.r8.ir.analysis.type.TypeElement.asClassType()" because the return value of "com.android.tools.r8.ir.analysis.type.DynamicTypeWithUpperBound.getDynamicUpperBoundType()" is null
	at com.android.tools.r8.ir.analysis.type.DynamicTypeWithLowerBound.getDynamicUpperBoundType(DynamicTypeWithLowerBound.java:39)
	at com.android.tools.r8.ir.analysis.type.DynamicTypeWithLowerBound.getDynamicUpperBoundType(DynamicTypeWithLowerBound.java:11)
	at com.android.tools.r8.ir.conversion.passes.TrivialCheckCastAndInstanceOfRemover.removeCheckCastInstructionIfTrivial(TrivialCheckCastAndInstanceOfRemover.java:278)
	at com.android.tools.r8.ir.conversion.passes.TrivialCheckCastAndInstanceOfRemover.rewriteCode(TrivialCheckCastAndInstanceOfRemover.java:90)
	at com.android.tools.r8.ir.conversion.passes.CodeRewriterPass.run(CodeRewriterPass.java:55)
	at com.android.tools.r8.ir.conversion.passes.CodeRewriterPass.lambda$run$0(CodeRewriterPass.java:41)
	at com.android.tools.r8.utils.Timing.time(Timing.java:471)
	at com.android.tools.r8.ir.conversion.passes.CodeRewriterPass.run(CodeRewriterPass.java:41)
	at com.android.tools.r8.ir.conversion.passes.CodeRewriterPassCollection.run(CodeRewriterPassCollection.java:70)
	at com.android.tools.r8.ir.conversion.IRConverter.optimize(IRConverter.java:696)
	at com.android.tools.r8.ir.conversion.IRConverter.rewriteDesugaredCodeInternal(IRConverter.java:491)
	at com.android.tools.r8.ir.conversion.IRConverter.lambda$rewriteDesugaredCode$5(IRConverter.java:463)
	at com.android.tools.r8.utils.ExceptionUtils.withOriginAndPositionAttachmentHandler(ExceptionUtils.java:252)
	at com.android.tools.r8.ir.conversion.IRConverter.rewriteDesugaredCode(IRConverter.java:459)
	at com.android.tools.r8.ir.conversion.IRConverter.processDesugaredMethod(IRConverter.java:436)
	at com.android.tools.r8.ir.conversion.PrimaryR8IRConverter.lambda$internalOptimize$2(PrimaryR8IRConverter.java:96)
	at com.android.tools.r8.ir.conversion.PrimaryMethodProcessor.lambda$forEachMethod$0(PrimaryMethodProcessor.java:134)
	at com.android.tools.r8.utils.ThreadUtils.lambda$processItemsWithResults$0(ThreadUtils.java:57)
	at com.android.tools.r8.utils.ThreadUtils.lambda$processItemsWithResultsThatMatches$2(ThreadUtils.java:111)
	at java.base/java.util.concurrent.ForkJoinTask$AdaptedCallable.exec(ForkJoinTask.java:1428)
	at java.base/java.util.concurrent.ForkJoinTask.doExec(ForkJoinTask.java:373)
	at java.base/java.util.concurrent.ForkJoinPool$WorkQueue.topLevelExec(ForkJoinPool.java:1182)
	at java.base/java.util.concurrent.ForkJoinPool.scan(ForkJoinPool.java:1655)
	at java.base/java.util.concurrent.ForkJoinPool.runWorker(ForkJoinPool.java:1622)
	at java.base/java.util.concurrent.ForkJoinWorkerThread.run(ForkJoinWorkerThread.java:165)
	Suppressed: java.lang.RuntimeException: java.util.concurrent.ExecutionException: com.android.tools.r8.utils.ExceptionUtils$OriginAttachmentException: java.lang.NullPointerException: Cannot invoke "com.android.tools.r8.ir.analysis.type.TypeElement.asClassType()" because the return value of "com.android.tools.r8.ir.analysis.type.DynamicTypeWithUpperBound.getDynamicUpperBoundType()" is null
		at com.android.tools.r8.utils.ExceptionUtils.unwrapExecutionException(ExceptionUtils.java:227)
		at com.android.tools.r8.R8.run(R8.java:893)
		at com.android.tools.r8.R8.run(R8.java:253)
		at com.android.tools.r8.R8.lambda$run$25(R8.java:1274)
		at com.android.tools.r8.utils.ExceptionUtils.withCompilationHandler(ExceptionUtils.java:80)
		at com.android.tools.r8.utils.ExceptionUtils.withR8CompilationHandler(ExceptionUtils.java:69)
		at com.android.tools.r8.R8.run(R8.java:1273)
		at com.android.tools.r8.R8.lambda$main$26(R8.java:1290)
		at com.android.tools.r8.utils.ExceptionUtils.withMainProgramHandler(ExceptionUtils.java:192)
		at com.android.tools.r8.R8.main(R8.java:1290)
	Caused by: java.util.concurrent.ExecutionException: com.android.tools.r8.utils.ExceptionUtils$OriginAttachmentException: java.lang.NullPointerException: Cannot invoke "com.android.tools.r8.ir.analysis.type.TypeElement.asClassType()" because the return value of "com.android.tools.r8.ir.analysis.type.DynamicTypeWithUpperBound.getDynamicUpperBoundType()" is null
		at java.base/java.util.concurrent.ForkJoinTask.reportExecutionException(ForkJoinTask.java:605)
		at java.base/java.util.concurrent.ForkJoinTask.get(ForkJoinTask.java:981)
		at com.android.tools.r8.threading.providers.blocking.ThreadingModuleBlocking.awaitFutures(ThreadingModuleBlocking.java:40)
		at com.android.tools.r8.threading.TaskCollection.await(TaskCollection.java:68)
		at com.android.tools.r8.threading.TaskCollection.awaitWithResults(TaskCollection.java:139)
		at com.android.tools.r8.threading.TaskCollection.awaitWithResults(TaskCollection.java:146)
		at com.android.tools.r8.utils.ThreadUtils.processItemsWithResultsThatMatches(ThreadUtils.java:115)
		at com.android.tools.r8.utils.ThreadUtils.processItemsWithResults(ThreadUtils.java:97)
		at com.android.tools.r8.utils.ThreadUtils.processItemsWithResults(ThreadUtils.java:77)
		at com.android.tools.r8.utils.ThreadUtils.processItemsWithResults(ThreadUtils.java:56)
		at com.android.tools.r8.ir.conversion.PrimaryMethodProcessor.forEachMethod(PrimaryMethodProcessor.java:130)
		at com.android.tools.r8.ir.conversion.PrimaryR8IRConverter.internalOptimize(PrimaryR8IRConverter.java:94)
		at com.android.tools.r8.ir.conversion.PrimaryR8IRConverter.optimize(PrimaryR8IRConverter.java:42)
		at com.android.tools.r8.R8.run(R8.java:534)
		... 8 more
	Caused by: com.android.tools.r8.utils.ExceptionUtils$OriginAttachmentException: java.lang.NullPointerException: Cannot invoke "com.android.tools.r8.ir.analysis.type.TypeElement.asClassType()" because the return value of "com.android.tools.r8.ir.analysis.type.DynamicTypeWithUpperBound.getDynamicUpperBoundType()" is null
		at com.android.tools.r8.utils.ExceptionUtils$OriginAttachmentException.wrap(ExceptionUtils.java:266)
		at com.android.tools.r8.utils.ExceptionUtils.withOriginAndPositionAttachmentHandler(ExceptionUtils.java:256)
		at com.android.tools.r8.ir.conversion.IRConverter.rewriteDesugaredCode(IRConverter.java:459)
		at com.android.tools.r8.ir.conversion.IRConverter.processDesugaredMethod(IRConverter.java:436)
		at com.android.tools.r8.ir.conversion.PrimaryR8IRConverter.lambda$internalOptimize$2(PrimaryR8IRConverter.java:96)
		at com.android.tools.r8.ir.conversion.PrimaryMethodProcessor.lambda$forEachMethod$0(PrimaryMethodProcessor.java:134)
		at com.android.tools.r8.utils.ThreadUtils.lambda$processItemsWithResults$0(ThreadUtils.java:57)
		at com.android.tools.r8.utils.ThreadUtils.lambda$processItemsWithResultsThatMatches$2(ThreadUtils.java:111)
		at java.base/java.util.concurrent.ForkJoinTask$AdaptedCallable.exec(ForkJoinTask.java:1428)
		at java.base/java.util.concurrent.ForkJoinTask.doExec(ForkJoinTask.java:373)
		at java.base/java.util.concurrent.ForkJoinPool$WorkQueue.topLevelExec(ForkJoinPool.java:1182)
		at java.base/java.util.concurrent.ForkJoinPool.scan(ForkJoinPool.java:1655)
		at java.base/java.util.concurrent.ForkJoinPool.runWorker(ForkJoinPool.java:1622)
		at java.base/java.util.concurrent.ForkJoinWorkerThread.run(ForkJoinWorkerThread.java:165)
	Caused by: [CIRCULAR REFERENCE: java.lang.NullPointerException: Cannot invoke "com.android.tools.r8.ir.analysis.type.TypeElement.asClassType()" because the return value of "com.android.tools.r8.ir.analysis.type.DynamicTypeWithUpperBound.getDynamicUpperBoundType()" is null]

Testcase Source Code

class Test {
  public static void main(String[] args) {
    Object object = new Object();
    if (object instanceof int[]) {
      int[] object2 = (int[])object;
    }
    System.out.println("over");
  }
}

rules.pro

-libraryjars android.jar
-keep class Test { public main(java.lang.String[]); }

Comments

sg...@google.com <sg...@google.com> Aug 12, 2024 06:12AM

Reassigned to sg...@google.com.

sg...@google.com <sg...@google.com> Aug 12, 2024 10:16AM

Accepted by sg...@google.com.

ap...@google.com <ap...@google.com> #2Aug 12, 2024 11:40AM

Project: r8
Branch: main

commit 75aef23e19250f807aa7d2bcf00485bd21cd9b8e
Author: Søren Gjesse <sgjesse@google.com>
Date: Mon Aug 12 13:37:31 2024

Reproduce NPE in TrivialCheckCastAndInstanceOfRemover

Bug:

b/358913905

Change-Id: Ieb5e664a94208dfa4bb9dfcc2e87a28f74f5afd0

A src/test/java/com/android/tools/r8/ir/optimize/checkcast/CastInDeadCodeafterInstanceOfOptimizationTest.java

https://r8-review.googlesource.com/95007

ap...@google.com <ap...@google.com> #3Aug 13, 2024 06:42AM

Marked as fixed.

Project: r8
Branch: main

commit 51676e787bd368b5c2c9fa8ddbd04c95bf770e5e
Author: Søren Gjesse <sgjesse@google.com>
Date: Mon Aug 12 13:41:19 2024

Only look at upper bound when checking for trivial check-cast

Fixes:

b/358913905

Change-Id: Iac27585b1d9814a6ad5cb690f63f61daa6df91b4

M src/main/java/com/android/tools/r8/ir/conversion/passes/TrivialCheckCastAndInstanceOfRemover.java
M src/test/java/com/android/tools/r8/ir/optimize/checkcast/CastInDeadCodeafterInstanceOfOptimizationTest.java

https://r8-review.googlesource.com/94985

ap...@google.com <ap...@google.com> #4Aug 13, 2024 11:00AM

Project: r8
Branch: 8.6

commit 0b633c31bd87c783e6813968b0d6ea14ca3326e0
Author: Søren Gjesse <sgjesse@google.com>
Date: Tue Aug 13 09:16:33 2024

Reproduce NPE in TrivialCheckCastAndInstanceOfRemover

Bug:

b/358913905

Change-Id: Ieb5e664a94208dfa4bb9dfcc2e87a28f74f5afd0

A src/test/java/com/android/tools/r8/ir/optimize/checkcast/CastInDeadCodeafterInstanceOfOptimizationTest.java

https://r8-review.googlesource.com/95080

ap...@google.com <ap...@google.com> #5Aug 13, 2024 11:00AM

Project: r8
Branch: 8.6

commit 88bd3a4e296553c903edb1a9937929ae64b260f6
Author: Søren Gjesse <sgjesse@google.com>
Date: Tue Aug 13 09:16:52 2024

Only look at upper bound when checking for trivial check-cast

Fixes:

b/358913905

https://r8-review.googlesource.com/95100

ap...@google.com <ap...@google.com> #6Aug 13, 2024 11:00AM

Project: r8
Branch: 8.6

commit f55e0fb28bf2ee076df06c670adafa747cfb88f2
Author: Søren Gjesse <sgjesse@google.com>
Date: Tue Aug 13 09:17:06 2024

Version 8.6.20

Bug:

b/358913905

Change-Id: I1c1ca5e516ed3bed9ead7966b487719754c931ed

M src/main/java/com/android/tools/r8/Version.java

https://r8-review.googlesource.com/95081

ap...@google.com <ap...@google.com> #7Aug 13, 2024 11:00AM

Project: r8
Branch: 8.5

commit 0604cb960cdeb08ba4effd13f859be51f9e398f9
Author: Søren Gjesse <sgjesse@google.com>
Date: Tue Aug 13 09:17:34 2024

Reproduce NPE in TrivialCheckCastAndInstanceOfRemover

Bug:

b/358913905

Change-Id: Ieb5e664a94208dfa4bb9dfcc2e87a28f74f5afd0

A src/test/java/com/android/tools/r8/ir/optimize/checkcast/CastInDeadCodeafterInstanceOfOptimizationTest.java

https://r8-review.googlesource.com/95101

ap...@google.com <ap...@google.com> #8Aug 13, 2024 11:00AM

Project: r8
Branch: 8.5

commit 45bdc7483264e19ea89c659aab69378640e6e0f7
Author: Søren Gjesse <sgjesse@google.com>
Date: Tue Aug 13 09:17:56 2024

Version 8.5.38

Bug:

b/358913905

Change-Id: Ic23dc0f17cce9d67f42e9ba65e3853abe884594b

M src/main/java/com/android/tools/r8/Version.java

https://r8-review.googlesource.com/95103

ap...@google.com <ap...@google.com> #9Aug 13, 2024 11:00AM

Project: r8
Branch: 8.5

commit 5bf97fe5b30368585bdc24326b9ea308c071e7cd
Author: Søren Gjesse <sgjesse@google.com>
Date: Tue Aug 13 09:17:46 2024

Only look at upper bound when checking for trivial check-cast

Fixes:

b/358913905

https://r8-review.googlesource.com/95102

ap...@google.com <ap...@google.com> #10Aug 13, 2024 11:02AM

b/358913905

Change-Id: Ieb5e664a94208dfa4bb9dfcc2e87a28f74f5afd0

A src/test/java/com/android/tools/r8/ir/optimize/checkcast/CastInDeadCodeafterInstanceOfOptimizationTest.java

https://r8-review.googlesource.com/95080

ap...@google.com <ap...@google.com> #11Aug 13, 2024 11:02AM

b/358913905

https://r8-review.googlesource.com/95100

an...@google.com <an...@google.com> #12Sep 17, 2024 09:19PM

Thank you for your patience while our engineering team worked to resolve this issue. A fix for this issue is now available in:

Android Studio Koala Feature Drop | 2024.1.2 Patch 1
Android Gradle Plugin 8.6.1

We encourage you to try the latest update.

If you notice further issues or have questions, please file a new bug report.

Thank you for taking the time to submit feedback — we really appreciate it!

Issue 358913905

Description

Versions

Description

Step to Reproduce

Expected Result(d8 dex output)

Actual Result(r8 dex output)

Testcase Source Code

Issue summary

Comments

sg...@google.com <sg...@google.com> Aug 12, 2024 06:12AM

sg...@google.com <sg...@google.com> Aug 12, 2024 10:16AM

ap...@google.com <ap...@google.com> #2Aug 12, 2024 11:40AM

ap...@google.com <ap...@google.com> #3Aug 13, 2024 06:42AM

ap...@google.com <ap...@google.com> #4Aug 13, 2024 11:00AM

ap...@google.com <ap...@google.com> #5Aug 13, 2024 11:00AM

ap...@google.com <ap...@google.com> #6Aug 13, 2024 11:00AM

ap...@google.com <ap...@google.com> #7Aug 13, 2024 11:00AM

ap...@google.com <ap...@google.com> #8Aug 13, 2024 11:00AM

ap...@google.com <ap...@google.com> #9Aug 13, 2024 11:00AM

ap...@google.com <ap...@google.com> #10Aug 13, 2024 11:02AM

ap...@google.com <ap...@google.com> #11Aug 13, 2024 11:02AM

an...@google.com <an...@google.com> #12Sep 17, 2024 09:19PM

Add comment

Issue metadata