IssueTracker

there are some image for help

hello?

This lines should be fixed: https://source.corp.google.com/h/team/android-devtools-gaming/AndroidVisualStudioExtension/+/master:tools/base/wizard/template-impl/src/com/android/tools/idea/wizard/template/impl/activities/cppGameActivity/src/nativeLibCpp.kt;l=25-30;bpv=1

For the reference, see @gfan CLs from this issue: https://b.corp.google.com/issues/254342244

The same as (or related to) 363314196?

Yes these two issues are connected.

So, basically it happened to me because I had one test project derived by a sample and I made another one from the new->game activity on Android Studio. So one was with 3.0.5 explicitly (gradle with groovy) and the other one was implicitly with 1.2.2 (from implementation(libs.androidx.games.activity)). So when I tried to bring the code regarding Game Activity, I got the error. I figured it out when I found another test I had and the libs.versions.toml had the 3.0.5 instead of 1.2.2. So the differences were in the headers,

for 1.2.2

#include <game-activity/GameActivity.cpp>
#include <game-text-input/gametextinput.cpp>
#include <game-activity/native_app_glue/android_native_app_glue.c>

and for 3.0.5

#include "game-activity/native_app_glue/android_native_app_glue.h"

I had then to add on the CMakelists.txt:

# Export GameActivity_onCreate(),
# Refer to: https://github.com/android-ndk/ndk/issues/381.
set(CMAKE_SHARED_LINKER_FLAGS
        "${CMAKE_SHARED_LINKER_FLAGS} -u Java_com_google_androidgamesdk_GameActivity_initializeNativeCode")

and use the:

        game-activity::game-activity_static

this made going from 1.2.2 to 3.0.5 possible.

note that instead (it's another bug i guess):

        game-activity::game-activity

gave me an error or a function not present to the linker (!!):

ld.lld: error: undefined symbol: GameActivityMotionEvent_destroy
>>> referenced by android_native_app_glue.c:541 (/home/bloom/.gradle/caches/8.9/transforms/b3e4b38b898120fddfba2ec14de1fef1/transformed/games-activity-3.0.5/prefab/modules/game-activity/include/game-activity/native_app_glue/android_native_app_glue.c:541)
>>>               CMakeFiles/hello_cloudxr_native.dir/src/main/cpp/main.cpp.o:(android_app_clear_motion_events)
clang++: error: linker command failed with exit code 1 (use -v to see invocation)
ninja: build stopped: subcommand failed.

and copy pasting that function from the source to my code bypassed the error. The function:

extern "C" void GameActivityMotionEvent_destroy(
    GameActivityMotionEvent *c_event) {
    delete c_event->historicalAxisValues;
    delete c_event->historicalEventTimesMillis;
    delete c_event->historicalEventTimesNanos;
}

I would suggest making the migration steps clearer to the user, I got them right a bit by luck.

Hope it helps.

Thanks for this work. This indeed fixes the compilation. I guess we have to wait for GameActivity 4.0.0 stable release in order to include this fix, as I don't think it's reasonable to include unstable versions (current version is 4.0.0-alpha01).

However, I'm still puzzled by the lack of GameActivityMotionEvent_destroy. Does this symbol only exist in the static library but not in the dynamic one?

Yes, that happened on my project, that symbol is not defined if remove the _static suffix from game-activity::game-activity in the CMakeLists.txt file. I didn't try again but I tried to reproduce with your sample game_controller in games-samples/agdk, Only change, I had to update the gradle used to 8.9 due to my JDK version. Removing the _static gave the following errors:

for game activity 2.0.2 (original sample version)

ld.lld: error: undefined symbol: GameActivity_setWindowFlags
  >>> referenced by native_engine.cpp:195 (/home/bloom/sw_develop/Android/Samples/games-samples/agdk/game_controller/app/src/main/cpp/native_engine.cpp:195)
  >>>               CMakeFiles/game.dir/native_engine.cpp.o:(NativeEngine::GameLoop())
  
  ld.lld: error: undefined symbol: GameActivity_getWindowInsets
  >>> referenced by native_engine.cpp:355 (/home/bloom/sw_develop/Android/Samples/games-samples/agdk/game_controller/app/src/main/cpp/native_engine.cpp:355)
  >>>               CMakeFiles/game.dir/native_engine.cpp.o:(NativeEngine::UpdateSystemBarOffset())
  
  ld.lld: error: undefined symbol: android_app_swap_input_buffers
  >>> referenced by native_engine.cpp:366 (/home/bloom/sw_develop/Android/Samples/games-samples/agdk/game_controller/app/src/main/cpp/native_engine.cpp:366)
  >>>               CMakeFiles/game.dir/native_engine.cpp.o:(NativeEngine::HandleGameActivityInput())
  
  ld.lld: error: undefined symbol: android_app_clear_key_events
  >>> referenced by native_engine.cpp:375 (/home/bloom/sw_develop/Android/Samples/games-samples/agdk/game_controller/app/src/main/cpp/native_engine.cpp:375)
  >>>               CMakeFiles/game.dir/native_engine.cpp.o:(NativeEngine::HandleGameActivityInput())
  
  ld.lld: error: undefined symbol: android_app_clear_motion_events
  >>> referenced by native_engine.cpp:386 (/home/bloom/sw_develop/Android/Samples/games-samples/agdk/game_controller/app/src/main/cpp/native_engine.cpp:386)
  >>>               CMakeFiles/game.dir/native_engine.cpp.o:(NativeEngine::HandleGameActivityInput())
  
  ld.lld: error: undefined symbol: GameActivityPointerAxes_enableAxis
  >>> referenced by native_engine.cpp:401 (/home/bloom/sw_develop/Android/Samples/games-samples/agdk/game_controller/app/src/main/cpp/native_engine.cpp:401)
  >>>               CMakeFiles/game.dir/native_engine.cpp.o:(NativeEngine::CheckForNewAxis())
  clang++: error: linker command failed with exit code 1 (use -v to see invocation)
  ninja: build stopped: subcommand failed.
  
  C++ build system [build] failed while executing:
      /home/bloom/Android/Sdk/cmake/3.22.1/bin/ninja \
        -C \
        /home/bloom/sw_develop/Android/Samples/games-samples/agdk/game_controller/app/.cxx/Debug/1r6c1j55/arm64-v8a \
        game
    from /home/bloom/sw_develop/Android/Samples/games-samples/agdk/game_controller/app

for game activity 3.0.5 (latest reported by Android Studio)

  ld.lld: error: undefined symbol: GameActivity_setWindowFlags
  >>> referenced by native_engine.cpp:195 (/home/bloom/sw_develop/Android/Samples/games-samples/agdk/game_controller/app/src/main/cpp/native_engine.cpp:195)
  >>>               CMakeFiles/game.dir/native_engine.cpp.o:(NativeEngine::GameLoop())
  
  ld.lld: error: undefined symbol: GameActivity_getWindowInsets
  >>> referenced by native_engine.cpp:355 (/home/bloom/sw_develop/Android/Samples/games-samples/agdk/game_controller/app/src/main/cpp/native_engine.cpp:355)
  >>>               CMakeFiles/game.dir/native_engine.cpp.o:(NativeEngine::UpdateSystemBarOffset())
  
  ld.lld: error: undefined symbol: android_app_swap_input_buffers
  >>> referenced by native_engine.cpp:366 (/home/bloom/sw_develop/Android/Samples/games-samples/agdk/game_controller/app/src/main/cpp/native_engine.cpp:366)
  >>>               CMakeFiles/game.dir/native_engine.cpp.o:(NativeEngine::HandleGameActivityInput())
  
  ld.lld: error: undefined symbol: android_app_clear_key_events
  >>> referenced by native_engine.cpp:375 (/home/bloom/sw_develop/Android/Samples/games-samples/agdk/game_controller/app/src/main/cpp/native_engine.cpp:375)
  >>>               CMakeFiles/game.dir/native_engine.cpp.o:(NativeEngine::HandleGameActivityInput())
  
  ld.lld: error: undefined symbol: android_app_clear_motion_events
  >>> referenced by native_engine.cpp:386 (/home/bloom/sw_develop/Android/Samples/games-samples/agdk/game_controller/app/src/main/cpp/native_engine.cpp:386)
  >>>               CMakeFiles/game.dir/native_engine.cpp.o:(NativeEngine::HandleGameActivityInput())
  
  ld.lld: error: undefined symbol: GameActivityPointerAxes_enableAxis
  >>> referenced by native_engine.cpp:401 (/home/bloom/sw_develop/Android/Samples/games-samples/agdk/game_controller/app/src/main/cpp/native_engine.cpp:401)
  >>>               CMakeFiles/game.dir/native_engine.cpp.o:(NativeEngine::CheckForNewAxis())
  clang++: error: linker command failed with exit code 1 (use -v to see invocation)
  ninja: build stopped: subcommand failed.

So I guess a good starting point would be try with and without _static on the AGDK samples. As I understand the suggested library version is the static one, so it may be that this kind of bug/behaviour is already known?

Blocked by b/367670431