IssueTracker

What steps will reproduce the problem?
1.create an Ubuntu 16.04 instance with one or more 'local SSD scratch disk' type NVMe
2.run "grep . /sys/block/nvme0n?/device/{model,serial}"
3.all model and serial strings show "nvme_card"


What is the expected output? What do you see instead?

The NVMe model string is expected to represent the NVMe drive model, e.g. "Intel NVMe", "Google NVMe", or whatever (vendor-specific, but meaningful).  The NVMe serial string is expected to contain a vendor-specific unique string that can identify the device, e.g. "GCE3487587923839" or whatever (vendor-specific also, but unique across the specific vendor's drives).

Instead of seeing meaningful values, the Google instance NVMe drives have "nvme_card" for both the model string and the serial string, for all NVMe drives.


What version of the product are you using? On what operating system?

Ubuntu 16.04 has a kernel recent enough to export the NVMe model/serial strings via sysfs, but this problem is independent of the OS, since the strings come from the hypervisor implementation of the NVMe controller.


Please provide any additional information below.

Ubuntu 14.04 and 16.04 (and later) will soon support creation of symlinks to NVMe drives, as /dev/disk/by-id/nvme-MODEL_SERIAL and partition symlinks as nvme-MODEL_SERIAL-partN.  Without meaningful model and serial strings provided by the Google NVMe drives, those symlinks will be useless (i.e. there will be only one drive symlink "/dev/disk/by-id/nvme-nvme_card_nvme_card" that points to the last nvme drive to enumerate).

From the hypervisor perspective, the model and serial strings are communicated via the NVMe controller's "Identify" command (NVMe 1.2.1 spec section 5.11, Identify command).  The specific fields are part of the Identify Controller Data Structure (Figure 90), the Serial Number (bytes 23:04) and Model Number (bytes 63:24).  Please fill in these fields with meaningful values.