Add a Double + Double? NavType [359245753]

Fixed

Bug

Status Update

No update yet.

Description

ag...@wayfair.com

created issue #1

Aug 13, 2024 01:34AM

Component used: Navigation Compose Version used: 2.8.0-beta04+ Devices/Android versions reproduced on: Any

Using any valid @Serializable route class with a Double or Double? field results in:

java.lang.IllegalArgumentException: Cannot cast ${field} of type kotlin.Double to a NavType. Make sure to provide custom NavType for this argument.

This seems like a large feature gap in supporting kotlinx serialization functionality.

Comments

jb...@google.com <jb...@google.com> Aug 13, 2024 03:02PM

Status: Duplicate of

131207188

ag...@wayfair.com <ag...@wayfair.com> #2Aug 14, 2024 04:56PM

since these are in public API (:/) we need to do this in 1.2

il...@google.com <il...@google.com> #3Aug 21, 2024 11:05PM

Assigned to cl...@google.com.

since it is already marked as deprecated, we can probably do it by now.

cl...@google.com <cl...@google.com> Sep 3, 2024 06:24PM

Accepted by cl...@google.com.

sa...@gmail.com <sa...@gmail.com> #4Sep 10, 2024 12:39PM

Opening diff shortly

ap...@google.com <ap...@google.com> #5Sep 18, 2024 03:38PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit d576cbdc911cba16638a44fd8223391a90a07ef7
Author: Mike Nakhimovich <digitalbuddha@users.noreply.github.com>
Date: Tue Aug 11 09:30:34 2020

[GH] Hide deprecated internal API.

## Proposed Changes

* `RoomDatabase.java` has protected `mCallbacks` field which is leaking in the API docs, we should @Hide it.

## Testing

Test: Ran unit tests locally

## Issues Fixed

Fixes: 76109329

This is an imported pull request from

https://github.com/androidx/androidx/pull/61.

Resolves #61
Github-Pr-Head-Sha: 6440daa3a63752c7f9d5ba2a390248cd85bc634f
GitOrigin-RevId: fe92d8466a59b44b218b6ca3cbd57dcda17992f7

Change-Id: Id599cdf5b02b32bdae0166266fb7da967598fe92

A room/runtime/api/current.ignore
M room/runtime/api/current.txt
M room/runtime/api/public_plus_experimental_current.txt
M room/runtime/api/restricted_current.txt
M room/runtime/src/main/java/androidx/room/RoomDatabase.java

https://android-review.googlesource.com/1396827

ap...@google.com <ap...@google.com> #6Sep 18, 2024 03:47PM

Project: platform/frameworks/support
Branch: androidx-main

commit b1c0e53c08a0c80fd8134e2206d70feaf49a6de6
Author: Clara Fok <clarafok@google.com>
Date: Fri Aug 30 15:45:18 2024

Add built-in safe args support for nullable Double

Test: ./gradlew navigation:navigation-common:cC
Test: ./gradlew navigation:navigation-common:test
Test: ./gradlew navigation:navigation-runtime:cC
Bug: 359245753
Relnote: "Navigation in safe args now has built-in support for nullable Double type."

Change-Id: Ibc4c02fa77e416c1c007209fb358a0d1c34389db

M navigation/navigation-common/src/androidTest/java/androidx/navigation/serialization/RouteDecoderTest.kt
M navigation/navigation-common/src/androidTest/java/androidx/navigation/serialization/RouteFilledTest.kt
M navigation/navigation-common/src/main/java/androidx/navigation/serialization/NavTypeConverter.kt
M navigation/navigation-common/src/test/java/androidx/navigation/serialization/NavArgumentGeneratorTest.kt
M navigation/navigation-common/src/test/java/androidx/navigation/serialization/NavTypeConverterTest.kt
M navigation/navigation-runtime/src/androidTest/java/androidx/navigation/NavControllerRouteTest.kt

https://android-review.googlesource.com/3266716

cl...@google.com <cl...@google.com> #7Sep 19, 2024 06:45AM

DoubleArray support added in https://android-review.googlesource.com/c/platform/frameworks/support/+/3266717

ap...@google.com <ap...@google.com> #8Sep 19, 2024 03:39PM

Project: platform/frameworks/support
Branch: androidx-main

commit 2bbd62e9ba772d50bf4da98ada024a798257af28
Author: Clara Fok <clarafok@google.com>
Date: Thu Sep 19 04:47:53 2024

Add built-in safe args support for List<Double>

Test: ./gradlew navigation:navigation-common:cC
Test: ./gradlew navigation:navigation-common:test
Test: ./gradlew navigation:navigation-runtime:cC
Bug: 359245753
Relnote: "Navigation with safe args now has built-in support for nullable List<Double>"
Change-Id: I5bed4745773efa2e8a57fcdacc77cc16b1845067

M navigation/navigation-common/src/androidTest/java/androidx/navigation/serialization/RouteDecoderTest.kt
M navigation/navigation-common/src/androidTest/java/androidx/navigation/serialization/RouteFilledTest.kt
M navigation/navigation-common/src/main/java/androidx/navigation/serialization/NavTypeConverter.kt
M navigation/navigation-common/src/test/java/androidx/navigation/serialization/NavArgumentGeneratorTest.kt
M navigation/navigation-common/src/test/java/androidx/navigation/serialization/NavTypeConverterTest.kt
M navigation/navigation-runtime/src/androidTest/java/androidx/navigation/NavControllerRouteTest.kt

https://android-review.googlesource.com/3271516

cl...@google.com <cl...@google.com> #9Sep 19, 2024 03:53PM

Marked as fixed.

Fixed internally and will be available in navigation 2.8.2.

pr...@google.com <pr...@google.com> #10Oct 2, 2024 05:37PM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.annotation:annotation-wasm-js:1.9.0-rc01
androidx.annotation:annotation-watchosdevicearm64:1.9.0-rc01
androidx.navigation:navigation-common:2.8.2
androidx.navigation:navigation-runtime:2.8.2

na...@google.com <na...@google.com> #11Oct 16, 2024 05:48PM