ScalingLazyColumn userScrollEnabled doesn't stop Rotary [360295825]

Fixed

Bug

Status Update

No update yet.

Description

ys...@google.com

created issue #1

Aug 16, 2024 09:10AM

Component used: Wear Compose Version used: 1.4.0-beta?

    val columnState = rememberScalingLazyListState()
    ScreenScaffold(scrollState = columnState) {
        /*
         * The Horologist [ScalingLazyColumn] takes care of the horizontal and vertical
         * padding for the list, so there is no need to specify it, as in the [GreetingScreen]
         * composable.
         */
        androidx.wear.compose.foundation.lazy.ScalingLazyColumn(
            state = columnState,
            userScrollEnabled = false,
        ) {
            item {
                ResponsiveListHeader(contentPadding = firstItemPadding()) {
                    Text(text = "Header")
                }
            }
            item {
                TitleCard(title = { Text("Example Title") }, onClick = { }) {
                    Text("Example Content\nMore Lines\nAnd More")
                }
            }
            item {
                Chip(label = "Example Chip", onClick = { })
            }
            item {
                Button(
                    imageVector = Icons.Default.Build,
                    contentDescription = "Example Button",
                    onClick = { showDialog = true }
                )
            }
        }
    }

Comments

st...@google.com <st...@google.com> #2Aug 19, 2024 12:28PM

Assigned to mk...@google.com.

Project: platform/frameworks/support
Branch: androidx-main
Author: Louis Pullen-Freilich <lpf@google.com>
Link: https://android-review.googlesource.com/3328184

Adds OverscrollEffect#withoutDrawing and OverscrollEffect#withoutEventHandling

Expand for full commit details

Adds OverscrollEffect#withoutDrawing and OverscrollEffect#withoutEventHandling 
 
These APIs allow overscroll to have events dispatched to it by one component, and rendered in a separate component. 
 
Fixes: b/266550551 
Fixes: b/204650733 
Fixes: b/255554340 
Fixes: b/229537244 
Test: OverscrollTest 
Relnote: "Adds OverscrollEffect#withoutDrawing and OverscrollEffect#withoutEventHandling APIs - these APIs create a wrapped instance of the provided overscroll effect that doesn't draw / handle events respectively, which allows for rendering  overscroll in a separate component from the component that is dispatching events. For example, disabling drawing the overscroll inside a lazy list, and then drawing the overscroll separately on top / elsewhere." 
Change-Id: Idbb3d91546b49c1987a041f959bce4b2b09a9f61

Files:

M compose/foundation/foundation/api/current.txt
M compose/foundation/foundation/api/restricted_current.txt
M compose/foundation/foundation/integration-tests/foundation-demos/src/main/java/androidx/compose/foundation/demos/OverscrollDemo.kt
M compose/foundation/foundation/samples/src/main/java/androidx/compose/foundation/samples/OverscrollSample.kt
M compose/foundation/foundation/src/androidInstrumentedTest/kotlin/androidx/compose/foundation/OverscrollTest.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/Overscroll.kt

Hash: f64e25b7a473c757d080521e7dd97b3f6670f60d
Date: Fri Nov 01 18:43:56 2024

st...@google.com <st...@google.com> #3Sep 3, 2024 10:44AM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.compose.foundation:foundation:1.8.0-alpha06
androidx.compose.foundation:foundation-android:1.8.0-alpha06
androidx.compose.foundation:foundation-jvmstubs:1.8.0-alpha06
androidx.compose.foundation:foundation-linuxx64stubs:1.8.0-alpha06

mk...@google.com <mk...@google.com> Sep 3, 2024 05:17PM

Accepted by mk...@google.com.

mk...@google.com <mk...@google.com> Sep 9, 2024 01:26PM

Marked as fixed.

ap...@google.com <ap...@google.com> #4Sep 9, 2024 01:29PM

Project: platform/frameworks/support
Branch: androidx-main

commit 59eaabb2da2d6e71eeabf8d74bbc0dd9c04bb8df
Author: mkulaha <mkulaha@google.com>
Date: Mon Sep 09 11:58:40 2024

Disable rotary scroll in ScalingLazyColumn when userScrollEnabled flag is false

Bug: 360295825,
Test: ScalingLazyColumnTest
Relnote: "Fixing bug when rotary in ScalingLazyColumn was not disabled when userScrollEnabled flag was set to false"
Change-Id: I490ab6859a0ccd7cd12d26acabb8d8a9eade4086

M wear/compose/compose-foundation/src/androidTest/kotlin/androidx/wear/compose/foundation/lazy/ScalingLazyColumnTest.kt
M wear/compose/compose-foundation/src/main/java/androidx/wear/compose/foundation/lazy/ScalingLazyColumn.kt

https://android-review.googlesource.com/3259812

Issue 360295825