IssueTracker

Which API level are you seeing the issue here with?

My hunch is that this is related to https://android-review.git.corp.google.com/c/platform/frameworks/support/+/2293199, since using a DialogFragment or ComponentDialog adds a new Window that the contained ComposeView is not aware of.

I've only tested this on API level 33 and 26 so far, and out of these two I'm seeing this only on 33

Hello,

We're also experiencing this issue starting from compose 1.4.0-alpha03 and API level >= 30.

Attaching min repro project. Similar issue was filed in Aug 25, 2021 here https://issuetracker.google.com/issues/197769310 which was closed as duplicate of https://issuetracker.google.com/issues/204502668

Experiencing the same issue. Slowly migrating the project to compose and i still need the some compose views to be inside a DialogFragment.

Faced the same and like #3 mentioned, compose switched to use a DialogWindowProvider to figure out its window.

To workaround it in the meantime I copied ComposeView and made it report my dialog window. Not easy, but you cant get past creating a subclass.

internal abstract class ComposeBottomSheetFragment : BottomSheetDialogFragment() { // Can be simple DialogFragment

  @Composable protected abstract fun Content()

  override fun onCreateView(inflater: LayoutInflater, container: ViewGroup?, savedInstanceState: Bundle?): View? {
    return ComposeDialogView(requireContext()).also {
      it.consumeWindowInsets = false
      it.layoutParams = LayoutParams(MATCH_PARENT, WRAP_CONTENT)
      it.setContent {
        OurTheme { Content() }
      }
    }
  }

  // Copy of ComposeView that is able to supply the dialog window to compose.
  // I used inner class but you can also pass a lambda to the view and lazily request the window
  inner class ComposeDialogView(context: Context) : AbstractComposeView(context, null, 0), DialogWindowProvider {


    // The important bit
    override val window get() = requireDialog().window!!

    private val content = mutableStateOf<(@Composable () -> Unit)?>(null)

    override var shouldCreateCompositionOnAttachedToWindow: Boolean = false
      private set

    @Composable
    override fun Content() {
      content.value?.invoke()
    }

    override fun getAccessibilityClassName(): CharSequence = ComposeView::class.java.name

    /**
     * Set the Jetpack Compose UI content for this view.
     * Initial composition will occur when the view becomes attached to a window or when
     * [createComposition] is called, whichever comes first.
     */
    fun setContent(content: @Composable () -> Unit) {
      shouldCreateCompositionOnAttachedToWindow = true
      this.content.value = content
      if (isAttachedToWindow) createComposition()
    }
  }

  private var ComposeDialogView.consumeWindowInsets: Boolean
    get() = getTag(androidx.compose.ui.R.id.consume_window_insets_tag) as? Boolean ?: true
    set(value) {
      setTag(androidx.compose.ui.R.id.consume_window_insets_tag, value)
    }
}

That workaround should work, due to this line: https://cs.android.com/androidx/platform/frameworks/support/+/androidx-main:compose/ui/ui/src/androidMain/kotlin/androidx/compose/ui/text/input/InputMethodManager.kt;l=159;drc=16ad8c080ac1284a39ca331e4a6169646b82e62a

Only seeing this issue on API 30 and above also makes sense, due to the underlying mechanics.

I tested with the stable 1.4.0 version, having the same problem.

The solution in #7 causes NPE at times when used with DialogFragment. Not sure how to get around it, seems to be a timing issue since it is not occurring 100 % of the time. Is there a way to guarantee that the dialog window exist when onCreateView is called?

It looks like in my case that it tries to fetch the window to close the soft keyboard after the dialog window has disappeared

java.lang.NullPointerException
at com.xyz.compose.ComposeDialogFragment$windowProvider$2$1.getWindow(ComposeFragment.kt:101)
at com.xyz.compose.ComposeDialogFragment$ComposeDialogView.getWindow(Unknown Source:2)
at androidx.compose.ui.text.input.ImmHelper30.findWindow(InputMethodManager.kt:159)
at androidx.compose.ui.text.input.ImmHelper30.getInsetsControllerCompat(InputMethodManager.kt:133)
at androidx.compose.ui.text.input.ImmHelper30.hideSoftInput(InputMethodManager.kt:152)
at androidx.compose.ui.text.input.InputMethodManagerImpl.hideSoftInput(InputMethodManager.kt:83)
at androidx.compose.ui.text.input.TextInputServiceAndroid.setKeyboardVisibleImmediately(TextInputServiceAndroid.android.kt:397)
at androidx.compose.ui.text.input.TextInputServiceAndroid.processInputCommands(TextInputServiceAndroid.android.kt:302)
at androidx.compose.ui.text.input.TextInputServiceAndroid.sendInputCommand$lambda$1(TextInputServiceAndroid.android.kt:209)
at androidx.compose.ui.text.input.TextInputServiceAndroid.$r8$lambda$tFIm8sXGny3G873nGUe23EJe7OY(Unknown Source:0)
at androidx.compose.ui.text.input.TextInputServiceAndroid$$ExternalSyntheticLambda0.run(Unknown Source:2)
at androidx.compose.ui.text.input.TextInputServiceAndroid_androidKt.asExecutor$lambda$1$lambda$0(TextInputServiceAndroid.android.kt:504)
at androidx.compose.ui.text.input.TextInputServiceAndroid_androidKt.$r8$lambda$RYljF3nl5HRu6JKEM8xFRHwbGFg(Unknown Source:0)
at androidx.compose.ui.text.input.TextInputServiceAndroid_androidKt$$ExternalSyntheticLambda0.doFrame(Unknown Source:2)
at android.view.Choreographer$CallbackRecord.run(Choreographer.java:1229)
at android.view.Choreographer$CallbackRecord.run(Choreographer.java:1239)
at android.view.Choreographer.doCallbacks(Choreographer.java:899)
at android.view.Choreographer.doFrame(Choreographer.java:827)
at android.view.Choreographer$FrameDisplayEventReceiver.run(Choreographer.java:1214)
at android.os.Handler.handleCallback(Handler.java:942)
at android.os.Handler.dispatchMessage(Handler.java:99)
at android.os.Looper.loopOnce(Looper.java:201)
at android.os.Looper.loop(Looper.java:288)
at android.app.ActivityThread.main(ActivityThread.java:7872)
at java.lang.reflect.Method.invoke(Native Method)
at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:548)
at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:936)

Any progress on this issue? Seems like it breaks a lot of things, I can't migrate to 1.4

There is any plan about which version is the bug fix planned to be released in?

The plan is to release this with Compose 1.4.2 (and next 1.5.0 alpha) later this week, and it's corresponding BOM versions.

Thanks for the explanation, so the BOM versions will also be updated within a month (like 2023.04.xx)? If so, that will be great!

The following release(s) address this bug.It is possible this bug has only been partially addressed:

• androidx.compose.foundation:foundation:1.4.2
• androidx.compose.ui:ui:1.4.2