IssueTracker

Maybe a dup of b/368420773?

Android Gradle Plugin: 8.7.1

Could you try the latest canary, AGP 8.8.0-alpha09?

I just updated to Android Gradle Plugin: 8.7.2 and the bug is fixed.

I spoke too soon. The bug appears gone when I use a different computer, but that is only because the lint check is disabled on it. The computer with the false positive is a new cloning of my github project which apparently has the lint check enabled. The AGP 8.8.0-alpha09 plugin will not work on ladybug, and I'm too busy to switch to a canary build of android studio just to fix a false positive lint check, sorry.

I understand that it's not trivial to change AGP version; sorry for suggesting that first.

Actually, there is a better way to test: android.experimental.lint.version=8.8.0-alpha09 which will just change the Lint version.

I decided it was easier to download Android Studio Ladybug Feature Drop | 2024.2.2 Canary 9 than to figure out how to use a different version of lint (a search of stackoverflow suggests this is impossible for what that is worth). Using AGP 8.8.0-alpha09 and gradle-8.10.2-bin.zip on Canary the same error occurs. It looks like it is caused by the K2 compiler mode, because the Inspections options for this lint check does not appear until you enble K2 mode (nor does the false positive error).

Thank you for trying the latest canary version of Studio and AGP, I really appreciate that.

I rather confirmed that, with that canary (AGP 8.8.0-alpha09), b/368420773 is really fixed, with the attached reproduction project there. (Note that that issue is also related to K2 mode.)

I also tried altering problematic produceState call with conditional assignment to value, which also works fine. I tried a similar code pattern on compose runtime ProduceStateDetector and its tests, but no luck.

Then... my next guess is whether it is from an old compose runtime, assuming this might be a dup of b/349411310. May I ask which version(s) of Compose runtime (and related libraries) you're using?

The compose runtime is from the androidx-compose-bom = "2024.10.01", which is 1.7.5, which is the latest stable version according to its webpage. The project uses libs.versions.toml and gradle assures me that all the versions are up to date (for what that is worth - sometimes I have to manually update versions). I enclose the libs.versions.toml the project uses. The project is my copy of the "Crane" sample app which I have verbosely commented and try to keep up to date with the latest libraries and APIs. The source code involved is in my github repo in the Crane project:

https://github.com/markgray/Composables

The file the false positive is in is:

Crane/app/src/main/java/androidx/compose/samples/crane/details/DetailsActivity.kt

Thank you again for sharing all the details!

With the repo, I can reproduce the issue:

$ ./gradlew lint
> Task :app:lintDebug FAILED
Lint found 1 errors, 8 warnings. First failure:

.../Composables/Crane/app/src/main/java/androidx/compose/samples/crane/details/DetailsActivity.kt:243: Error: produceState calls should assign value inside the producer lambda [ProduceStateDoesNotAssignValue from androidx.compose.runtime]
    val uiState: DetailsScreenUiState by produceState(
                                         ~~~~~~~~~~~~

   Explanation for issues of type "ProduceStateDoesNotAssignValue":
   produceState returns an observable State using values assigned inside the
   producer lambda. If the lambda never assigns (i.e value = foo), then the
   State will never change. Make sure to assign a value when the source you
   are producing values from changes / emits a new value. For sample usage see
   the produceState documentation.

   Vendor: Jetpack Compose
   Identifier: androidx.compose.runtime
   Feedback: https://issuetracker.google.com/issues/new?component=612128

...

FAILURE: Build failed with an exception.
...

which is a build error in CLI. That is indeed a dup of b/368420773, and if I updated AGP/gradle:

$ git diff
diff --git a/Crane/gradle/libs.versions.toml b/Crane/gradle/libs.versions.toml
index c3b2e3ca..c488d929 100644
--- a/Crane/gradle/libs.versions.toml
+++ b/Crane/gradle/libs.versions.toml
@@ -4,7 +4,7 @@
 #####
 [versions]
 accompanist = "0.34.0"
-androidGradlePlugin = "8.7.2"
+androidGradlePlugin = "8.8.0-alpha09"
 androidx-activity-compose = "1.9.3"
 androidx-appcompat = "1.7.0"
 androidx-benchmark = "1.3.3"
diff --git a/Crane/gradle/wrapper/gradle-wrapper.properties b/Crane/gradle/wrapper/gradle-wrapper.properties
index 1918a64e..9c74e424 100644
--- a/Crane/gradle/wrapper/gradle-wrapper.properties
+++ b/Crane/gradle/wrapper/gradle-wrapper.properties
@@ -14,6 +14,6 @@
 #Sat Nov  2 07:49:36 AM EDT 2024
 distributionBase=GRADLE_USER_HOME
 distributionPath=wrapper/dists
-distributionUrl=https\://services.gradle.org/distributions/gradle-8.9-bin.zip
+distributionUrl=https\://services.gradle.org/distributions/gradle-8.10.2-all.zip
 zipStoreBase=GRADLE_USER_HOME
 zipStorePath=wrapper/dists
$ ./gradlew lint
...
BUILD SUCCESSFUL in 1m 51s
31 actionable tasks: 30 executed, 1 from cache

build went well.

However, K2 UAST's IDE path still has an issue on binary resolution for @Composable. :( That part is a dup of b/360354551. Alas, even after 2024.3 merge, it's still reproducible as attached screenshot.

Filed https://youtrack.jetbrains.com/issue/KTIJ-31887

Aha! I see the problem. I always use the "Problems" tool window of the IDE to run lint. When I use "./gradlew lint" I get the same results as you do. Apparently the IDE is running lint wrong, feeding lint mangled code, misinterpreting lint's results, or using cached values from AGP 8.7.2 instead of using 8.8.0-alpha09 values. (But these are just guesses of course.)

Apparently the IDE is running lint wrong, feeding lint mangled code, misinterpreting lint's results, or using cached values

The issue is the Kotlin compiler front end; when lint within AGP, we have to bundle and invoke our own copy of the Kotlin compiler front end. But when we run inside the IDE, we directly reuse the one from the Kotlin plugin; that way we don't have to re-analyze your code etc, so it's more performant. But that means that lint running in the IDE and lint running from AGP use potentially different versions of the front end.

Since CLI-side fix is already there, it's relatively easy(?) to port that to IDE-side, and actually ready; see attached screenshot.

Thanks for explaining Tor, that makes sense. I've filed b/364864906 on our component to track how to handle this for AndroidX going forward.

Thank you for your patience while our engineering team worked to resolve this issue. A fix for this issue is now available in:

• Android Studio Ladybug Feature Drop | 2024.2.2 Canary 1
• Android Gradle Plugin 8.8.0-alpha01

We encourage you to try the latest update.

If you notice further issues or have questions, please file a new bug report.

Thank you for taking the time to submit feedback — we really appreciate it!

The fixes for this issue are now also available in:

• Android Studio Ladybug | 2024.2.1 Beta 2
• Android Gradle Plugin 8.7.0-beta02

We encourage you to try the latest update.

If you notice further issues or have questions, please file a new bug report.

We are grateful