Status Update
No update yet.
Comments
cc...@google.com
ja...@gmail.com
The traces that are generated are correctly being parsed by
Attached is an example trace.
ja...@gmail.com
That file works for me as well, something is different about the ones I captured (likely device on which it was captured). Filed
@Leland - you should be able to workaround not getting usable macro traces by either trying a different device/OS image, or viewing the traces in
ma...@google.com
Reassigning to the default assignee given it looks like a Studio issue. Will wait for activity on the blocking bug.
ja...@gmail.com
Bugjuggler:
ma...@google.com
As discused in
Working on a fix.
ja...@gmail.com
Branch: androidx-main
commit 8f2ba6a5469f67b7e385878d704f97bde22419ce
Author: Chris Craik <ccraik@google.com>
Date: Mon Apr 08 14:49:54 2024
Fix macrobench method tracing flush on slower devices
Fixes: 329904950
Test: Enabled method tracing in SmallListStartupBenchmark
Relnote: "Fixed method traces flush in macrobench, so that method
traces are complete even on slower devices."
Change-Id: I6349a48dca4116ac9b481882395ee630785f6181
M benchmark/benchmark-common/src/main/java/androidx/benchmark/Shell.kt
M benchmark/benchmark-macro/src/main/java/androidx/benchmark/macro/MacrobenchmarkScope.kt
ch...@google.com
The following release(s) address this bug.It is possible this bug has only been partially addressed:
androidx.benchmark:benchmark-common:1.3.0-alpha03androidx.benchmark:benchmark-macro:1.3.0-alpha03
ja...@gmail.com
I've just tried AGP 8.6.0 and 8.7.0-beta01 with the sample project I attached and both still display the redundant variants in AS Koala Feature Drop | 2024.1.2 and AS Ladybug | 2024.2.1 Beta 1.
Also, the ./gradlew tasks --all command for both mentioned AGP versions displays all the usual tasks for each of these variants. In turn, simple command like ./gradlew :app:assemble will assemble even the redundant variants.
The 'variant's experimental properties' were mentioned. Are they applied automatically by BP plugin or should they be specified manually somewhere?
ma...@google.com
For this bug we're looking at 2 things: -
- the additional build types that are created to generate baseline profiles and benchmark
- the build types that are visible in AS
There is a bug that should be fixed by aosp/3260794 about build types that should not be created. The AS part was to check that these wouldn't be visible. Will add this to version 1.3.1.
Thanks
ap...@google.com
Branch: androidx-main
commit e75f0a518d11e27d4862ef903a9b29e64c0d6625
Author: Marcello Albano <maralb@google.com>
Date: Mon Sep 09 14:00:46 2024
Don't create nonMinified and benchmark build types if existing
Bug: 361370179
Test: ./gradlew :benchmark:benchmark-baseline-profile-gradle-plugin:test
Relnote: "Due to a bug even if nonMinified and
benchmark build types existed, they were going to
be recreated."
Change-Id: Ia8934fdf3ff51d993f4fef8195821d72315026e2
M benchmark/baseline-profile-gradle-plugin/src/main/kotlin/androidx/baselineprofile/gradle/apptarget/BaselineProfileAppTargetPlugin.kt
M benchmark/baseline-profile-gradle-plugin/src/test/kotlin/androidx/baselineprofile/gradle/apptarget/BaselineProfileAppTargetPluginTest.kt
M benchmark/baseline-profile-gradle-plugin/src/test/kotlin/androidx/baselineprofile/gradle/utils/TestUtils.kt
na...@google.com
The following release(s) address this bug.It is possible this bug has only been partially addressed:
androidx.benchmark:benchmark-baseline-profile-gradle-plugin:1.3.1
Description
Component used: Baseline Profile Gradle Plugin
Version used: 1.3.0
Devices/Android versions reproduced on: Android Studio Jellyfish/AGP 8.4.2 and Koala/AGP 8.5.2
I want to customize the generatedhttps://developer.android.com/topic/performance/baselineprofiles/configure-baselineprofiles#variant-specific-dependencies
benchmarkReleaseandnonMinifiedReleasebuild variants, which are generated by the Baseline Profile Gradle Plugin. So I follow the documentation:If (as per the docs) I add
benchmarkRelease {}andnonMinifiedRelease {}blocks in Groovy script, I gain a bloated list of build variants. The list goes really wild havingnonMinifiedBenchmarkReleasevariant and some others. See attached screenshots. Same happens to Kotlin script, if I usecreate("benchmarkRelease") {}, as equivalent to Groovy's code.Please fix the creating of the redundant build variants.
I have no sample project attached, as the issue is reproducible on a newly generated Android project with a freshly generated Baseline Profile Generator module. Also, the version of the latter should be bumped to 1.3.0, as the default one is 1.2.3 in AS Koala.