Assigned
Status Update
Comments
ap...@google.com <ap...@google.com> #2
Project: platform/frameworks/support
Branch: androidx-main
commit 79cf1e8166e55022c643ee6acfad74fc64512a23
Author: Chris Craik <ccraik@google.com>
Date: Mon Aug 26 11:01:11 2024
Fix assert in VelocityTrackerBenchmark
Test: VelocityTrackerBenchmark
Bug: 362283861
Change-Id: If0add5a942e1a39fa9feff579291f5672d77f188
M compose/ui/ui/benchmark/src/androidTest/java/androidx/compose/ui/benchmark/input/pointer/VelocityTrackerBenchmark.kt
https://android-review.googlesource.com/3242563
Branch: androidx-main
commit 79cf1e8166e55022c643ee6acfad74fc64512a23
Author: Chris Craik <ccraik@google.com>
Date: Mon Aug 26 11:01:11 2024
Fix assert in VelocityTrackerBenchmark
Test: VelocityTrackerBenchmark
Bug: 362283861
Change-Id: If0add5a942e1a39fa9feff579291f5672d77f188
M compose/ui/ui/benchmark/src/androidTest/java/androidx/compose/ui/benchmark/input/pointer/VelocityTrackerBenchmark.kt
ap...@google.com <ap...@google.com> #3
Project: platform/frameworks/support
Branch: androidx-main
commit 75d676a5cd6c56f6b12eff3d74394b6c00332269
Author: Chris Craik <ccraik@google.com>
Date: Mon Aug 26 10:35:50 2024
Swap assert() to assertTrue() in benchmark tests
Bug: 362283861
Test: Presubmit
Our tests always run in debug, so this isn't really necessary, just
making this change to make it easier to search for problem assert
usages in benchmarks.
Change-Id: I82b5734368e83f6c5d3281eb37e8f104a79b883f
M benchmark/benchmark-common/src/androidTest/java/androidx/benchmark/InMemoryTracingTest.kt
M benchmark/benchmark-common/src/androidTest/java/androidx/benchmark/PerfettoTraceTest.kt
M benchmark/benchmark-common/src/androidTest/java/androidx/benchmark/ResultWriterTest.kt
https://android-review.googlesource.com/3242327
Branch: androidx-main
commit 75d676a5cd6c56f6b12eff3d74394b6c00332269
Author: Chris Craik <ccraik@google.com>
Date: Mon Aug 26 10:35:50 2024
Swap assert() to assertTrue() in benchmark tests
Bug: 362283861
Test: Presubmit
Our tests always run in debug, so this isn't really necessary, just
making this change to make it easier to search for problem assert
usages in benchmarks.
Change-Id: I82b5734368e83f6c5d3281eb37e8f104a79b883f
M benchmark/benchmark-common/src/androidTest/java/androidx/benchmark/InMemoryTracingTest.kt
M benchmark/benchmark-common/src/androidTest/java/androidx/benchmark/PerfettoTraceTest.kt
M benchmark/benchmark-common/src/androidTest/java/androidx/benchmark/ResultWriterTest.kt
ap...@google.com <ap...@google.com> #4
Project: platform/frameworks/support
Branch: androidx-main
commit 085ee3f10ee2a8bbc7094723da7bf2f284bbdb1d
Author: Chris Craik <ccraik@google.com>
Date: Mon Aug 26 12:27:51 2024
Fix NestedScrollingBenchmark asserts and suppress
Bug: 362302352
Bug: 362283861
Test: NestedScrollingBenchmark
Change-Id: Ic93f142f6563f28e0ced1361cee963c6c66e3ac8
M compose/ui/ui/benchmark/src/androidTest/java/androidx/compose/ui/benchmark/NestedScrollingBenchmark.kt
https://android-review.googlesource.com/3242329
Branch: androidx-main
commit 085ee3f10ee2a8bbc7094723da7bf2f284bbdb1d
Author: Chris Craik <ccraik@google.com>
Date: Mon Aug 26 12:27:51 2024
Fix NestedScrollingBenchmark asserts and suppress
Bug: 362302352
Bug: 362283861
Test: NestedScrollingBenchmark
Change-Id: Ic93f142f6563f28e0ced1361cee963c6c66e3ac8
M compose/ui/ui/benchmark/src/androidTest/java/androidx/compose/ui/benchmark/NestedScrollingBenchmark.kt
Description
Microbenchmark runs in release mode, where
assert()
is a noop.I only see [a couple of in our internal benchmarks](https://cs.android.com/search?q=%22assert(%22%20language:kotlin%20file:benchmark%20case:yes&sq=&ss=androidx%2Fplatform%2Fframeworks%2Fsupport) , but these should be fixed.