Fixed
Status Update
Comments
va...@google.com <va...@google.com> #2
Would you accept external contributions for this ticket? I would gladly contribute implementation for this.
ci...@google.com <ci...@google.com> #3
Absolutely, we'd be happy to accept a pull request for this if you'd like follow our
va...@google.com <va...@google.com> #4
ap...@google.com <ap...@google.com> #5
Project: platform/frameworks/support
Branch: androidx-main
Author: Csaba Kozák <
Link:
[GH] Add support for List<Enum> arguments in typesafe navigation
Expand for full commit details
[GH] Add support for List<Enum> arguments in typesafe navigation
## Proposed Changes
Add support for List<Enum> arguments in typesafe navigation
## Testing
Test: ./gradlew navigation:navigation-common:test
Test: ./gradlew navigation:navigation-common:cC
Test: ./gradlew navigation:navigation-runtime:cC
## Issues Fixed
Fixes: 375559962
This is an imported pull request from https://github.com/androidx/androidx/pull/725.
Resolves #725
Github-Pr-Head-Sha: 79289f5cd89a355aa44ac1a7190301cde1e03ae9
GitOrigin-RevId: 5d12e8b036e98d45944806f1d16a00b0769b49e2
Change-Id: Ie67dc9665634751da06fad21c93e9475627e7e62
Files:
- M
navigation/navigation-common/src/androidTest/java/androidx/navigation/serialization/RouteDecoderTest.kt
- M
navigation/navigation-common/src/androidTest/java/androidx/navigation/serialization/RouteFilledTest.kt
- M
navigation/navigation-common/src/main/java/androidx/navigation/serialization/NavTypeConverter.kt
- M
navigation/navigation-common/src/test/java/androidx/navigation/serialization/NavArgumentGeneratorTest.kt
- M
navigation/navigation-runtime/src/androidTest/java/androidx/navigation/NavControllerRouteTest.kt
Hash: 061287da098c4249bbe0b3a10add04feb9bdf5ae
Date: Mon Nov 18 22:24:48 2024
va...@google.com <va...@google.com>
pr...@google.com <pr...@google.com> #6
Fixed externally and will be available in navigation 2.8.5
Description
Jetpack Compose version:
Material Library Version (M2, M3 or Both?):
Material Compose component used:
androidx.compose.material3.Scaffold
Steps to Reproduce:
MainActivity.kt
, (a)enableEdgeToEdge
is called and (b)Scaffold's PaddingValues
(calledinnerPadding
here) is applied to the entire content.See attached image (
Scaffold_DisplayCutout.png
). I've modified the sample code to make the issue more apparent. Notice the Composable, which is usinginnerPadding
, avoids the system bars region but does not avoid the display cutout region.Severity: To ensure Scaffold's edge-to-edge is enforced in Android 15.
PaddingValues
makes going edge-to-edge easy, it should account for display cutouts. Otherwise, developers shouldn't use Scaffold'sPaddingValues
and should instead use alternatives likeWindowInsets.safeDrawing
,WindowInsets.safeGestures
, orWindowInsets.safeContent
. This is especially important as