Fixed
Status Update
Comments
va...@google.com <va...@google.com> #2
I can create the change if this component is accepting external contributions?
ci...@google.com <ci...@google.com> #3
External PRs are welcome!
va...@google.com <va...@google.com> #4
Is there any update/progress on this. This is much needed for the case where we want bottom sheet as destination
ap...@google.com <ap...@google.com> #5
I've created a PR for this, can you please take a look? Thanks in advance.
va...@google.com <va...@google.com>
pr...@google.com <pr...@google.com> #6
Project: platform/frameworks/support
Branch: androidx-main
Author: Ondřej Kycelt <
Link:
Expose sheetGesturesEnabled in ModalBottomSheetLayout
Expand for full commit details
Expose sheetGesturesEnabled in ModalBottomSheetLayout
Test: ./gradlew compose:material:material-navigation:cC
Bug: 329543529
Relnote: Expose `sheetGesturesEnabled` in `ModalBottomSheetLayout`
Change-Id: I3f032d9016b1730b1a90392209f7c07fa6617343
Files:
- M
compose/material/material-navigation/api/current.txt
- M
compose/material/material-navigation/api/restricted_current.txt
- M
compose/material/material-navigation/src/main/java/androidx/compose/material/navigation/BottomSheet.kt
Hash: ce608883ec1c53a771e59afcc8c09d429a11009d
Date: Fri Dec 13 11:43:10 2024
Description
Jetpack Compose version:
Material Library Version (M2, M3 or Both?):
Material Compose component used:
androidx.compose.material3.Scaffold
Steps to Reproduce:
MainActivity.kt
, (a)enableEdgeToEdge
is called and (b)Scaffold's PaddingValues
(calledinnerPadding
here) is applied to the entire content.See attached image (
Scaffold_DisplayCutout.png
). I've modified the sample code to make the issue more apparent. Notice the Composable, which is usinginnerPadding
, avoids the system bars region but does not avoid the display cutout region.Severity: To ensure Scaffold's edge-to-edge is enforced in Android 15.
PaddingValues
makes going edge-to-edge easy, it should account for display cutouts. Otherwise, developers shouldn't use Scaffold'sPaddingValues
and should instead use alternatives likeWindowInsets.safeDrawing
,WindowInsets.safeGestures
, orWindowInsets.safeContent
. This is especially important as