ModalBottomSheet making status icons invisible in dark status bar [362539765]

Verified

Bug

Status Update

No update yet.

Description

ma...@wnco.com

created issue #1

Aug 27, 2024 10:30PM

Jetpack Compose version: 2024.08.00 BOM

Material Library Version: "androidx.compose.material3:material3:1.3.0-rc01

Material Compose component used: ModalBottomSheet

Android Studio Build: 2024.1.1 Patch 2

Kotlin version: 1.9.0

Steps to Reproduce or Code Sample to Reproduce:

Set app theme status bar to always have dark background and light icons (regardless of dark/light theme)
Set device theme to light mode
Draw a half screen modal bottom sheet
Observe Status bar icons are darkened and barely visible behind scrim on dark background

Expected behavior:

ModalBottomSheet should not change status bar icon color unless it is expanded into the status bar. Or there should be an option to override it.

Comments

ma...@wnco.com <ma...@wnco.com> #2Aug 27, 2024 10:32PM

I have the same problem. I hope this issue gets resolved quickly.

ma...@wnco.com <ma...@wnco.com> #3Aug 28, 2024 02:47PM

I'm having the same problem, which makes this a dealbreaker for using it unfortunately.

Message last modified on Aug 28, 2024 02:47PM

re...@gmail.com <re...@gmail.com> #4Sep 10, 2024 06:00AM

I have somewhat tracked down the issue here and

https://issuetracker.google.com/268380384

In the other bug, the underlying popup is not set as focusable, so the keyboard opens. In alpha08 we have set the popup as focusable to intercept focus when the popup opens for A11y purposes. However it has the unintended consequence of intercepting ime actions, for some reason not passing them to child content despite the content (like textfield) still being focusable... Working on a solution.

Message last modified on Sep 10, 2024 06:01AM

do...@gmail.com <do...@gmail.com> #5Sep 10, 2024 06:07AM

I find a way to make TextField editable for me. you can make a try.

ModalBottomSheet(/* .... */) {
    
    // add follow code here to make your text filed edtable.
    val view = LocalView.current.rootView.allViews
                    .filter { it.javaClass.name == "androidx.compose.ui.window.PopupLayout" }
                    .toList()
                    .first()
    (view.context.getSystemService(Context.WINDOW_SERVICE) as WindowManager)
                    .updateViewLayout(view,
                        (view.layoutParams as WindowManager.LayoutParams).apply {
                            flags = flags and WindowManager.LayoutParams.FLAG_NOT_FOCUSABLE.inv()
                        })
    
    // your bottom sheet content code
    TextField(/* ... */)
}

se...@google.com <se...@google.com> Sep 30, 2024 06:45PM

Reassigned to se...@google.com.

se...@google.com <se...@google.com> Oct 2, 2024 07:18PM

Accepted by se...@google.com.

ap...@google.com <ap...@google.com> #6Oct 16, 2024 05:29PM

Has anyone found any way to fix this?

se...@google.com <se...@google.com> #7Oct 16, 2024 05:31PM

Marked as fixed.

This issue which extends to any custom windows seems to have been resolved with: https://issuetracker.google.com/262140644

Waiting on that change to land to proceed on this issue.

pr...@google.com <pr...@google.com> #8Oct 30, 2024 05:37PM

Project: platform/frameworks/support
Branch: androidx-main

commit 7545cec3617ab5d1ea83d66822bc094e7f03c562
Author: José Figueroa Santos <serniebanders@google.com>
Date: Wed Apr 19 16:04:18 2023

[Material3][gradle] Update compose dependencies to 1.4.2

Upgrade needed to intake the following bug fix:

b/262140644

, which resolves issue of new windows not calling IME keyboard.

Bug: 268380384
Bug: 272483584
RelNote: ModalBottomSheet now can display IME keyboard
Test: Manual
Change-Id: Idc5082008acb547cac2100a69cab4be7db85f50f

M compose/material3/material3/build.gradle
M compose/material3/material3/samples/src/main/java/androidx/compose/material3/samples/BottomSheetSamples.kt

https://android-review.googlesource.com/2548352

do...@gmail.com <do...@gmail.com> #9Nov 6, 2024 09:54PM

It doesn't seem to be fixed for me. I used a snapshot build from androidx.dev (9991820) which has the updated dependencies, but the keyboard still doesn't show up when a text field is focused. It also no longer shows up once the bottom sheet is dismissed, so something did change, but not enough.

se...@google.com <se...@google.com> Nov 8, 2024 07:00PM

Status: Assigned (reopened)

ap...@google.com <ap...@google.com> #10Nov 11, 2024 04:56PM

@ Comment#9 what device and API are you using.

se...@google.com <se...@google.com> #11Nov 11, 2024 05:06PM

Verified by se...@google.com.

I tested on a Pixel 7 running Android 14 Beta 1 and a Galaxy S23 Ultra running Android 13, both with Gboard.

When I tap a text field, it focuses and the cursor shows up, but the text scrubber handle also appears and is aligned to the top of the field instead of below the text.

ap...@google.com <ap...@google.com> #12Apr 1, 2025 05:07PM

It seems to be fully fixed in 1.2.0-alpha01.